New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778852 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

add test for filtering incognito window in arc_voice_interaction

Project Member Reported by muyuanli@chromium.org, Oct 26 2017

Issue description

There should be a unittest to guard this feature.
 
Components: Privacy
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/227851d714bdc081de4c7e81669420380fa6c000

commit 227851d714bdc081de4c7e81669420380fa6c000
Author: Muyuan Li <muyuanli@chromium.org>
Date: Tue Feb 13 20:16:02 2018

arc: add test for blocking incognito windows in screenshot

BUG= 778852 
TEST=ArcVoiceInteractionFrameworkServiceUnittest.
  CapturingScreenshotBlocksIncognitoWindows

Change-Id: I0bfa5a486759783d7c8926a309c6b5da9b02dcc6
Reviewed-on: https://chromium-review.googlesource.com/914983
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536438}
[modify] https://crrev.com/227851d714bdc081de4c7e81669420380fa6c000/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/227851d714bdc081de4c7e81669420380fa6c000/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h
[modify] https://crrev.com/227851d714bdc081de4c7e81669420380fa6c000/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment