DCHECK() failed at URLDataManagerBackend::CheckURLIsValid() |
|||||||
Issue description
When running the following browser tests using "--enable-features=NetworkService" flag, they fail at:
DCHECK(url.SchemeIs(kChromeUIScheme) ||
(GetContentClient()->browser()->GetAdditionalWebUISchemes(
&additional_schemes),
SchemeIsInSchemes(url.scheme(), additional_schemes)));
at //content/browser/webui/url_data_manager_backend.cc
-CrSettingsPeoplePageTest.All
The |url| is: http://pushed-url/
-DomDistillerTabUtilsBrowserTest.TestDistillIntoWebContents
-DomDistillerViewerSourceBrowserTest.DistillerJavaScriptExposed
-DomDistillerViewerSourceBrowserTest.DistillerJavaScriptNotInMainWorld
-DomDistillerViewerSourceBrowserTest.EarlyTemplateLoad
-DomDistillerViewerSourceBrowserTest.MultiPageArticle
-DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticleExists
-DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticleNotFound
-DomDistillerViewerSourceBrowserTest.PrefPersist
The |url| is: https://fonts.googleapis.com/css?family=Roboto
-PrintPreviewDialogControllerBrowserTest.PdfPluginDisabled
-PrintPreviewDialogControllerBrowserTest.PrintPreviewPdfAccessibility
The |url| is: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/elements/viewer-error-screen/viewer-error-screen.html
,
Nov 7 2017
The DOM ones are because dom-distiller is making a web request for a font. I suspect we don't want that, but I'll double check with the webui team.
,
Nov 8 2017
,
Nov 8 2017
,
Nov 8 2017
,
Nov 8 2017
,
Nov 8 2017
+rbpotter, thestig: I am wondering if the Print preview related errors are just because the tests need to updated, or whether turning on --enable-features=NetworkService would break the prod code.
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bd29fe940ec239c59ee61fc36998089062019dc commit 2bd29fe940ec239c59ee61fc36998089062019dc Author: John Abd-El-Malek <jam@chromium.org> Date: Fri Nov 10 00:40:05 2017 Fix CrSettingsPeoplePageTest.All with network service. The renderer has webui bindings, so it can't load web schemes. BUG= 778846 Change-Id: I37cfbaf471381e4d22508ec80fc843f9ced31c8d Reviewed-on: https://chromium-review.googlesource.com/759032 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#515372} [modify] https://crrev.com/2bd29fe940ec239c59ee61fc36998089062019dc/chrome/browser/ui/search/local_ntp_browsertest.cc [modify] https://crrev.com/2bd29fe940ec239c59ee61fc36998089062019dc/chrome/test/data/webui/settings/people_page_test.js [modify] https://crrev.com/2bd29fe940ec239c59ee61fc36998089062019dc/chrome/test/data/webui/settings/test_profile_info_browser_proxy.js [modify] https://crrev.com/2bd29fe940ec239c59ee61fc36998089062019dc/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Nov 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb0bc8e94dc7bd997775105c44f864248a5e02fa commit bb0bc8e94dc7bd997775105c44f864248a5e02fa Author: John Abd-El-Malek <jam@chromium.org> Date: Sat Nov 11 01:08:15 2017 Improve security of WebUI with network service. 1) Ensure that renderers that don't have WebUI bindings don't have access to URLLoaders for all of WebUI. Some WebUI schemes, like chrome-distiller or chrome-devtools, don't have WebUI bindings. This is accomplished by having the URLLoaderFactory for webui scheme get constructed with which scheme it's allowed to access. 2) Only renderers serving WebUI schemes that don't have WebUI bindings get a URLLoader for the network. BUG=776887, 778846 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I6b432e5ef8659f3799a546913678760eb39b7d5f Reviewed-on: https://chromium-review.googlesource.com/758301 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#515774} [modify] https://crrev.com/bb0bc8e94dc7bd997775105c44f864248a5e02fa/content/browser/bad_message.h [modify] https://crrev.com/bb0bc8e94dc7bd997775105c44f864248a5e02fa/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/bb0bc8e94dc7bd997775105c44f864248a5e02fa/content/browser/loader/navigation_url_loader_network_service.cc [add] https://crrev.com/bb0bc8e94dc7bd997775105c44f864248a5e02fa/content/browser/network_service_browsertest.cc [modify] https://crrev.com/bb0bc8e94dc7bd997775105c44f864248a5e02fa/content/browser/webui/web_ui_url_loader_factory.cc [modify] https://crrev.com/bb0bc8e94dc7bd997775105c44f864248a5e02fa/content/browser/webui/web_ui_url_loader_factory.h [modify] https://crrev.com/bb0bc8e94dc7bd997775105c44f864248a5e02fa/content/common/navigation_subresource_loader_params.h [modify] https://crrev.com/bb0bc8e94dc7bd997775105c44f864248a5e02fa/content/test/BUILD.gn [modify] https://crrev.com/bb0bc8e94dc7bd997775105c44f864248a5e02fa/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/bb0bc8e94dc7bd997775105c44f864248a5e02fa/tools/metrics/histograms/enums.xml
,
Nov 11 2017
Turning on --enable-features=NetworkService breaks print preview. Should I file a separate bug for that? Very excited about the NetworkService concept though!
,
Nov 11 2017
Really, it breaks the PDF Viewer inside print preview. Viewing PDFs is also broken. Clicking a PDF link will trigger a download instead.
,
Nov 29 2017
@Lei: plugins aren't working with network service yet. bug 705114 tracks that.
,
Nov 29 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by laforge@google.com
, Nov 7 2017