New issue
Advanced search Search tips

Issue 778842 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 769401



Sign in to add a comment

WebUIURLLoaderFactory doesn't handle empty responses

Project Member Reported by juncai@chromium.org, Oct 26 2017

Issue description

When the following browser tests run with "--enable-features=NetworkService" flag:
DevToolsReattachAfterCrashTest.TestReattachAfterCrashOnNetwork
DevToolsReattachAfterCrashTest.TestReattachAfterCrashOnTimeline

They fail at:
//content/browser/webui/web_ui_url_loader_factory.cc(100)
Check failed: num_bytes == output_size (65536 vs. 0)

 

Comment 1 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 2 by jam@chromium.org, Nov 21 2017

Owner: jam@chromium.org
Status: Started (was: Available)
Summary: WebUIURLLoaderFactory doesn't handle empty responses (was: CHECK_EQ(num_bytes, output_size) failed in ReadData() at web_ui_url_loader_factory.cc)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2be253070ca3af41157dd771e1de8fc30c7c19f

commit b2be253070ca3af41157dd771e1de8fc30c7c19f
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Nov 21 16:40:34 2017

Fix crash in network service webui code when the source gives an empty string.

This is handled correctly by the old webui case.

BUG:  778842 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I39013667b9038e9687b418905e56e93868017b24
Reviewed-on: https://chromium-review.googlesource.com/781419
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518275}
[modify] https://crrev.com/b2be253070ca3af41157dd771e1de8fc30c7c19f/content/browser/webui/web_ui_url_loader_factory.cc
[modify] https://crrev.com/b2be253070ca3af41157dd771e1de8fc30c7c19f/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 4 by jam@chromium.org, Nov 21 2017

Status: Fixed (was: Started)

Sign in to add a comment