Browser popup in immersive mode with immersive reveal have their tops clipped in overview. |
||||
Issue description(1) Open browser popup window (eg. settings). (2) Enter immersive mode (press F4 or enter tablet mode). (3) move mouse or finger to top of screen to reveal immersive title bar (4) hit F5 to enter overview mode. Actual: In the overview item the top is clipped. Expected: It should not be clipped.
,
Nov 1 2017
This bug is related to one of my fixes for overview mode, so I take this one. Put a cl to https://chromium-review.googlesource.com/c/chromium/src/+/750078
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85a465380e41389d2e922edbe9c63769115dd802 commit 85a465380e41389d2e922edbe9c63769115dd802 Author: wutao <wutao@chromium.org> Date: Mon Nov 13 23:19:32 2017 Fix overview mode HideHeader for popup window in immersive mode. When popup window, e.g. settings, in immersive fullscreen is with immersive revealed, the top view inset should be 0 otherwise in the overview mode it will clip extra part of the popup window. Bug: 778840 Test: On emulator and device. Change-Id: Id0c3ac949186101fe6dca201a133e3258cfa2454 Reviewed-on: https://chromium-review.googlesource.com/750078 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#516092} [modify] https://crrev.com/85a465380e41389d2e922edbe9c63769115dd802/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/85a465380e41389d2e922edbe9c63769115dd802/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
,
Jan 10 2018
,
Jan 12 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by wutao@chromium.org
, Oct 30 2017Labels: -Pri-3 Pri-2