New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778829 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

ThumbnailDiskStorageTest#testRemoveAllThumbnailsWithSameContentId is flaky

Project Member Reported by pdr@chromium.org, Oct 26 2017

Issue description

This test is still flaky:
org.chromium.chrome.browser.widget.ThumbnailDiskStorageTest#testRemoveAllThumbnailsWithSameContentId

Recent failure:
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/415843
(this is after https://chromium-review.googlesource.com/730874)

Failure:
java.lang.AssertionError: Criteria not met in allotted time.
 
Labels: -Pri-3 OS-Android Pri-1
This should be higher priority, since it causes CQ to retry jobs.
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/429327
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94850fa8d7dff1246d965cb19cc24864e13ddc94

commit 94850fa8d7dff1246d965cb19cc24864e13ddc94
Author: Tommy Nyquist <nyquist@chromium.org>
Date: Fri Nov 17 00:34:32 2017

Disable flaky test ThumbnailDiskStorageTest#testRemoveAllThumbnailsWithSameContentId

TBR=qinmin@chromium.org
BUG=778829
NOTRY=true

Change-Id: I7f95b097012f6bb5b46458c43e71edf4a5861c8c
Reviewed-on: https://chromium-review.googlesource.com/776127
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517227}
[modify] https://crrev.com/94850fa8d7dff1246d965cb19cc24864e13ddc94/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ThumbnailDiskStorageTest.java

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29467520e7850fac4ab73de2be0f9557e6aa9085

commit 29467520e7850fac4ab73de2be0f9557e6aa9085
Author: Min Qin <qinmin@chromium.org>
Date: Mon Nov 27 21:15:09 2017

Fix flaky ThumbnailDiskStorageTest

When these tests start, there could be some files in the disk cache.
The tests did call mTestThumbnailDiskStorage.clear() in setUp().
However, they did not clear the removeCount value.
As a result, tests can fail if the removeCount is not initiazed to 0.

BUG=786212,778829

Change-Id: I0f797b019ed5e0cb3b6148da9b79d9679c125a43
Reviewed-on: https://chromium-review.googlesource.com/783494
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519405}
[modify] https://crrev.com/29467520e7850fac4ab73de2be0f9557e6aa9085/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ThumbnailDiskStorageTest.java

Sign in to add a comment