ThumbnailDiskStorageTest#testRemoveAllThumbnailsWithSameContentId is flaky |
|
Issue descriptionThis test is still flaky: org.chromium.chrome.browser.widget.ThumbnailDiskStorageTest#testRemoveAllThumbnailsWithSameContentId Recent failure: https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/415843 (this is after https://chromium-review.googlesource.com/730874) Failure: java.lang.AssertionError: Criteria not met in allotted time.
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94850fa8d7dff1246d965cb19cc24864e13ddc94 commit 94850fa8d7dff1246d965cb19cc24864e13ddc94 Author: Tommy Nyquist <nyquist@chromium.org> Date: Fri Nov 17 00:34:32 2017 Disable flaky test ThumbnailDiskStorageTest#testRemoveAllThumbnailsWithSameContentId TBR=qinmin@chromium.org BUG=778829 NOTRY=true Change-Id: I7f95b097012f6bb5b46458c43e71edf4a5861c8c Reviewed-on: https://chromium-review.googlesource.com/776127 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#517227} [modify] https://crrev.com/94850fa8d7dff1246d965cb19cc24864e13ddc94/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ThumbnailDiskStorageTest.java
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29467520e7850fac4ab73de2be0f9557e6aa9085 commit 29467520e7850fac4ab73de2be0f9557e6aa9085 Author: Min Qin <qinmin@chromium.org> Date: Mon Nov 27 21:15:09 2017 Fix flaky ThumbnailDiskStorageTest When these tests start, there could be some files in the disk cache. The tests did call mTestThumbnailDiskStorage.clear() in setUp(). However, they did not clear the removeCount value. As a result, tests can fail if the removeCount is not initiazed to 0. BUG=786212,778829 Change-Id: I0f797b019ed5e0cb3b6148da9b79d9679c125a43 Reviewed-on: https://chromium-review.googlesource.com/783494 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519405} [modify] https://crrev.com/29467520e7850fac4ab73de2be0f9557e6aa9085/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ThumbnailDiskStorageTest.java |
|
►
Sign in to add a comment |
|
Comment 1 by ynovikov@chromium.org
, Nov 14 2017