New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778828 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[Samus] Recovery PostInstall failed on DUT

Project Member Reported by pgangishetty@chromium.org, Oct 26 2017

Issue description

Chrome Version: 63.0.3239.20 
OS: 10032.17.0

What steps will reproduce the problem?
(1) Start installing recovery build using USB stick
(2) Verification process completed on the device
(3) Now system recovery is in progress


What is the expected result?
Recovery should be successful without any error message

What happens instead?
'An unexpected error has occurred' message is displayed. (screenshot attached)


Please use labels and text to provide additional information.
Logs and screenshot attached.  

Starting Google_Samus firmware updater v4 (recovery)...
 - Updater package: [Google_Samus.6300.174.0 / EC:samus_v1.7.703-f30d79f / PD:samus_pd_v1.7.703-f30d79f]
 - Current system:  [RO:Google_Samus.6300.174.0 , ACT:Google_Samus.6300.174.0 / EC:samus_v1.7.703-f30d79f / PD:samus_pd_v1.7.703-f30d79f]
 - Write protection: Hardware: off, Software: Main=ON EC=off PD=off
recovery: update RO+RW
 * invoke: flashrom -p host --fast-verify -w bios.bin
recovery: update ec/RO+RW
 * invoke: ectool --dev=0 reboot_ec RO
 Execution failed (127): ectool --dev=0 reboot_ec RO
 Messages:
./updater4.sh: 32: ectool --dev=0 reboot_ec RO: not found
ERROR: Execution FAILED.
ERROR: Execution failed: ./updater4.sh (error code = 1)
Finished after 22 seconds.
Failed Command: //usr/sbin/chromeos-firmwareupdate --mode=recovery - Exit Code 1
Firmware update failed (error code: 1).
Rolling back update due to failure installing required firmware.
Successfully updated GPT with all settings to rollback.
PostInstall Failed

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Tried with M63 builds: 10032.17.0/63.0.3239.20  & 10032.14.0/63.0.3239.17 and both builds failed recovery.  

Able to recover same DUT with M62 Beta build 9901.51.0/62.0.3202.67

Comment 3 by ka...@chromium.org, Oct 26 2017

Cc: bhthompson@chromium.org
Components: OS>Firmware

Comment 4 by ka...@chromium.org, Oct 26 2017

Cc: gkihumba@chromium.org
Cc: sha...@chromium.org furquan@chromium.org wnhuang@chromium.org
+more ectool committers for guidance.

Comment 6 by sha...@chromium.org, Oct 27 2017

Cc: -wnhuang@chromium.org dlaurie@chromium.org
The ectool dependency comes from here:

https://chrome-internal.googlesource.com/chromeos/overlays/overlay-samus-private/+/71f955e01f1ad36eb23f12085e4313316516cd7c

We'll run into this failure if we attempt to flash RO (eg. system is unprotected). We should probably re-add ectool into the samus shipping image, although it might also be acceptable to remove the sysjump workaround entirely, on the assumption that all unprotected Samus devices with old RO have already been updated.

Comment 7 by sha...@chromium.org, Oct 27 2017

Cc: wnhuang@chromium.org
Cc: hungte@chromium.org
The firmware updater should be bundling a local copy of ectool, but it doesn't seem to be found?

https://chrome-internal.googlesource.com/chromeos/overlays/overlay-samus-private/+/master/chromeos-base/chromeos-firmware-samus/chromeos-firmware-samus-9999.ebuild#46

Agreed that we can just remove this hook and code and I can send a commit for that, but it might be worth understanding why it is suddenly failing..


Comment 9 by hungte@chromium.org, Oct 27 2017

Owner: vapier@chromium.org
I think that was caused by removal of eval. vapier previously removed eval so a quoted command will be executed as-is, i.e., having params merged into command name...
odd, i've been using recovery images on samus for testing quite a bit lately and haven't seen this

at any rate, posted CLs to fix it
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2017

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 27 2017

Labels: Merge-Request-63
ToT should be fixed now
Project Member

Comment 14 by sheriffbot@chromium.org, Oct 27 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-63 Merge-Approved-63
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 28 2017

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 30 2017

Labels: merge-merged-release-R63-10032.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-samus-private/+/4b074bcd85dd22a8cbdbd8ae75f8a0b784acec39

commit 4b074bcd85dd22a8cbdbd8ae75f8a0b784acec39
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Oct 30 18:06:20 2017

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 30 2017

Labels: -Merge-Approved-63 Merge-Merged
Status: Fixed (was: Untriaged)

Sign in to add a comment