New issue
Advanced search Search tips

Issue 778823 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocked on:
issue 778822



Sign in to add a comment

[iOS] Remove legacy fullscreen controller code

Project Member Reported by kkhorimoto@chromium.org, Oct 26 2017

Issue description

see go/bijou-fullscreen-migration for more details.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e348427745f1578f43e5c6660ba2b17e778ee60c

commit e348427745f1578f43e5c6660ba2b17e778ee60c
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Wed Nov 01 23:37:33 2017

[iOS] Rename FullScreenController to LegacyFullscreenController.

This is to avoid naming conflicts with the new FullscreenController that
is being created.

Bug:  778823 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3f12af21706a90d4b0d99c9a9beddd60b115f0e0
Reviewed-on: https://chromium-review.googlesource.com/740676
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513323}
[modify] https://crrev.com/e348427745f1578f43e5c6660ba2b17e778ee60c/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/e348427745f1578f43e5c6660ba2b17e778ee60c/ios/chrome/browser/snapshots/web_controller_snapshot_helper.mm
[modify] https://crrev.com/e348427745f1578f43e5c6660ba2b17e778ee60c/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/e348427745f1578f43e5c6660ba2b17e778ee60c/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/e348427745f1578f43e5c6660ba2b17e778ee60c/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/e348427745f1578f43e5c6660ba2b17e778ee60c/ios/chrome/browser/ui/fullscreen/BUILD.gn
[modify] https://crrev.com/e348427745f1578f43e5c6660ba2b17e778ee60c/ios/chrome/browser/ui/fullscreen/DEPS
[rename] https://crrev.com/e348427745f1578f43e5c6660ba2b17e778ee60c/ios/chrome/browser/ui/fullscreen/legacy_fullscreen_controller.h
[rename] https://crrev.com/e348427745f1578f43e5c6660ba2b17e778ee60c/ios/chrome/browser/ui/fullscreen/legacy_fullscreen_controller.mm
[rename] https://crrev.com/e348427745f1578f43e5c6660ba2b17e778ee60c/ios/chrome/browser/ui/fullscreen/legacy_fullscreen_controller_unittest.mm
[modify] https://crrev.com/e348427745f1578f43e5c6660ba2b17e778ee60c/ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm
[modify] https://crrev.com/e348427745f1578f43e5c6660ba2b17e778ee60c/ios/chrome/browser/web/chrome_web_test.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c49ea3bfba8a2eb2d8d70e5972db8d596937256

commit 4c49ea3bfba8a2eb2d8d70e5972db8d596937256
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Nov 02 14:10:41 2017

Revert "[iOS] Rename FullScreenController to LegacyFullscreenController."

This reverts commit e348427745f1578f43e5c6660ba2b17e778ee60c.

Reason for revert: only CL affecting ios/ in range causing regression of the EG tests, reverting speculatively (see  crbug.com/780828 ).

Original change's description:
> [iOS] Rename FullScreenController to LegacyFullscreenController.
> 
> This is to avoid naming conflicts with the new FullscreenController that
> is being created.
> 
> Bug:  778823 
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I3f12af21706a90d4b0d99c9a9beddd60b115f0e0
> Reviewed-on: https://chromium-review.googlesource.com/740676
> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#513323}

TBR=rohitrao@chromium.org,marq@chromium.org,sdefresne@chromium.org,kkhorimoto@chromium.org

Change-Id: Ia1f416b98697bbd063a8164db5d24b66334e37ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  778823 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/750090
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513479}
[modify] https://crrev.com/4c49ea3bfba8a2eb2d8d70e5972db8d596937256/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/4c49ea3bfba8a2eb2d8d70e5972db8d596937256/ios/chrome/browser/snapshots/web_controller_snapshot_helper.mm
[modify] https://crrev.com/4c49ea3bfba8a2eb2d8d70e5972db8d596937256/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/4c49ea3bfba8a2eb2d8d70e5972db8d596937256/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/4c49ea3bfba8a2eb2d8d70e5972db8d596937256/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/4c49ea3bfba8a2eb2d8d70e5972db8d596937256/ios/chrome/browser/ui/fullscreen/BUILD.gn
[modify] https://crrev.com/4c49ea3bfba8a2eb2d8d70e5972db8d596937256/ios/chrome/browser/ui/fullscreen/DEPS
[rename] https://crrev.com/4c49ea3bfba8a2eb2d8d70e5972db8d596937256/ios/chrome/browser/ui/fullscreen/fullscreen_controller.h
[rename] https://crrev.com/4c49ea3bfba8a2eb2d8d70e5972db8d596937256/ios/chrome/browser/ui/fullscreen/fullscreen_controller.mm
[rename] https://crrev.com/4c49ea3bfba8a2eb2d8d70e5972db8d596937256/ios/chrome/browser/ui/fullscreen/fullscreen_controller_unittest.mm
[modify] https://crrev.com/4c49ea3bfba8a2eb2d8d70e5972db8d596937256/ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm
[modify] https://crrev.com/4c49ea3bfba8a2eb2d8d70e5972db8d596937256/ios/chrome/browser/web/chrome_web_test.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62e97c708dbfceaa835ad746c56cffa7e1c0978e

commit 62e97c708dbfceaa835ad746c56cffa7e1c0978e
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Fri Nov 03 19:51:47 2017

[iOS] Rename FullScreenController to LegacyFullscreenController.

This is to avoid naming conflicts with the new FullscreenController that
is being created.

Bug:  778823 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8e253cc26a7800c35ff0e5c5cc31c4b0d5f42238
Reviewed-on: https://chromium-review.googlesource.com/752221
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513881}
[modify] https://crrev.com/62e97c708dbfceaa835ad746c56cffa7e1c0978e/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/62e97c708dbfceaa835ad746c56cffa7e1c0978e/ios/chrome/browser/snapshots/web_controller_snapshot_helper.mm
[modify] https://crrev.com/62e97c708dbfceaa835ad746c56cffa7e1c0978e/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/62e97c708dbfceaa835ad746c56cffa7e1c0978e/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/62e97c708dbfceaa835ad746c56cffa7e1c0978e/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/62e97c708dbfceaa835ad746c56cffa7e1c0978e/ios/chrome/browser/ui/fullscreen/BUILD.gn
[modify] https://crrev.com/62e97c708dbfceaa835ad746c56cffa7e1c0978e/ios/chrome/browser/ui/fullscreen/DEPS
[rename] https://crrev.com/62e97c708dbfceaa835ad746c56cffa7e1c0978e/ios/chrome/browser/ui/fullscreen/legacy_fullscreen_controller.h
[rename] https://crrev.com/62e97c708dbfceaa835ad746c56cffa7e1c0978e/ios/chrome/browser/ui/fullscreen/legacy_fullscreen_controller.mm
[rename] https://crrev.com/62e97c708dbfceaa835ad746c56cffa7e1c0978e/ios/chrome/browser/ui/fullscreen/legacy_fullscreen_controller_unittest.mm
[modify] https://crrev.com/62e97c708dbfceaa835ad746c56cffa7e1c0978e/ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm
[modify] https://crrev.com/62e97c708dbfceaa835ad746c56cffa7e1c0978e/ios/chrome/browser/web/chrome_web_test.mm

Status: Fixed (was: Assigned)

Sign in to add a comment