Custom Network Throttling Profiles not working
Reported by
matt.k...@uptake.com,
Oct 26 2017
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3250.0 Safari/537.36 Steps to reproduce the problem: 1. Add a custom Network Throttling Profile in DevTools 2. Select profile as active. Alert icon indicates that Network throttling is enabled. 3. Load or reload page on same tab where DevTools options were made active. What is the expected behavior? Some obvious change in Network performance What went wrong? Network performance was not impacted. Default built-in network throttling profiles work fine (Slow 3G and Fast 3G) Did this work before? N/A Chrome version: 64.0.3250.0 Channel: canary OS Version: OS X 10.12.6 Flash Version: This should be easily reproducible. If not, I will add further information.
,
Oct 30 2017
,
Oct 30 2017
,
Oct 30 2017
Thank you for your work on this. I apologize, I assumed the Slow 3G and Fast 3G profiles were working properly, but the issue is the *Latency* field has no impact. I am working on a screen capture. Since the scope of the bug has changed, please let me know if I should file a new bug. To produce the bug, set the latency to some high number like 5000ms and test a page load.
,
Oct 30 2017
Please see attached screen capture. Trying to introduce latency through network profiles has no impact on network requests. Sorry again for initial confusion. Please let me know if a new bug should be opened.
,
Nov 20 2017
Can I get confirmation on this? Should I open a new bug? Please see screen capture on comment #5.
,
Nov 20 2017
I can repro this. The bug occurs when you modify latency and not up/down bandwidth. I'm working on a fix here: https://chromium-review.googlesource.com/c/chromium/src/+/767749
,
Nov 21 2017
Thank you Will!
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/104fdb77d5f5755006c47784dac744f3ac30cc74 commit 104fdb77d5f5755006c47784dac744f3ac30cc74 Author: Will Chen <chenwilliam@chromium.org> Date: Mon Nov 27 23:05:15 2017 DevTools: fix network throttling when only latency is set Bug: 778817 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I132ebf5b4fc2b56d68cadf1adb1c06c83eaa2da0 Reviewed-on: https://chromium-review.googlesource.com/767749 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#519441} [modify] https://crrev.com/104fdb77d5f5755006c47784dac744f3ac30cc74/content/network/throttling/throttling_controller_unittest.cc [modify] https://crrev.com/104fdb77d5f5755006c47784dac744f3ac30cc74/content/network/throttling/throttling_network_interceptor.cc
,
Dec 13 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jmukthavaram@chromium.org
, Oct 30 2017Labels: Needs-Triage-M64 Needs-Feedback
4.1 MB
4.1 MB View Download