New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 778800 link

Starred by 1 user
Status: Assigned
Owner:
█ servolk@chromium.org
Last visit > 30 days ago
Cc:
xhw...@chromium.org
█ servolk@chromium.org
wolenetz@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Return value of WebSourceBufferClient::InitializationSegmentReceived() is ignored by WMPI

Project Member Reported by wolenetz@chromium.org, Oct 26 2017 
From looking at the code, it's possible that blink might return false (indicating failure). If that's the case, WMPI might need to condition its behavior rather than just ignore the retval.

This bug tracks looking into this code smell.

Comment 1 by wolenetz@chromium.org, Oct 26 2017

Cc: wolenetz@chromium.org
Owner: servolk@chromium.org
servolk@ - can you please take a look? If you're certain that the checks in SourceBuffer::InitializationSegmentReceived() are a subset of those in SourceBufferState::OnNewConfigs() (IOW, if InitializationSegmentReceived cannot fail in any path), then please at least add a DCHECK on it's retval in WMPI.

If it could perhaps fail though, the comment in https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp?sq=package:chromium&l=831 is incorrect: the caller ignores retval, instead of doing the necessary error processing.
►

Sign in to add a comment