New issue
Advanced search Search tips

Issue 778793 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

PreviewsBrowserTest.NoScriptPreviewsEnabled test failing on mojo_linux bot

Project Member Reported by qin...@chromium.org, Oct 26 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2969c1f7e694dc1165ab9fc4e4b231fc4a19b97

commit a2969c1f7e694dc1165ab9fc4e4b231fc4a19b97
Author: Min Qin <qinmin@chromium.org>
Date: Thu Oct 26 20:59:56 2017

Disable PreviewsBrowserTest.NoScriptPreviewsEnabled on mojo_linux

TBR=dougarnett@chromium.org
BUG= 778793 

Change-Id: Ib47735f739995b1aa2385992225f6653636c91bf
Reviewed-on: https://chromium-review.googlesource.com/740367
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511954}
[modify] https://crrev.com/a2969c1f7e694dc1165ab9fc4e4b231fc4a19b97/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Components: UI>Browser>Previews
Labels: -Pri-3 OS-Linux OS-Windows Pri-2
https://build.chromium.org/p/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/30579 is the same failure on a try bot. The failure is roughly the same:

[ RUN      ] PreviewsBrowserTest.NoScriptPreviewsEnabled
Xlib:  extension "RANDR" missing on display ":99".
[452:479:1026/134547.613509:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin
[487:487:1026/134547.720508:ERROR:gpu_info.cc(103)] No active GPU found, returning primary GPU.
[452:452:1026/134547.745912:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[452:479:1026/134547.773364:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin
[492:513:1026/134547.903517:WARNING:simple_synchronous_entry.cc(1110)] Could not open platform files for entry.
[452:481:1026/134547.904691:ERROR:service_manager.cc(157)] Connection InterfaceProviderSpec prevented service: content_utility from binding interface: content::mojom::FieldTrialRecorder exposed by: content_browser
[452:453:1026/134547.928683:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /noscript_test.js
[452:453:1026/134547.946363:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico
../../chrome/browser/previews/previews_browsertest.cc:88: Failure
Value of: noscript_css_requested()
  Actual: false
Expected: true
../../chrome/browser/previews/previews_browsertest.cc:89: Failure
Value of: noscript_js_requested()
  Actual: true
Expected: false
[452:452:1026/134547.991207:INFO:chrome_cryptauth_service.cc(222)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[452:452:1026/134548.116594:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] PreviewsBrowserTest.NoScriptPreviewsEnabled, where TypeParam =  and GetParam() =  (1115 ms)

Comment 3 by bengr@chromium.org, Oct 30 2017

Status: Assigned (was: Untriaged)
Status: Untriaged (was: Assigned)
Assigned to nobody -> kicking it back to untriaged.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/343050a1e0044146277b500603eb38b1ead55fe5

commit 343050a1e0044146277b500603eb38b1ead55fe5
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Tue Nov 28 08:22:59 2017

Filter PreviewsNoScriptBrowserTest.NoScriptPreviewsEnabledHttpRedirectToHttps

with Network Service.

Looks like related to other preview ones.

TBR=jam@chromium.org
NOTRY=true

Bug:  778793 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7b380d8d0e2a702e11652d9cd911faf9d0473d56
Reviewed-on: https://chromium-review.googlesource.com/792314
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519605}
[modify] https://crrev.com/343050a1e0044146277b500603eb38b1ead55fe5/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 6 by bengr@chromium.org, Nov 29 2017

Cc: -dougarnett@chromium.org
Labels: M-64
Owner: dougarnett@chromium.org
Status: Assigned (was: Untriaged)
Cc: dougarnett@chromium.org
Labels: -M-64 M-65
Owner: bengr@chromium.org
Status: Available (was: Assigned)
Able to repro locally with  --enable-features=NetworkService

This is problem with content::PreviewsState not being set at the beginning of navigation nor updated at commit time. 

The initial value is determined from call to ChromeResourceDispatcherHostDelegate::DeterminePreviewsState() from either ResourceDispatcherHostImpl::BeginNavigationRequest() or ResourceDispatcherHostImpl::ContinuePendingBeginRequest().

Another missing delegate piece is in updating the state for the committed navigation done in ChromeResourceDispatcherHostDelegate::OnResponseStarted().


Assigning to bengr@ to direct to whoever is slated to help us with servicification.

Comment 8 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 9 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Comment 10 by bengr@chromium.org, Dec 19 2017

Owner: reillyg@chromium.org

Comment 11 by bengr@chromium.org, Dec 19 2017

Status: Assigned (was: Available)
Refreshed during triage.
Refreshed during triage.
Refreshed during triage.

Refreshed during triage.
Cc: ryansturm@chromium.org
Refreshed during triage. I'm looking at a similar problem for Previews, so hopefully I can address this for non-DRP previews.
Labels: -OS-Windows Proj-Servicification-Canary
Labels: OS-Android OS-Chrome OS-Mac OS-Windows
Labels: -Proj-Servicification-Canary Proj-Servicification
Labels: Hotlist-KnownIssue
marking it as a known-issue.
Refreshed during triage.
Project Member

Comment 22 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72b74d82cd06a5e7c002a9d1e212cff4315c6b71

commit 72b74d82cd06a5e7c002a9d1e212cff4315c6b71
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Thu Nov 01 18:18:49 2018

[Previews] Adding tests to verify opt outs being recorded correctly.

This adds tests to verify that opt outs are actually recorded and
tracked appropriately for Previews.

Bug:  900724 , 778793 
Change-Id: Ib927645256eeeb7df08092eeb80f5652f295edbc
Reviewed-on: https://chromium-review.googlesource.com/c/1311375
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604643}
[modify] https://crrev.com/72b74d82cd06a5e7c002a9d1e212cff4315c6b71/chrome/browser/previews/previews_browsertest.cc
[modify] https://crrev.com/72b74d82cd06a5e7c002a9d1e212cff4315c6b71/chrome/browser/previews/previews_ui_tab_helper_unittest.cc
[modify] https://crrev.com/72b74d82cd06a5e7c002a9d1e212cff4315c6b71/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Owner: ryansturm@chromium.org
Status: Started (was: Assigned)
I'm going to fix this.
Project Member

Comment 24 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18899cb9b101f738354a36cb05283edcdb90fcf5

commit 18899cb9b101f738354a36cb05283edcdb90fcf5
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Thu Nov 01 20:27:39 2018

[Previews] Turning on previews tests for network service enabled

This requires 2 things: more robustly setting the Network Quality and
turning on Data Reduction Network Service feature. The latter is
required because IsDataReductionProxyEnabled is used by previews to
determine whether the user is a data saver user.

Bug:  778793 
Change-Id: Ib0721ecb6bc25f2f324a966a997d3a6c2f5e60a5
Reviewed-on: https://chromium-review.googlesource.com/c/1313070
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604691}
[modify] https://crrev.com/18899cb9b101f738354a36cb05283edcdb90fcf5/chrome/browser/previews/previews_browsertest.cc
[modify] https://crrev.com/18899cb9b101f738354a36cb05283edcdb90fcf5/chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
[modify] https://crrev.com/18899cb9b101f738354a36cb05283edcdb90fcf5/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Status: Fixed (was: Started)

Sign in to add a comment