New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778771 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 778773
issue 778833
issue 779272

Blocking:
issue 675997
issue 779291
issue 810917



Sign in to add a comment

Turn Android Release (Nexus 6P) GPU.FYI bot into Swarming bot

Project Member Reported by ynovikov@chromium.org, Oct 26 2017

Issue description

Currently https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%206P%29 aka build89-b1 is a one-off machine with Nexus 6P device connected to it.

We want to make it similar to Android Release (Nexus 5X) bot, which has a virtual slave and the actual devices in the swarming pool.

This would make it simper to maintain and avoid issues arising from differences between swarmed and non-swarmed configurations, like the one in issue 675997.

Steps to take:
 - Ask the Labs team to provision a new Linux VM which will become the new "Android Release (Nexus 6P)" bot
 - Change tools/build/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py to make the bot match the configuration of "Android Release (Nexus 5X)", namely:
   - 'enable_swarming': True,
   - Remove this line to look like the 5X bot:
     - 'android_apply_config': ['restart_usb', 'use_devil_adb'],
 - Modify configs/chromium-swarm/bots.cfg per:
https://www.chromium.org/developers/testing/gpu-testing/gpu-bot-details#TOC-Relevant-files-that-control-the-operation-of-the-GPU-bots
   to assign the existing 6P (for example) bot into the Chrome-GPU pool.
 - Ask the Labs team to put the 6P bot into Swarming.
 - Modify generate_buildbot_json.py to use Swarming on this bot.
 - Adjust shard timeouts since we'll have only one bot.

 
Blockedon: 778773
Blockedon: 778833
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/2377114ac52e9ad4438ae52567add3e1a1bf2181

commit 2377114ac52e9ad4438ae52567add3e1a1bf2181
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Thu Oct 26 23:28:56 2017

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 26 2017

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dcef1a6328360813e6eb5d5614d40cec7e5dffb

commit 8dcef1a6328360813e6eb5d5614d40cec7e5dffb
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri Oct 27 00:39:01 2017

Turn Android Release (Nexus 6P) into swarmed bot

BUG= 778771 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id5d3abcc91431ab2189a7e74cb82d648d62c4de2
Reviewed-on: https://chromium-review.googlesource.com/740682
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512043}
[modify] https://crrev.com/8dcef1a6328360813e6eb5d5614d40cec7e5dffb/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/8dcef1a6328360813e6eb5d5614d40cec7e5dffb/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/d4bd0b3118f7a0ddb5f0dcd405ab1218538263ec

commit d4bd0b3118f7a0ddb5f0dcd405ab1218538263ec
Author: Kenneth Russell <kbr@google.com>
Date: Fri Oct 27 21:08:36 2017

Blockedon: 779272
Blockedon: 779291
https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%206P%29/builds/8590 is the first Swarmed build. Seems to have a problem running 6 WebGL CTS shards one after another on the same Nexus 6P device.

Opened issue 779272 to get more devices and issue 779291 to investigate the failure.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/588951e1f40c11598be0ec97416014bac5aaf2ab

commit 588951e1f40c11598be0ec97416014bac5aaf2ab
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Wed Nov 01 02:43:34 2017

Run tests in parallel on Nexus 6P GPU.FYI

Now that we have 5 devices, we can stop serializing the tests.

BUG= chromium:778771 

Change-Id: I5a7991c6bd14be142c0d17b49a0481620cc3bf7c
Reviewed-on: https://chromium-review.googlesource.com/748441
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

[modify] https://crrev.com/588951e1f40c11598be0ec97416014bac5aaf2ab/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py

Status: Fixed (was: Started)
The bot works well now with 7 Nexus 6P devices.

Comment 12 by kbr@chromium.org, Nov 10 2017

Excellent! Thanks Yuly for shepherding this task through!

Do we need to follow up on Issue 779291?

I think Ben will handle it. Should I remove it from blocking list? I want to keep the context.

Comment 14 by kbr@chromium.org, Nov 11 2017

Blockedon: -779291
Blocking: 779291
Let's move it from the Blocked on to Blocking list.

Comment 15 by kbr@chromium.org, Feb 9 2018

Blocking: 810917

Sign in to add a comment