New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 778768 link

Starred by 1 user
Status: Started
Owner:
rogerm@chromium.org
Cc:
█ dlkumar@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[autofill] Rationalize CC-Name vs Name predictions

Project Member Reported by rogerm@chromium.org, Oct 26 2017 
If field order is not taken into account, CC-Name and Name field predictions can be wrong if the set of fields is ambiguous.

For example, m.fancy.com and frys.com both have billing forms in their respective checkout flows with the same set of fields.

  Name + Credit Card Fields + Address Fields

For m.fancy.com, the Name field is visually associated with (and precedes) the credit card fields. For frys.com, the name field is visually associated with (and precedes) the address fields.

For m.fancy.com we want the name field predicted as CC-Name and for frys.com we (arguably) want the name predicted as Name so that the forms blocks are filled as the user would expect.

The current predictions are backwards.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f84035510e736790672318e620873d0a3fa7025

commit 0f84035510e736790672318e620873d0a3fa7025
Author: Roger McFarlane <rogerm@chromium.org>
Date: Thu Feb 22 18:40:27 2018

[autofill] Add a flag to prefer server name predictions.

Sometimes the client heuristics and server predictions disagree on
whether a "name" related field should be associated with an autofill
address or credit card.

The existing behaviour is to prefer the heuristics in these cases.
It looks like it might be better to prefer the server (and then
ensure that the server is correct) in these cases.

There are a number of top sites where the heuristics need to arrive
at opposite conclusions given essentially identical inputs.

For example given the field ordering:

  CC Number, Expiry Date, CVC, First Name, Last Name, Address,...

There are examples of sites where the first and last name are
(visually to the user) tied to filling a CC form and other
sites where the first and last name are tied to filling a
follow-on billing address.

We can resolve these differently based on form-signature on the
server side, but with the current preference, the client ignores
the servers suggestion.

This CL adds a feature flag to prefer the server predictions,
initially disabled by default, in these scenarios.

BUG=778768

Change-Id: I4a823b3a68ce9f44be8fbc8402b56d9547f3e65d
Reviewed-on: https://chromium-review.googlesource.com/924468
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538497}
[modify] https://crrev.com/0f84035510e736790672318e620873d0a3fa7025/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/0f84035510e736790672318e620873d0a3fa7025/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/0f84035510e736790672318e620873d0a3fa7025/components/autofill/core/browser/autofill_field.cc
►

Sign in to add a comment