New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778764 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Autofill tests

Project Member Reported by jzw@chromium.org, Oct 26 2017

Issue description

Create tests for autofill features.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bd9766ef73088a648794bd8077ad8d456ecdc5e

commit 5bd9766ef73088a648794bd8077ad8d456ecdc5e
Author: John Z Wu <jzw@chromium.org>
Date: Wed Nov 22 00:03:31 2017

Fake autofillagent for use in testing.

//ios/web_view needs a fake autofill agent in order to unit test
CWVAutofillController, which depends on an autofill_agent for
fetching suggestions.

Bug:  778764 
Change-Id: If6f552dc049739ea0ab322ffb50a32334ab5ce74
Reviewed-on: https://chromium-review.googlesource.com/779628
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518464}
[modify] https://crrev.com/5bd9766ef73088a648794bd8077ad8d456ecdc5e/components/autofill/ios/browser/BUILD.gn
[add] https://crrev.com/5bd9766ef73088a648794bd8077ad8d456ecdc5e/components/autofill/ios/browser/fake_autofill_agent.h
[add] https://crrev.com/5bd9766ef73088a648794bd8077ad8d456ecdc5e/components/autofill/ios/browser/fake_autofill_agent.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6d4db8ba9550f3ec84fc0b2d90e0be829a2d6ce

commit a6d4db8ba9550f3ec84fc0b2d90e0be829a2d6ce
Author: John Z Wu <jzw@chromium.org>
Date: Wed Nov 22 01:58:33 2017

Fake JsAutofillManager for tests.

//ios/web_view implements autofill and would like to use a fake
JsAutofillManager for unit tests.

Bug:  778764 
Change-Id: Iff53fdc1bd75dab4f0fbfccd6759ca54d1a9c0c1
Reviewed-on: https://chromium-review.googlesource.com/782367
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518496}
[modify] https://crrev.com/a6d4db8ba9550f3ec84fc0b2d90e0be829a2d6ce/components/autofill/ios/browser/BUILD.gn
[add] https://crrev.com/a6d4db8ba9550f3ec84fc0b2d90e0be829a2d6ce/components/autofill/ios/browser/fake_js_autofill_manager.h
[add] https://crrev.com/a6d4db8ba9550f3ec84fc0b2d90e0be829a2d6ce/components/autofill/ios/browser/fake_js_autofill_manager.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/489701cfcb0d9023e2a4d243443597a87cc47fca

commit 489701cfcb0d9023e2a4d243443597a87cc47fca
Author: John Z Wu <jzw@chromium.org>
Date: Wed Dec 20 21:20:01 2017

Integration tests for autofill. Part 1.

Ensures all delegate callbacks are properly fired.

Bug:  778764 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I75088285b45b46a086d06837c1f586e5f8d0ba9c
Reviewed-on: https://chromium-review.googlesource.com/833456
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525461}
[modify] https://crrev.com/489701cfcb0d9023e2a4d243443597a87cc47fca/ios/web_view/test/BUILD.gn
[add] https://crrev.com/489701cfcb0d9023e2a4d243443597a87cc47fca/ios/web_view/test/web_view_autofill_inttest.mm

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/009da37a65b88b9fb8ca4677bb382622fa2db04f

commit 009da37a65b88b9fb8ca4677bb382622fa2db04f
Author: John Z Wu <jzw@chromium.org>
Date: Mon Jan 29 16:51:45 2018

More integration tests for autofill in //ios/web_view.

One test that verifies fetching, filling, and clearing.

Bug:  778764 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icc484e63fc0787bdfcedca95a15528111e4d7dcb
Reviewed-on: https://chromium-review.googlesource.com/841342
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532462}
[modify] https://crrev.com/009da37a65b88b9fb8ca4677bb382622fa2db04f/ios/web_view/test/web_view_autofill_inttest.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17762b3c4210207693798f193c922b01e7cd7a58

commit 17762b3c4210207693798f193c922b01e7cd7a58
Author: Bret Sepulveda <bsep@chromium.org>
Date: Mon Jan 29 22:55:19 2018

Revert "More integration tests for autofill in //ios/web_view."

This reverts commit 009da37a65b88b9fb8ca4677bb382622fa2db04f.

Reason for revert:
The new test is flaky on iPhone 6s. Example failures:
https://ci.chromium.org/buildbot/chromium.mac/ios-simulator/28895
https://ci.chromium.org/buildbot/chromium.mac/ios-simulator/28892

Original change's description:
> More integration tests for autofill in //ios/web_view.
> 
> One test that verifies fetching, filling, and clearing.
> 
> Bug:  778764 
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: Icc484e63fc0787bdfcedca95a15528111e4d7dcb
> Reviewed-on: https://chromium-review.googlesource.com/841342
> Commit-Queue: John Wu <jzw@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532462}

TBR=eugenebut@chromium.org,jzw@chromium.org

Change-Id: I2b994d4b5592ca84f0c77f2621ae894f4d52a36b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  778764 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/892118
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532642}
[modify] https://crrev.com/17762b3c4210207693798f193c922b01e7cd7a58/ios/web_view/test/web_view_autofill_inttest.mm

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94eaf49656b04e5a1215ee8d793217e22111828b

commit 94eaf49656b04e5a1215ee8d793217e22111828b
Author: John Z Wu <jzw@chromium.org>
Date: Wed Jan 31 16:50:48 2018

[Reland] More integration tests for autofill in //ios/web_view.

One test that verifies fetching, filling, and clearing.

Bug:  778764 
Change-Id: I77653f323941a66bc1ae3c490cebb4d92de29b02
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/841342
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#532462}
Reviewed-on: https://chromium-review.googlesource.com/894483
Cr-Commit-Position: refs/heads/master@{#533300}
[modify] https://crrev.com/94eaf49656b04e5a1215ee8d793217e22111828b/ios/web_view/test/web_view_autofill_inttest.mm

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34977ddf86641e1c2c02d728e7c569c1af9cb3b8

commit 34977ddf86641e1c2c02d728e7c569c1af9cb3b8
Author: John Z Wu <jzw@chromium.org>
Date: Wed Jan 31 20:43:08 2018

Additional integration test for autofill in //ios/web_view.

- Tests fetch, remove, and fetch.

Bug:  778764 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibdf1ebcce6155060a22c2bc4578ed71babc4153d
Reviewed-on: https://chromium-review.googlesource.com/887286
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533390}
[modify] https://crrev.com/34977ddf86641e1c2c02d728e7c569c1af9cb3b8/ios/web_view/test/web_view_autofill_inttest.mm

Comment 8 by ma...@chromium.org, May 1 2018

Components: UI>Browser>Autofill
Project Member

Comment 9 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97776d1c9195a2501c0d4b701a6b40cb79ec940c

commit 97776d1c9195a2501c0d4b701a6b40cb79ec940c
Author: John Z Wu <jzw@chromium.org>
Date: Tue May 15 20:00:08 2018

Add simple unit tests for CWVAutofillProfile.

Tests initialization by checking getters return the right values. Also
checks updating by checking setters properly modify the properties.

Bug:  778764 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I01ae81f5a7475b5e1bb5548707b7d9ab1b592701
Reviewed-on: https://chromium-review.googlesource.com/1058556
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558818}
[modify] https://crrev.com/97776d1c9195a2501c0d4b701a6b40cb79ec940c/ios/web_view/BUILD.gn
[add] https://crrev.com/97776d1c9195a2501c0d4b701a6b40cb79ec940c/ios/web_view/internal/autofill/cwv_autofill_profile_unittest.mm

Project Member

Comment 10 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca478b92fa5caca5ea81c59fd593b54a0a0cbd49

commit ca478b92fa5caca5ea81c59fd593b54a0a0cbd49
Author: John Z Wu <jzw@chromium.org>
Date: Wed May 16 02:46:01 2018

Add unit tests for CWVCreditCard.

Tests initialzation properly reads the correct values, also tests
setters properly set the right values.

Bug:  778764 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I88bf70ea0fbf3e443a9a462ec46977287140e406
Reviewed-on: https://chromium-review.googlesource.com/1058593
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558937}
[modify] https://crrev.com/ca478b92fa5caca5ea81c59fd593b54a0a0cbd49/ios/web_view/BUILD.gn
[add] https://crrev.com/ca478b92fa5caca5ea81c59fd593b54a0a0cbd49/ios/web_view/internal/autofill/cwv_credit_card_unittest.mm

Project Member

Comment 11 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/300862e2b8998e8a4b0d2fa7c362f5c6b7ccdfb3

commit 300862e2b8998e8a4b0d2fa7c362f5c6b7ccdfb3
Author: John Z Wu <jzw@chromium.org>
Date: Fri May 25 17:01:09 2018

Unit tests for CWVAutofillDataManager.

Adds a unit test for every method in public API.

Bug:  778764 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0db0ef7f9d7dee1e6486bcc49953edb5a0b76f2a
Reviewed-on: https://chromium-review.googlesource.com/1065127
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561918}
[modify] https://crrev.com/300862e2b8998e8a4b0d2fa7c362f5c6b7ccdfb3/ios/web_view/BUILD.gn
[add] https://crrev.com/300862e2b8998e8a4b0d2fa7c362f5c6b7ccdfb3/ios/web_view/internal/autofill/cwv_autofill_data_manager_unittest.mm

Project Member

Comment 12 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50dab08237ee752dc6ab3c43613c1e64ed21b9ae

commit 50dab08237ee752dc6ab3c43613c1e64ed21b9ae
Author: John Z Wu <jzw@chromium.org>
Date: Fri May 25 17:19:41 2018

Add unit tests for CWVCreditCardVerifier.

Tests all public methods.

Bug:  778764 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I10d254c9c70761c780024a4711493889fedd4cb7
Reviewed-on: https://chromium-review.googlesource.com/1070598
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561926}
[modify] https://crrev.com/50dab08237ee752dc6ab3c43613c1e64ed21b9ae/ios/web_view/BUILD.gn
[add] https://crrev.com/50dab08237ee752dc6ab3c43613c1e64ed21b9ae/ios/web_view/internal/autofill/cwv_credit_card_verifier_unittest.mm
[modify] https://crrev.com/50dab08237ee752dc6ab3c43613c1e64ed21b9ae/ios/web_view/public/cwv_credit_card_verifier.h

Status: Fixed (was: Assigned)

Sign in to add a comment