New issue
Advanced search Search tips

Issue 778760 link

Starred by 1 user
Status: Verified
Owner:
p...@chromium.org
Closed: Nov 2017
Cc:
thakis@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Download Windows runtime libraries if target_os=win in .gclient

Project Member Reported by p...@chromium.org, Oct 26 2017 
We're going to need to download the Windows runtime libraries and put them in the LLVM build directory if target_os=win is in .gclient, otherwise is_asan/is_ubsan/use_cfi_diag won't work when cross-compiling.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f062d235cf3b2e94661127db71b6467d546dab33

commit f062d235cf3b2e94661127db71b6467d546dab33
Author: Peter Collingbourne <pcc@chromium.org>
Date: Wed Nov 01 18:57:35 2017

update.py: Download Windows runtimes if target_os in .gclient has "win".

This makes it possible to cross-build for Windows with is_asan=true
(and soon, is_ubsan=true and use_cfi_diag=true).

Bug:  778760 
Change-Id: I6c49a690f11de299479bd17bb2e4588d1b55d9b1
Reviewed-on: https://chromium-review.googlesource.com/740570
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513200}
[modify] https://crrev.com/f062d235cf3b2e94661127db71b6467d546dab33/tools/clang/scripts/update.py

Comment 2 by p...@chromium.org, Nov 4 2017

Status: Verified (was: Assigned)
►

Sign in to add a comment