Package ubsan runtime libraries on Windows |
|||
Issue descriptionRight now it isn't possible to build with use_cfi_diag=true (or is_ubsan=true) on Windows because the package is missing the ubsan runtime library. We're going to need to start shipping these: -rw-r----- 1 pcc eng 193094 Oct 25 17:50 clang_rt.ubsan_standalone_cxx-i386.lib -rw-r----- 1 pcc eng 194794 Oct 25 17:50 clang_rt.ubsan_standalone_cxx-x86_64.lib -rw-r----- 1 pcc eng 3314452 Oct 25 17:51 clang_rt.ubsan_standalone-i386.lib -rw-r----- 1 pcc eng 3514886 Oct 25 17:51 clang_rt.ubsan_standalone-x86_64.lib If I create a tarball out of them, the size comes to about 2MB, which doesn't seem too bad. thakis: would you be fine with taking the 2MB hit on the Windows package size?
,
Oct 26 2017
If I search for ubsan in https://cs.chromium.org/chromium/src/tools/mb/mb_config.pyl I see a few Linux bots with ubsan enabled.
,
Oct 26 2017
Aren't they all hobby/fyi bots though?
,
Oct 26 2017
The lkgr bot looks important, and so does the clusterfuzz upload bot. (Arguably the latter shouldn't be on fyi, but still...) Also, "Linux CFI" on chromium.memory uses the ubsan runtime.
,
Oct 26 2017
Hm, ok. Are you planning on making ubsan/win a thing (main waterfall bots, e.g. on chromium.memory, etc)? If so, just including these seems fine to me.
,
Oct 26 2017
,
Oct 26 2017
My plan is to make use_cfi_diag=true work on Windows. In terms of bots there would eventually be a "Windows CFI" bot on chromium.memory that uses this runtime library.
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ee958f62bdf31696c3e491c4882eb4f01faf0be commit 1ee958f62bdf31696c3e491c4882eb4f01faf0be Author: Peter Collingbourne <pcc@chromium.org> Date: Wed Nov 01 23:25:49 2017 Ship ubsan runtime in clang Windows package. Bug: 778758 Change-Id: I73de59cfec8875fc8c77e1f69620a6497a9a806f Reviewed-on: https://chromium-review.googlesource.com/740666 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#513317} [modify] https://crrev.com/1ee958f62bdf31696c3e491c4882eb4f01faf0be/tools/clang/scripts/package.py [modify] https://crrev.com/1ee958f62bdf31696c3e491c4882eb4f01faf0be/tools/clang/scripts/update.py
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37fbd94e8cf8707d99c173412393a78a59d2f3da commit 37fbd94e8cf8707d99c173412393a78a59d2f3da Author: Peter Collingbourne <pcc@chromium.org> Date: Thu Nov 02 00:07:44 2017 Revert "Ship ubsan runtime in clang Windows package." This reverts commit 1ee958f62bdf31696c3e491c4882eb4f01faf0be. Reason for revert: Suspected culprit for https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/41291 Original change's description: > Ship ubsan runtime in clang Windows package. > > Bug: 778758 > Change-Id: I73de59cfec8875fc8c77e1f69620a6497a9a806f > Reviewed-on: https://chromium-review.googlesource.com/740666 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#513317} TBR=thakis@chromium.org,hans@chromium.org,pcc@chromium.org Change-Id: I1715a96c4a974e87889bead3e96d541b2b86fe60 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 778758 Reviewed-on: https://chromium-review.googlesource.com/749763 Reviewed-by: Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#513327} [modify] https://crrev.com/37fbd94e8cf8707d99c173412393a78a59d2f3da/tools/clang/scripts/package.py [modify] https://crrev.com/37fbd94e8cf8707d99c173412393a78a59d2f3da/tools/clang/scripts/update.py
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55bb0cdf5d568552e4ba84b73d7b38a363ddf84a commit 55bb0cdf5d568552e4ba84b73d7b38a363ddf84a Author: Peter Collingbourne <pcc@chromium.org> Date: Thu Nov 02 03:33:30 2017 Move a ctor out of line. This is necessary in order to silence a plugin warning in an upcoming release of clang. TBR=wangxianzhu@chromium.org,pdr@chromium.org Bug: 778758 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iea14a5855ee07eac3d34a7a92bf1503bb1cc289c Reviewed-on: https://chromium-review.googlesource.com/750268 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#513395} [modify] https://crrev.com/55bb0cdf5d568552e4ba84b73d7b38a363ddf84a/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed145d9b4b3043be7c812a2a42dc384dc56e9a12 commit ed145d9b4b3043be7c812a2a42dc384dc56e9a12 Author: Peter Collingbourne <pcc@chromium.org> Date: Thu Nov 02 07:35:09 2017 Reland "Ship ubsan runtime in clang Windows package." This is a reland of 1ee958f62bdf31696c3e491c4882eb4f01faf0be Fix for earlier build breakage has landed: https://chromium-review.googlesource.com/750268 Original change's description: > Ship ubsan runtime in clang Windows package. > > Bug: 778758 > Change-Id: I73de59cfec8875fc8c77e1f69620a6497a9a806f > Reviewed-on: https://chromium-review.googlesource.com/740666 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#513317} TBR=hans@chromium.org Bug: 778758 Change-Id: I6fc21131d51d2b87ddb26ac6540cbcfdeb16a146 Reviewed-on: https://chromium-review.googlesource.com/749856 Reviewed-by: Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#513421} [modify] https://crrev.com/ed145d9b4b3043be7c812a2a42dc384dc56e9a12/tools/clang/scripts/package.py [modify] https://crrev.com/ed145d9b4b3043be7c812a2a42dc384dc56e9a12/tools/clang/scripts/update.py
,
Feb 9 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Oct 26 2017