New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778742 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 780141



Sign in to add a comment

Flake analyses are running into a dead loop

Project Member Reported by st...@chromium.org, Oct 26 2017

Issue description

Comment 1 by st...@chromium.org, Oct 26 2017

Components: -Tools>Test>FindIt Tools>Test>FindIt>Flakiness

Comment 2 by st...@chromium.org, Nov 1 2017

Cc: -lijeffrey@chromium.org
Owner: lijeffrey@chromium.org
Status: Assigned (was: Available)
Assigned to Jeff, since the loop is in NextCommitPositionPipeline and RecursiveFlakeTryJobPipeline.

Comment 3 by st...@chromium.org, Nov 3 2017

Blocking: 780141

Comment 4 by st...@chromium.org, Nov 6 2017

This seems getting worse: https://screenshot.googleplex.com/NbHMW9bKXvv.png See the red one.

Comment 5 by wylieb@chromium.org, Nov 14 2017

Looks like that analysis was manually triggered on 8/11/2017.

https://pantheon.corp.google.com/datastore/entities/query/gql?project=findit-for-me&ns=&kind=_AE_Barrier_Index&gql=SELECT%20*%20from%20MasterFlakeAnalysis%20WHERE%20%0A%09test_name%20%3D%20%27BrowserCommandControllerInteractiveTest.ShortcutsShouldTakeEffectInJsFullscreen%27%20AND%0A%20%20%20%20step_name%20%3D%20%27interactive_ui_tests%27%20and%0A%20%20%20%20builder_name%20%3D%20%27Linux%20Tests%27

id=1 was the actual analysis
id-2 was the rerun

I don't think this analysis is actually doing anything. It's try-job status just didn't get updated for some reason. Not sure why, trying to look into the logs, but they appear to have been wiped.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/03c7c90a171630ce91ed1480128db6152b639c29

commit 03c7c90a171630ce91ed1480128db6152b639c29
Author: Brandon Wylie <wylieb@chromium.org>
Date: Fri Nov 17 01:03:18 2017

[Findit] Flake Analyzer - Allow cancellation if tryjob is still in progress

Currently it only works if the regression range is running. This
fix will let it work for both.

Bug:  778742 
Change-Id: I446fcb98fc610b103e32b66a541e7dc84b55b223
Reviewed-on: https://chromium-review.googlesource.com/768091
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>

[modify] https://crrev.com/03c7c90a171630ce91ed1480128db6152b639c29/appengine/findit/handlers/flake/check_flake.py

Status: Fix (was: Assigned)
Status: Fixed (was: Fix)

Sign in to add a comment