New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778740 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Ripple effects needed for touch targets in the views based lockscreen

Project Member Reported by xiaoyinh@chromium.org, Oct 26 2017

Issue description

The Sign in/ Lock screen in ChromeOS should uses "Non-hover flood fill ripples" for all touch targets.

Specs can be found here: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCFbZOQ_XAmG77Z0Npc-hC4JwMSJbxAVNpw
 
Cc: jdufault@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a93125b9266ccae55414178523cc529cedf11df7

commit a93125b9266ccae55414178523cc529cedf11df7
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Mon Oct 30 19:18:18 2017

Adding ripple effects for touch targets in the views-based lockscreen.

Create LoginButton class as a base class for touch targets to enable
ripple effects.
This CL adds ripple to the following touch targets:
1. Dropdown menu button.
2. Submit button.
3. Pin keyboard button.

Bug:  778740 
Change-Id: Ifd856da4ada342d94511fd2ead11933468fa8750
Reviewed-on: https://chromium-review.googlesource.com/739960
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512572}
[modify] https://crrev.com/a93125b9266ccae55414178523cc529cedf11df7/ash/BUILD.gn
[modify] https://crrev.com/a93125b9266ccae55414178523cc529cedf11df7/ash/login/ui/login_bubble.cc
[modify] https://crrev.com/a93125b9266ccae55414178523cc529cedf11df7/ash/login/ui/login_bubble.h
[modify] https://crrev.com/a93125b9266ccae55414178523cc529cedf11df7/ash/login/ui/login_bubble_unittest.cc
[add] https://crrev.com/a93125b9266ccae55414178523cc529cedf11df7/ash/login/ui/login_button.cc
[add] https://crrev.com/a93125b9266ccae55414178523cc529cedf11df7/ash/login/ui/login_button.h
[modify] https://crrev.com/a93125b9266ccae55414178523cc529cedf11df7/ash/login/ui/login_password_view.cc
[modify] https://crrev.com/a93125b9266ccae55414178523cc529cedf11df7/ash/login/ui/login_password_view.h
[modify] https://crrev.com/a93125b9266ccae55414178523cc529cedf11df7/ash/login/ui/login_pin_view.cc
[modify] https://crrev.com/a93125b9266ccae55414178523cc529cedf11df7/ash/login/ui/login_pin_view_unittest.cc
[modify] https://crrev.com/a93125b9266ccae55414178523cc529cedf11df7/ash/login/ui/login_user_view.cc
[modify] https://crrev.com/a93125b9266ccae55414178523cc529cedf11df7/ash/login/ui/login_user_view.h

Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment