JS Heap Profiler: Show key as the value retainer for weak maps. |
||
Issue description
Add a synthetic strong link from key to the corresponding value per WeakMap. That would help the user to track a value retainment path.
The link name could be something like `weak_map_${weak_map_id}_${index_in_array}`
Should we also do it for regular Maps? Not sure about that though.
,
Feb 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/e8925ad5096720435a24cced75da5143d846de8e commit e8925ad5096720435a24cced75da5143d846de8e Author: Ulan Degenbaev <ulan@chromium.org> Date: Mon Feb 26 11:35:45 2018 [heap-profiler] Show key as the value retainer for weak maps. The key -> value edge is shown as "<index> / WeakMap", where <index> is the index of the edge in the key. Bug: chromium:778739 , chromium:749502 Change-Id: I657051695f2a171372788dbb777543a55a35d554 Reviewed-on: https://chromium-review.googlesource.com/926524 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#51559} [modify] https://crrev.com/e8925ad5096720435a24cced75da5143d846de8e/src/profiler/heap-snapshot-generator.cc [modify] https://crrev.com/e8925ad5096720435a24cced75da5143d846de8e/test/cctest/test-heap-profiler.cc
,
Dec 10
|
||
►
Sign in to add a comment |
||
Comment 1 by alph@chromium.org
, Oct 26 2017