Issue metadata
Sign in to add a comment
|
fetch API layout tests are flaky on mojo_linux bot |
||||||||||||||||||||||||
Issue descriptionhttps://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/6586 http/tests/fetch/workers/stream-reader.html * http/tests/fetch/workers/thorough/access-control.html * http/tests/fetch/workers/thorough/auth-nocors-base-https-other-https.html * http/tests/fetch/workers/thorough/auth-other-https.html * http/tests/fetch/workers/thorough/cookie.html * http/tests/fetch/workers/thorough/cors-preflight-other-https.html * http/tests/fetch/workers/thorough/cors-preflight2-other-https.html * http/tests/fetch/workers/thorough/redirect-credentials-other-https.html * http/tests/fetch/workers/thorough/redirect-credentials.html * http/tests/fetch/workers/thorough/redirect-nocors-other-https.html * http/tests/fetch/workers/thorough/redirect-password-other-https.html * http/tests/fetch/workers/thorough/redirect-password.html * http/tests/fetch/workers/thorough/scheme-blob.html
,
Oct 26 2017
,
Oct 27 2017
,
Oct 27 2017
It's not clear to me if this is a regression or the tests were enabled recently. The first failures are around Oct 24. This is about fetch() from a worker thread. Could it have to do with off-main-thread-fetch when NetworkService is enabled? Note that many fetch/serviceworker tests are also failing around the same time: issue 778428 .
,
Oct 27 2017
Issue 778428 has been merged into this issue.
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f975f8b813b9995b8ee5a798401bc5398eea4a2 commit 2f975f8b813b9995b8ee5a798401bc5398eea4a2 Author: Matt Falkenhagen <falken@chromium.org> Date: Fri Oct 27 04:01:10 2017 Gardening: Update service worker NetworkService test expectations - force-refresh-ready.html and force-refresh-registration.html were fixed in r511495. - Since I duped the crbugs already, update the bug numbers so all http/tests/fetch share the same bug. Bug: 778220 , 778721 Change-Id: I77394a9f5d6181388a26a3a0851173320aff8e14 NOTRY: true TBR: kinuko Reviewed-on: https://chromium-review.googlesource.com/740924 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#512086} [modify] https://crrev.com/2f975f8b813b9995b8ee5a798401bc5398eea4a2/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef29075181cc0f0dd9619b7ae3dd5275e1455d2c commit ef29075181cc0f0dd9619b7ae3dd5275e1455d2c Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Oct 31 08:10:28 2017 [NetworkService] Attach "accept" header appropriately Share the logic with MimeSniffingResourceHandler. Bug: 778721 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I4a90beee86a5182b0a8d1c6225c4aaa711abed7d Reviewed-on: https://chromium-review.googlesource.com/745661 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#512776} [modify] https://crrev.com/ef29075181cc0f0dd9619b7ae3dd5275e1455d2c/content/browser/loader/mime_sniffing_resource_handler.cc [modify] https://crrev.com/ef29075181cc0f0dd9619b7ae3dd5275e1455d2c/content/common/loader_util.cc [modify] https://crrev.com/ef29075181cc0f0dd9619b7ae3dd5275e1455d2c/content/common/loader_util.h [modify] https://crrev.com/ef29075181cc0f0dd9619b7ae3dd5275e1455d2c/content/network/url_loader_impl.cc [modify] https://crrev.com/ef29075181cc0f0dd9619b7ae3dd5275e1455d2c/content/network/url_loader_unittest.cc [modify] https://crrev.com/ef29075181cc0f0dd9619b7ae3dd5275e1455d2c/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2883942de0ba902ff1928a91e889d0ce5dbe0a94 commit 2883942de0ba902ff1928a91e889d0ce5dbe0a94 Author: Matt Falkenhagen <falken@chromium.org> Date: Tue Oct 31 14:49:04 2017 Gardening: NetworkService: Add Pass expectations to flaky http/fetch tests. I didn't check all but a random sampling and recent trybot runs is showing these are flakily failing, not always failing. Add [ Pass ] expectation long with the failure expectations to prevent confusing "unexpected flakiness" redness. Bug: 778721 Change-Id: I045dc22542a89723444beb196bf08a4f3c44b612 TBR: kinuko NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/746543 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#512828} [modify] https://crrev.com/2883942de0ba902ff1928a91e889d0ce5dbe0a94/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Nov 1 2017
Regarding fetch/api/cors/cors-cookies.any.html, I found it failed when run after fetch/api/cors/cors-expose-star.html. This is observed only with NetworkService enabled.
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
Mar 1 2018
I found the failure reason for cors-cookies.any.html. It's because BlinkTestRunner::DeleteAllCookies doesn't work with the network service. I will fix it.
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1881fd7f8641508feb5166b7cae561d87723cfa8 commit 1881fd7f8641508feb5166b7cae561d87723cfa8 Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Mar 02 07:31:44 2018 Implment BlinkTestRunner::DeleteAllCookies for Network Service ... in order to fix test flakiness. Bug: 778721 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib28d4bf907ffef4547dd2e5995246462734a527d Reviewed-on: https://chromium-review.googlesource.com/945181 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#540469} [modify] https://crrev.com/1881fd7f8641508feb5166b7cae561d87723cfa8/content/shell/browser/DEPS [modify] https://crrev.com/1881fd7f8641508feb5166b7cae561d87723cfa8/content/shell/browser/layout_test/layout_test_content_browser_client.cc [modify] https://crrev.com/1881fd7f8641508feb5166b7cae561d87723cfa8/content/shell/browser/layout_test/layout_test_message_filter.cc [modify] https://crrev.com/1881fd7f8641508feb5166b7cae561d87723cfa8/content/shell/browser/layout_test/layout_test_message_filter.h [modify] https://crrev.com/1881fd7f8641508feb5166b7cae561d87723cfa8/content/shell/common/layout_test/layout_test_messages.h [modify] https://crrev.com/1881fd7f8641508feb5166b7cae561d87723cfa8/content/shell/renderer/layout_test/blink_test_runner.cc [modify] https://crrev.com/1881fd7f8641508feb5166b7cae561d87723cfa8/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/baea5228ab45167b3e32852a31d3b0a84a39ed67 commit baea5228ab45167b3e32852a31d3b0a84a39ed67 Author: Yutaka Hirano <yhirano@chromium.org> Date: Wed Mar 07 10:24:11 2018 http/tests/fetch/ layout tests pass with enable-features=NetworkService They are no longer failing / flaky. Bug: 778721 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5f68782329feae627b07f08d1dbf9a64b0f47f3c Reviewed-on: https://chromium-review.googlesource.com/952121 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#541401} [modify] https://crrev.com/baea5228ab45167b3e32852a31d3b0a84a39ed67/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b9b7a7fd07f4edad8b29d97417f6881b099cb85 commit 4b9b7a7fd07f4edad8b29d97417f6881b099cb85 Author: Yutaka Hirano <yhirano@chromium.org> Date: Wed Mar 07 14:35:15 2018 S13nServiceWorker: Fix fetch_request_context handling in navigation ResourceRequest::fetch_request_context was not set in NavigationURLLoaderNetworkService, which resulted in failure of wpt/fetch/api/request/destination/fetch-destination-iframe.https.html. Bug: 778721 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I595e1a877d3fc7c8dbbd720867fd344d3c88b2ac Reviewed-on: https://chromium-review.googlesource.com/951670 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#541427} [modify] https://crrev.com/4b9b7a7fd07f4edad8b29d97417f6881b099cb85/content/browser/loader/navigation_url_loader_network_service.cc [modify] https://crrev.com/4b9b7a7fd07f4edad8b29d97417f6881b099cb85/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Mar 7 2018
,
Jul 3
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 26 2017