New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 778713 link

Starred by 1 user
Status: Fixed
Owner:
█ thanhdle@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clear log in chrome://interventions-internals does not clear all logs.

Project Member Reported by thanhdle@chromium.org, Oct 26 2017 
On the Logs tab of chrome://interventions-internals, hitting the "Clear log" button does not clear out all the logs. The last row of the table is not removed.

This is because of setupLogClear method in https://cs.chromium.org/chromium/src/chrome/browser/resources/interventions_internals/index.js?l=99 should be iterating from rows.length, not rows.length - 1.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bfb97b480b9e2e035f6084c0faa05917d311585

commit 6bfb97b480b9e2e035f6084c0faa05917d311585
Author: Thanh Le <thanhdle@chromium.org>
Date: Thu Oct 26 19:55:31 2017

Fix clear log button behavior, and onBlacklistCleared not removing all table rows.

Added test to check the behavior of onBlacklistCleared.

Bug:  778713 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8f199df33434d38d7b5e82a5e0daa8dd8405fb75
Reviewed-on: https://chromium-review.googlesource.com/739947
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511931}
[modify] https://crrev.com/6bfb97b480b9e2e035f6084c0faa05917d311585/chrome/browser/resources/interventions_internals/index.html
[modify] https://crrev.com/6bfb97b480b9e2e035f6084c0faa05917d311585/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/6bfb97b480b9e2e035f6084c0faa05917d311585/chrome/test/data/webui/interventions_internals_browsertest.js

Comment 2 by thanhdle@chromium.org, Oct 26 2017

Status: Fixed (was: Started)

Comment 3 by thanhdle@chromium.org, Oct 26 2017

Status: Started (was: Fixed)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0826b365064839a2df8d8cdac02c785e04fabd6b

commit 0826b365064839a2df8d8cdac02c785e04fabd6b
Author: Thanh Le <thanhdle@chromium.org>
Date: Thu Oct 26 23:36:32 2017

Changed the implementation of onBlacklistCleared and setupLogClear so it is less confusing.

Bug:  778713 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2ba3ed0781b3e6846425bd044fa482d403e4aceb
Reviewed-on: https://chromium-review.googlesource.com/740371
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512013}
[modify] https://crrev.com/0826b365064839a2df8d8cdac02c785e04fabd6b/chrome/browser/resources/interventions_internals/index.js

Comment 5 by thanhdle@chromium.org, Oct 26 2017

Status: Fixed (was: Started)

Comment 6 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 7 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
►

Sign in to add a comment