New issue
Advanced search Search tips

Issue 778700 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK(!has_window_focus_ || !has_pointer_focus_); failure in browser tests

Project Member Reported by danakj@chromium.org, Oct 26 2017

Issue description

I was running browser tests in xvfb-run, with a bunch of parallel shards, and I got this:

[ RUN      ] PasswordManagerBrowserTestBase.PromptForSubmitWithInPageNavigation
Xlib:  extension "RANDR" missing on display ":99".
[28500:28500:1026/115251.717874:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[28500:28500:1026/115251.836566:FATAL:desktop_window_tree_host_x11.cc(807)] Check failed: !has_window_focus_ || !has_pointer_focus_. 
#0 0x7f4bcae067f7 base::debug::StackTrace::StackTrace()
#1 0x7f4bcae2e721 logging::LogMessage::~LogMessage()
#2 0x7f4bc8e2328d views::DesktopWindowTreeHostX11::IsActive()
#3 0x7f4bc8e1fc23 views::DesktopWindowTreeHostX11::AfterActivationStateChanged()
#4 0x7f4bc8e2719f views::DesktopWindowTreeHostX11::DispatchEvent()
#5 0x7f4bc8e2752d views::DesktopWindowTreeHostX11::DispatchEvent()
#6 0x7f4bc875aab6 ui::PlatformEventSource::DispatchEvent()
#7 0x7f4bbdcbb682 ui::X11EventSource::ExtractCookieDataDispatchEvent()
#8 0x7f4bbdcbb5ed ui::X11EventSource::DispatchXEvents()
#9 0x7f4bbdcbfad9 ui::(anonymous namespace)::XSourceDispatch()

 

Comment 1 by grt@chromium.org, Apr 25 2018

This same DCHECK caused a test to be disabled in issue 701023. What does it mean?
> What does it mean?

See the gtk focus tracking doc.
https://github.com/GNOME/gtk/blob/master/docs/focus_tracking.txt#L35

The doc says the definition of those vars is:
 has_focus_window(W): F==W || F==Descendant
 has_pointer_focus(W): (F==Ancestor || F==PointerRoot) && has_pointer(W)

The pointer can only be one of W,Descendant,Ancestor,PointerRoot at a time.  So has_window_focus_ and has_pointer_focus_ should be mutually exclusive, which is what the DCHECK is checking for.
Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked
***UI Mass Triage ***

Sign in to add a comment