New issue
Advanced search Search tips

Issue 778696 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html layout test is flaky

Project Member Reported by lukasza@chromium.org, Oct 26 2017

Issue description

REPRO:

DISPLAY=:20 third_party/WebKit/Tools/Scripts/run-webkit-tests -t gn --no-retry --additional-drt-flag=--site-per-process virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html

EXPECTED BEHAVIOR: test passes

ACTUAL BEHAVIOR: test fails saying:

    This test verifies that the first programmatic smooth scroll
    doesn't always run on the main thread (see  crbug.com/592799 ).

    On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

    PASS internals.getProgrammaticScrollAnimationState(document) is RUNNING_ON_COMPOSITOR
    FAIL document.scrollingElement.scrollTop == 500 failed to change to true in 0.5 seconds.
    PASS successfullyParsed is true

    TEST COMPLETE

NOTE: This test wasn't run on Site Isolation bots until recently (r510833).  It is possible that this test has always failed / that this is not a recent regression.
 
Cc: sunyunjia@chromium.org skobes@chromium.org dtapu...@chromium.org
I see that third_party/WebKit/LayoutTests/TestExpectations disables this test for Mac:

crbug.com/574283 [ Mac ] virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html [ Skip ]

This is probably unrelated, but just in case, let me CC people from issue 574283.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f45a952f5bf8639ccd68886547f2d60a5de27c7c

commit f45a952f5bf8639ccd68886547f2d60a5de27c7c
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Thu Oct 26 17:05:04 2017

Test exception for .../threaded/.../first-scroll-runs-on-compositor...

Bug:  778696 
No-Try: true
Change-Id: I9459651d78c33d475e2a03daaef1a13739507621
Reviewed-on: https://chromium-review.googlesource.com/739842
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511854}
[modify] https://crrev.com/f45a952f5bf8639ccd68886547f2d60a5de27c7c/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Comment 3 by bokan@chromium.org, Oct 26 2017

Cc: sahel@chromium.org bokan@chromium.org
Owner: mcnee@chromium.org
Status: Assigned (was: Untriaged)
Over to Kevin since this seems like an OOPIF issue. Kevin, could you take the initial look?

Comment 4 by mcnee@chromium.org, Oct 30 2017

I see this test fail locally without --site-per-process as well. This test looks flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=virtual%2Fthreaded%2Ffast%2Fscroll-behavior%2Ffirst-scroll-runs-on-compositor.html

I tried polling for the value of document.scrollingElement.scrollTop and in the cases where the test fails, the value was 524 instead of the expected 500. It's the same issue with and without --site-per-process.

Comment 5 by bokan@chromium.org, Oct 30 2017

Cc: -sunyunjia@chromium.org mcnee@chromium.org
Owner: sunyunjia@chromium.org
Ah, ok, thanks Kevin. In that case, over to sunyunjia who owns smooth scrolling.
Summary: virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html layout test is flaky (was: virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html layout test fails with --site-per-process)

Comment 8 by guidou@chromium.org, Nov 17 2017

Labels: -Sheriff-Chromium
Haven't seen this test fail in the last 200 runs of linux_chromium_rel_ng (from 589982  to 590192). 
I believe no more sheriff involvement is necessary, so removing Sheriff-Chromium label.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e638519a02830035b58a02dd23dc5bb86488d34

commit 8e638519a02830035b58a02dd23dc5bb86488d34
Author: Sandra Sun <sunyunjia@chromium.org>
Date: Fri Nov 17 15:37:49 2017

Disable first-scroll-runs-on-compositor.html

virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html
is flaky.

This patch temporarily disables the test, and a following test
will update the test and enable it back again.

Bug:  778696 
Change-Id: Id27ccb14e0deda20e46478a237ed07962ad7eb5d
Reviewed-on: https://chromium-review.googlesource.com/770599
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517401}
[modify] https://crrev.com/8e638519a02830035b58a02dd23dc5bb86488d34/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9f77bf3e3b255910d644c32fca71b960273865b

commit c9f77bf3e3b255910d644c32fca71b960273865b
Author: Sandra Sun <sunyunjia@chromium.org>
Date: Tue Nov 21 16:33:37 2017

Rewrite first-scroll-runs-on-compositor for more robustness.

Currently, first-scroll-runs-on-compositor.html uses ShouldBecomeEqual()
from js-test.js to check the final scroll destination. However, it
checks after 0.5secs, which may not be enough for all the platforms,
making the test flaky.

This patch rewrites the test using testharness.js and only checkes after
the page no longer scrolls or has reached the specified destination,
which would be independent from the platform's performance, making the
test robust.

Bug:  778696 
Change-Id: Icb91755a3eaecbb5a76023a303fcf9a27f713665
Reviewed-on: https://chromium-review.googlesource.com/777606
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518273}
[modify] https://crrev.com/c9f77bf3e3b255910d644c32fca71b960273865b/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
[modify] https://crrev.com/c9f77bf3e3b255910d644c32fca71b960273865b/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/c9f77bf3e3b255910d644c32fca71b960273865b/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/65ae4d02fdbe74f2e1bd708edd1beef53f9841b4/third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor-expected.txt
[modify] https://crrev.com/c9f77bf3e3b255910d644c32fca71b960273865b/third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html

Sign in to add a comment