New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778695 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Allow payment manifests on http://localhost.

Project Member Reported by rouslan@chromium.org, Oct 26 2017

Issue description

It's too difficult and slow for web developers to maintain an HTTPS server with a valid certificate when first creating a payment method. We should allow HTTP on localhost for payment manifests.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dacc2cdd7c2f6ba8a309bb122c12fd234df97e3

commit 8dacc2cdd7c2f6ba8a309bb122c12fd234df97e3
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Fri Oct 27 18:33:22 2017

[Payments] Allow payment manifests on http://localhost.

Before this patch, creating a payment method manifest required an HTTPS
server.

This patch allows HTTP scheme on localhost to be used for serving
payment manifests.

After this patch, a web developer can create a payment method manifest
on http://localhost, http://127.0.0.1, and http://[::1].

(In addition, this patch removes redundant checks in
payment_manifest_parser and reorganizes payment_manifest_parser.cc
methods to be in the same order as payment_manifest_parser.h.)

Bug:  778695 
Change-Id: Ia7abd88ed78664ac2a20bf6a4f9078d93bddbce6
Reviewed-on: https://chromium-review.googlesource.com/739755
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512250}
[modify] https://crrev.com/8dacc2cdd7c2f6ba8a309bb122c12fd234df97e3/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java
[modify] https://crrev.com/8dacc2cdd7c2f6ba8a309bb122c12fd234df97e3/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentManifestVerifier.java
[modify] https://crrev.com/8dacc2cdd7c2f6ba8a309bb122c12fd234df97e3/chrome/android/java/src/org/chromium/chrome/browser/payments/UriUtils.java
[modify] https://crrev.com/8dacc2cdd7c2f6ba8a309bb122c12fd234df97e3/chrome/android/javatests/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinderTest.java
[modify] https://crrev.com/8dacc2cdd7c2f6ba8a309bb122c12fd234df97e3/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentManifestDownloaderTest.java
[modify] https://crrev.com/8dacc2cdd7c2f6ba8a309bb122c12fd234df97e3/components/payments/content/android/java/src/org/chromium/components/payments/PaymentManifestDownloader.java
[modify] https://crrev.com/8dacc2cdd7c2f6ba8a309bb122c12fd234df97e3/components/payments/content/android/payment_manifest_downloader_android.cc
[modify] https://crrev.com/8dacc2cdd7c2f6ba8a309bb122c12fd234df97e3/components/payments/content/android/payment_manifest_downloader_android.h
[modify] https://crrev.com/8dacc2cdd7c2f6ba8a309bb122c12fd234df97e3/components/payments/content/utility/BUILD.gn
[modify] https://crrev.com/8dacc2cdd7c2f6ba8a309bb122c12fd234df97e3/components/payments/content/utility/payment_manifest_parser.cc
[modify] https://crrev.com/8dacc2cdd7c2f6ba8a309bb122c12fd234df97e3/components/payments/content/utility/payment_manifest_parser_unittest.cc
[modify] https://crrev.com/8dacc2cdd7c2f6ba8a309bb122c12fd234df97e3/components/payments/core/payment_manifest_downloader.cc
[modify] https://crrev.com/8dacc2cdd7c2f6ba8a309bb122c12fd234df97e3/components/payments/core/payment_manifest_downloader.h

Status: Fixed (was: Assigned)

Sign in to add a comment