New issue
Advanced search Search tips

Issue 778684 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

asan-clang-phone failed compilation once because of missing FetchRequestMode

Project Member Reported by gsennton@chromium.org, Oct 26 2017

Issue description

Failing build:
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/asan-clang-phone/builds/3438

In file included from ../../third_party/WebKit/Source/platform/blob/BlobBytesProvider.cpp:12:
In file included from ../../third_party/WebKit/public/platform/Platform.h:57:
In file included from ../../third_party/WebKit/public/platform/WebURLLoader.h:35:
../../third_party/WebKit/public/platform/WebURLRequest.h:303:25: error: no type named 'FetchRequestMode' in namespace 'network::mojom'; did you mean 'FetchRedirectMode'?
  BLINK_PLATFORM_EXPORT network::mojom::FetchRequestMode GetFetchRequestMode()
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                        FetchRedirectMode
../../third_party/WebKit/public/platform/WebURLRequest.h:128:8: note: 'FetchRedirectMode' declared here
  enum FetchRedirectMode : uint8_t {
       ^
../../third_party/WebKit/public/platform/WebURLRequest.h:306:7: error: no type named 'FetchRequestMode' in namespace 'network::mojom'; did you mean 'FetchRedirectMode'?
      network::mojom::FetchRequestMode);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      FetchRedirectMode
../../third_party/WebKit/public/platform/WebURLRequest.h:128:8: note: 'FetchRedirectMode' declared here
  enum FetchRedirectMode : uint8_t {
       ^
2 errors generated.




Culprit CL:
https://chromium.googlesource.com/chromium/src/+/c9c7f444fee17900bee29100d4f279cb2e802a7b


This did not fail in the next build (3439) so I guess it's not super urgent.
My guess is that we're missing some dependency - i.e. that we're including WebURLRequest.h without having generated the file containing FetchRedirectMode, but then blink_headers does have a dependency on //services/network/public/interfaces:interfaces ...

toyoshim@ any thoughts?
 
Owner: toyoshim@chromium.org
Status: Started (was: Available)
Sorry for inconvenience. Is this build flakiness right?
Probably my change causes missing deps in BUILD.gn.
Let me investigate.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d250fb0ad412bef08e31453ea2fe188b13f8c4be

commit d250fb0ad412bef08e31453ea2fe188b13f8c4be
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Fri Oct 27 08:47:41 2017

Missing deps from platform/blob to public:blink_headers

This caused build flakiness due to missing indirect dependency
to //services/network/public/interfaces that updates required
headers.

Bug:  778684 
Change-Id: I525fb68900e53e5b7c5eb99ab36bb8e6fcbc9521
Reviewed-on: https://chromium-review.googlesource.com/741302
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512129}
[modify] https://crrev.com/d250fb0ad412bef08e31453ea2fe188b13f8c4be/third_party/WebKit/Source/platform/blob/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment