New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 778630 link

Starred by 1 user
Status: Fixed
Owner:
einbinder@chromium.org
Closed: Oct 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted line is seen after clicking on Drop down icon of Console section.

Reported by db...@etouch.net, Oct 26 2017 
Chrome Version: 62.0.3202.75 (32/64-bit)67b212ffb03c4401235f8961e2d15371b96cde27-refs/branch-heads/3202@{#750}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.6)

Pre-condition: Change dev tools Theme to 'Dark' in dev tools from Settings.
 
What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://inspect/#devices
(2) Click on 'Open dedicated DevTools for Node'(devtools window opened), navigate to 'Console' section.
(3) Click on Drop down icon and observe.

Actual: Unwanted line is seen after clicking on Drop down icon of Console section.

Expected: No such a line should seen.

This is regression issue, broken in 'M-60', below is bisect info:

Good Build: 60.0.3096.0
Bad Build: 60.0.3099.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/7bb2e7bc7d31c75b0b7f7b384add49df00d69259..99308ead46a0a196f4b8ba3efbb82b7a16d8d630?pretty=fuller&n=100

Suspect: r471208

Note: Unable to provide bisect using bisect per revision, hence proving bisect using old script.
Actual_Video.mov
2.9 MB Download
Expected_Video.mov
2.3 MB Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2abf4ceed0bd8f362152dd59179a5a1f6686c260

commit 2abf4ceed0bd8f362152dd59179a5a1f6686c260
Author: Joel Einbinder <einbinder@chromium.org>
Date: Thu Oct 26 23:42:11 2017

DevTools: Disable console context selector when it is empty

The context selector can be empty when DevTools is waiting for a node
instance to connect to. Clicking the selector when it is empty would
cause a wierd state with an empty glass pane.

Bug:  778630 
Change-Id: Ic2a63449c0be4c897a48ff9349ff774c1ea5fe4b
Reviewed-on: https://chromium-review.googlesource.com/740295
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512016}
[modify] https://crrev.com/2abf4ceed0bd8f362152dd59179a5a1f6686c260/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js
[modify] https://crrev.com/2abf4ceed0bd8f362152dd59179a5a1f6686c260/third_party/WebKit/Source/devtools/front_end/ui/SoftDropDown.js

Comment 2 by einbinder@chromium.org, Oct 26 2017

Status: Fixed (was: Assigned)

Comment 3 by db...@etouch.net, Oct 27 2017

Labels: TE-Verified-M64 TE-Verified-64.0.3251.0
Retested above issue on Windows(7,8,10), Mac(10.12.6) & Linux (14.04 LTS) OS using latest Dev #64.0.3251.0 build and issue seems fixed. Kindly review an attached screen-cast.

Thank you!
Expected.mov
1.9 MB Download
►

Sign in to add a comment