New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778627 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Jumbo can create include paths that hit Windows path limitations

Project Member Reported by brat...@opera.com, Oct 26 2017

Issue description

Today jumbo creates files in the out/Default/gen folder, sometimes deep in it, with statements such as:

#include "../../../../../../../third_party/WebKit/Source/something/mojo/maybe/more_something_genetaretedgen_blink.cpp" 

With everything else added to that path, it can become a 260+ character path which breaks some Windows APIs resulting in confusing errors about "file not found". This happens to some but not everyone on today's master depending on your exact directory structure and build folder.

Suggested fix (by yngve@vivaldi) is to use root_path relative includes. I've been considering that already for other reasons so I think that is what I will do.

The one downside is that it requires changing the include_dirs field just to be sure that root path is the include path.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41a6bdf875710b9f02d7fd8fc1346b00a62b5a18

commit 41a6bdf875710b9f02d7fd8fc1346b00a62b5a18
Author: Daniel Bratell <bratell@opera.com>
Date: Thu Oct 26 19:28:07 2017

Let jumbo use root_build_dir relative paths

Up until now include paths have been relative to the location
of the generated jumbo files. That can make paths rather long 
with many "../../.." in them.

In some circumstances, the paths are now too long for some
Win32 APIs (260 chars) so let us try with 
root_build_dir relative paths instead.

Bug:  778627 
Change-Id: Ic7202789f75caf5134b38b174cb5b24a217d0035
Reviewed-on: https://chromium-review.googlesource.com/737836
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511920}
[modify] https://crrev.com/41a6bdf875710b9f02d7fd8fc1346b00a62b5a18/build/config/jumbo.gni

Comment 2 by brat...@opera.com, Oct 27 2017

Status: Fixed (was: Started)
We'll go with that. Please let me know if you see any similar problems.

Sign in to add a comment