New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 778585 link

Starred by 1 user
Status: Fixed
Owner:
█ eostroukhov@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
nyerramilli@chromium.org
█ hu...@opera.com
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression :Text selection is seen only on page refresh.

Reported by pranjali...@etouch.net, Oct 26 2017 
Chrome Version:62.0.3202.75 (Official Build) 67b212ffb03c4401235f8961e2d15371b96cde27-refs/branch-heads/3202@{#750}(32/64 bit)

OS:Windows (7,8,10),Linux (14.04 LTS),Mac(10.12.6,10.13.1).

Steps to reproduce:
1)Launch chrome , go to NTP and open devtools.
2)click on 'Customize and control devtools' icon and select settings option.
3)Now press 'Ctrl + A' ,refresh page and observe.   

Actual Result:Text selection is seen only on page refresh.
Expected Result:Text should be selected on pressing 'ctrl+A'.

This is Regression issue broken in 'M-62' and below is the bisect results:  
Good Build:62.0.3166.0
Bad Build:62.0.3167.0 

You are probably looking for a change made after 489362 (known good), but no later than 489363 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/17684e9d8dd252a678cc17989303eaf027cbb61a..7a66627f0f0a681fcf3111a9bb0f01a8e0790186

Suspect:https://chromium.googlesource.com/chromium/src/+/7a66627f0f0a681fcf3111a9bb0f01a8e0790186

@yosin: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Actual_result.mp4
982 KB View Download
Expected_result.mp4
960 KB View Download

Comment 1 by yosin@chromium.org, Oct 27 2017

Owner: ----
Status: Untriaged (was: Assigned)
It seems M64 Canary selects nothing on Settings page when hit Ctrl+A,
I guess the page has user-select:none.

I think this is good for users because settings page is a kind of dialog box.

In other words, Ctrl+A and mouse drag to select should not work in Settings
page.

Comment 2 by eostroukhov@chromium.org, Oct 30 2017

Owner: eostroukhov@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30eafbafaff330ec9c25b657c45c4b4766e87a7c

commit 30eafbafaff330ec9c25b657c45c4b4766e87a7c
Author: Eugene Ostroukhov <eostroukhov@chromium.org>
Date: Thu Dec 14 18:17:47 2017

DevTools: Cleanup "help-" prefix

Removes "help-" prefix from the classnames as none of those styles are
used on an actual help screens. Also, disables Ctrl+A on settings
screens.

Bug:  778585 
Change-Id: I28bcd05122c1e06952db4597db2038d73f15e089
Reviewed-on: https://chromium-review.googlesource.com/822924
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524114}
[modify] https://crrev.com/30eafbafaff330ec9c25b657c45c4b4766e87a7c/third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js
[modify] https://crrev.com/30eafbafaff330ec9c25b657c45c4b4766e87a7c/third_party/WebKit/Source/devtools/front_end/emulation/devicesSettingsTab.css
[modify] https://crrev.com/30eafbafaff330ec9c25b657c45c4b4766e87a7c/third_party/WebKit/Source/devtools/front_end/persistence/WorkspaceSettingsTab.js
[modify] https://crrev.com/30eafbafaff330ec9c25b657c45c4b4766e87a7c/third_party/WebKit/Source/devtools/front_end/persistence/workspaceSettingsTab.css
[modify] https://crrev.com/30eafbafaff330ec9c25b657c45c4b4766e87a7c/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
[modify] https://crrev.com/30eafbafaff330ec9c25b657c45c4b4766e87a7c/third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css
[modify] https://crrev.com/30eafbafaff330ec9c25b657c45c4b4766e87a7c/third_party/WebKit/Source/devtools/front_end/ui/ShortcutsScreen.js

Comment 4 by eostroukhov@chromium.org, Dec 14 2017

Status: Fixed (was: Assigned)

Comment 5 by pranjali...@etouch.net, Dec 15 2017

Labels: TE-Verified-M65 TE-Verified-65.0.3295.0
Rechecked the above issue on Windows (7,8,10),Linux (14.04 LTS),Mac(10.12.6) OS with latest canary chrome version :65.0.3295.0 and the fix is working as intended.
Kindly refer the attached screen cast for reference.
Actual_result.mov
3.1 MB Download
►

Sign in to add a comment