Merge to M63: Enable CPU adaptation for screenshare in experiment |
|||||||
Issue descriptionThis is a trivial fix for a bug, which blocks rollout of important experiment. Original WebRTC bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=8433 Landed in chrome here: https://chromium.googlesource.com/chromium/src/+/d6800dad034f164a10ba94e18bd24fb524b01cec which made it to 64.0.3250.0 Change doesn't affect users without the experiment, and users under experiment without the change may have bad screensharing experience.
,
Oct 26 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 26 2017
How is the change looking in Canary? If the change looks good in Canary, I will approve the merge.
,
Oct 26 2017
It works, looks good. Also, you can't even see any changes without specific field trials enabled.
,
Oct 26 2017
Approving merge to M63 branch 3239 based on comment #0 & #4. Please merge ASAP. Thank you.
,
Oct 27 2017
,
Oct 27 2017
could you please provide link for M63 merge cl?
,
Oct 27 2017
Thank you.
,
Oct 27 2017
No, thank you for approval. Sorry, I forgot to add it in the first place.
,
Nov 21 2017
,
Nov 21 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rbyers@chromium.org
, Oct 26 2017