New issue
Advanced search Search tips

Issue 778580 link

Starred by 0 users
Status: Fixed
Owner:
yukishiino@chromium.org
Closed: Jun 2018
Cc:
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 761755



Sign in to add a comment

Renovate callback interface.

Project Member Reported by yukishiino@chromium.org, Oct 26 2017 
Let's resolve the following issues around callback interface and make it conformant to the spec.  We need renovation of callback interface.

a) The current implementation of callback interface is close to "callback function" rather than "callback interface".
b) EventListener must be a callback interface (DOM spec), but Blink implements EventListener something special independent from callback interface.
c) The current implementation of callback interface does not support wrapper-tracing.
d) There is no way to handle the return value of callback interfaces.  Blink is always discarding the return value.
e) There is no way to specify "callback this value".
f) The realm of a callback interface must be the realm of the callback interface type value.  Blink is currently using the current realm.
g) There is no support for the incumbent realm.

Comment 1 by yukishiino@chromium.org, Oct 26 2017

Blocking: 761755
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b17ef33e43e9897cb897dc147094ec004f994f75

commit b17ef33e43e9897cb897dc147094ec004f994f75
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Wed Nov 08 15:31:44 2017

v8binding: Refactors callback interface.

Does refactoring of callback interface in order to make it easy
to make things more conformant to the spec.
* Introduces the common base class of callback interfaces:
  CallbackInterfaceBase class.

This patch includes the following behavioral change.
* The realm of callback interface changes from the current realm
  to the realm of the function object.
This behavioral change was made just because I'd like to
refactor the constructor arguments of callback interface in this
patch rather than in the next one. As you see no change under
LayoutTests/, no one cares about the difference of the realm.

This patch was split from https://crrev.com/c/732872 .

Bug:  778580 
Change-Id: I88bc4442117427e435bef9ccf572c7cb22b1be1c
Reviewed-on: https://chromium-review.googlesource.com/737616
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514836}
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/core/v8/GeneratedCodeHelper.cpp
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/core/v8/GeneratedCodeHelper.h
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/scripts/v8_types.py
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/tests/results/core/V8TestLegacyCallbackInterface.cpp
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/tests/results/core/V8TestLegacyCallbackInterface.h
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/tests/results/core/boolean_or_test_callback_interface.cc
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/tests/results/core/boolean_or_test_callback_interface.h
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/tests/results/core/unsigned_long_long_or_boolean_or_test_callback_interface.cc
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/bindings/tests/results/core/unsigned_long_long_or_boolean_or_test_callback_interface.h
[modify] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/platform/bindings/CallbackInterfaceBase.cpp
[add] https://crrev.com/b17ef33e43e9897cb897dc147094ec004f994f75/third_party/WebKit/Source/platform/bindings/CallbackInterfaceBase.h
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb2f0e511b626db083b8ff576fa720d809a0828a

commit fb2f0e511b626db083b8ff576fa720d809a0828a
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Fri Nov 10 15:21:37 2017

v8binding: Fixes optional vs nullable at callback interface/function.

For callback interface and callback function, this patch fixes
misunderstanding/misuse of info[index] (which supports out-of-range
indexing) and difference between 'optional' and 'nullable'.

You do not need to pass in any argument if it's 'optional', however,
it's mandatory to pass in an argument if it's just 'nullable'.
The number of arguments must be checked in case of 'nullable'.

Bug:  778580 ,  779036 
Change-Id: I9eeb24ac51ac5c03695cad75b36d3edf734452c2
Reviewed-on: https://chromium-review.googlesource.com/763167
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515556}
[modify] https://crrev.com/fb2f0e511b626db083b8ff576fa720d809a0828a/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl
[modify] https://crrev.com/fb2f0e511b626db083b8ff576fa720d809a0828a/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp
[modify] https://crrev.com/fb2f0e511b626db083b8ff576fa720d809a0828a/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp
[modify] https://crrev.com/fb2f0e511b626db083b8ff576fa720d809a0828a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/fb2f0e511b626db083b8ff576fa720d809a0828a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp
[modify] https://crrev.com/fb2f0e511b626db083b8ff576fa720d809a0828a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
[modify] https://crrev.com/fb2f0e511b626db083b8ff576fa720d809a0828a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/fb2f0e511b626db083b8ff576fa720d809a0828a/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp
[modify] https://crrev.com/fb2f0e511b626db083b8ff576fa720d809a0828a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51d3838427080c114bf364e7db380ad169e03a1d

commit 51d3838427080c114bf364e7db380ad169e03a1d
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Fri Nov 10 15:24:03 2017

v8binding: Style fix of CallbackInterfaceBase.

Fixes very minor style issues of CallbackInterfaceBase.  This is a
leftover of https://crrev.com/c/737616 .

Bug:  778580 
Change-Id: I3e2d30684928e4af99c64c0851be31550ae655ab
Reviewed-on: https://chromium-review.googlesource.com/762932
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515557}
[modify] https://crrev.com/51d3838427080c114bf364e7db380ad169e03a1d/third_party/WebKit/Source/platform/bindings/CallbackInterfaceBase.cpp
[modify] https://crrev.com/51d3838427080c114bf364e7db380ad169e03a1d/third_party/WebKit/Source/platform/bindings/CallbackInterfaceBase.h
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82971f291b90fd5ec3e12c8ef154270310a75353

commit 82971f291b90fd5ec3e12c8ef154270310a75353
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Tue Nov 14 12:45:47 2017

v8binding: Renovates "call a user object's operation" of callback interface.

This patch implements "call a user object's operation" steps of Web IDL
from scratch discarding the existing implementation.  The steps include
(roughly speaking) a step to push a backup incumbent.

Web IDL 3.9. User objects implementing callback interfaces
https://heycam.github.io/webidl/#call-a-user-objects-operation

Bug:  778580 
Change-Id: Ib2929f866884095d01e46ae9f4483db2726bccd5
Reviewed-on: https://chromium-review.googlesource.com/763191
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516280}
[modify] https://crrev.com/82971f291b90fd5ec3e12c8ef154270310a75353/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
[modify] https://crrev.com/82971f291b90fd5ec3e12c8ef154270310a75353/third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl
[modify] https://crrev.com/82971f291b90fd5ec3e12c8ef154270310a75353/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp
[modify] https://crrev.com/82971f291b90fd5ec3e12c8ef154270310a75353/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h
[modify] https://crrev.com/82971f291b90fd5ec3e12c8ef154270310a75353/third_party/WebKit/Source/platform/bindings/CallbackInterfaceBase.cpp
[modify] https://crrev.com/82971f291b90fd5ec3e12c8ef154270310a75353/third_party/WebKit/Source/platform/bindings/CallbackInterfaceBase.h
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f576902c99845b21880a1681dd76acd61ddde9fa

commit f576902c99845b21880a1681dd76acd61ddde9fa
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Thu Nov 16 15:29:26 2017

Add support of Maybe<void> as a template specialization.

Blink wants to use Maybe<T> as a return type of (author) callback
functions, where T can be type void.  So, this patch adds support
of Maybe<void>.

Bug:  chromium:778580 ,  chromium:779036 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Id654bafc5ceac8ef6f755902418f250c353a8837
Reviewed-on: https://chromium-review.googlesource.com/771730
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49416}
[modify] https://crrev.com/f576902c99845b21880a1681dd76acd61ddde9fa/include/v8.h
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ca2b4cc0655a08e5ab19af21897c794ab84bcf5

commit 4ca2b4cc0655a08e5ab19af21897c794ab84bcf5
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Tue Nov 21 11:28:31 2017

v8binding: Defines FileCallback and uses it instead of BlobCallback.

FileCallback and BlobCallback are different things.  Blink shouldn't
abuse BlobCallback as a substitute of FileCallback.  This patch
defines FileCallback and makes Filesystem APIs use FileCallback.

FileCallback is defined as a callback interface.
https://dev.w3.org/2009/dap/file-system/file-dir-sys.html#the-filecallback-interface

BlobCallback is defined as a callback function.
https://html.spec.whatwg.org/multipage/canvas.html#the-canvas-element

Bug:  778580 
Change-Id: Id9a9d2f655b7b22b49564b8701c9e2c27eaca169
Reviewed-on: https://chromium-review.googlesource.com/781304
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518214}
[modify] https://crrev.com/4ca2b4cc0655a08e5ab19af21897c794ab84bcf5/third_party/WebKit/Source/modules/filesystem/BUILD.gn
[modify] https://crrev.com/4ca2b4cc0655a08e5ab19af21897c794ab84bcf5/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/4ca2b4cc0655a08e5ab19af21897c794ab84bcf5/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
[modify] https://crrev.com/4ca2b4cc0655a08e5ab19af21897c794ab84bcf5/third_party/WebKit/Source/modules/filesystem/ErrorCallback.idl
[add] https://crrev.com/4ca2b4cc0655a08e5ab19af21897c794ab84bcf5/third_party/WebKit/Source/modules/filesystem/FileCallback.h
[add] https://crrev.com/4ca2b4cc0655a08e5ab19af21897c794ab84bcf5/third_party/WebKit/Source/modules/filesystem/FileCallback.idl
[modify] https://crrev.com/4ca2b4cc0655a08e5ab19af21897c794ab84bcf5/third_party/WebKit/Source/modules/filesystem/FileEntry.cpp
[modify] https://crrev.com/4ca2b4cc0655a08e5ab19af21897c794ab84bcf5/third_party/WebKit/Source/modules/filesystem/FileEntry.h
[modify] https://crrev.com/4ca2b4cc0655a08e5ab19af21897c794ab84bcf5/third_party/WebKit/Source/modules/filesystem/FileEntry.idl
[modify] https://crrev.com/4ca2b4cc0655a08e5ab19af21897c794ab84bcf5/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/4ca2b4cc0655a08e5ab19af21897c794ab84bcf5/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h
[modify] https://crrev.com/4ca2b4cc0655a08e5ab19af21897c794ab84bcf5/third_party/WebKit/Source/modules/modules_idl_files.gni
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9adbc6a364984120ff28f032708f92d1e4105173

commit 9adbc6a364984120ff28f032708f92d1e4105173
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Fri Nov 24 10:10:11 2017

filesystem-api: Updates the spec links.

Updates the spec links of FileCallback and ErrorCallback of
Filesystem APIs.

Bug:  778580 
Change-Id: Iebc89fada76aba47c241d4a6ad001ebe91e53c15
Reviewed-on: https://chromium-review.googlesource.com/788719
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519077}
[modify] https://crrev.com/9adbc6a364984120ff28f032708f92d1e4105173/third_party/WebKit/Source/modules/filesystem/ErrorCallback.idl
[modify] https://crrev.com/9adbc6a364984120ff28f032708f92d1e4105173/third_party/WebKit/Source/modules/filesystem/FileCallback.idl
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54343025dc7dc8c5992990399b51219edea9c828

commit 54343025dc7dc8c5992990399b51219edea9c828
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Wed Dec 27 05:58:59 2017

v8binding: Uses filesystem's V8ErrorCallback instead of ErrorCallback.

This patch removes use of filesystem's ErrorCallback as a preparation
to let callback interfaces have the same structure as callback functions.

Callback functions:
- V8FooCallback (auto-generated) does not inherit from
  FooCallback (hand-written).
- V8FooCallback is 'final' class.  No sub class.

These two points are pretty important to keep "generated bindings code"
loose-coupled with any other code.  It makes easy to change/fix/update
the generated bindings code.  (Actually we have trouble to support
wrapper-tracing, v8::Maybe-return-type, callback-this-value for callback
interfaces.)

We'd like callback interfaces to have the same characteristics above,
and we're planning to let callback interfaces stop inheriting hand-
written base classes.

As a preparation, this patch removes use of ErrorCallback (hand-written)
as much as possible.

Bug:  778580 
Change-Id: I4ded3c3fde58a9263cc00a8c98e4853d0aae2919
Reviewed-on: https://chromium-review.googlesource.com/844307
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526210}
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/DOMWindowFileSystem.cpp
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/DOMWindowFileSystem.h
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/DirectoryEntry.cpp
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/DirectoryEntry.h
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/DirectoryReader.h
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.cpp
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/Entry.cpp
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/Entry.h
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/FileEntry.cpp
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/FileEntry.h
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/WorkerGlobalScopeFileSystem.cpp
[modify] https://crrev.com/54343025dc7dc8c5992990399b51219edea9c828/third_party/WebKit/Source/modules/filesystem/WorkerGlobalScopeFileSystem.h
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e7c9aa7f491f6a13cf419345db762c0d694cdd1

commit 4e7c9aa7f491f6a13cf419345db762c0d694cdd1
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Wed Dec 27 11:27:30 2017

v8binding: Uses filesystem's V8EntriesCallback instead of EntriesCallback.

This patch removes use of filesystem's EntriesCallback.  The motivation
is the same as https://crrev.com/844307 .

Bug:  778580 
Change-Id: I14a0d0c2f3d38f33ea8e66f333c8d2cca3b52f71
Reviewed-on: https://chromium-review.googlesource.com/844450
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526214}
[modify] https://crrev.com/4e7c9aa7f491f6a13cf419345db762c0d694cdd1/third_party/WebKit/Source/modules/filesystem/BUILD.gn
[modify] https://crrev.com/4e7c9aa7f491f6a13cf419345db762c0d694cdd1/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
[modify] https://crrev.com/4e7c9aa7f491f6a13cf419345db762c0d694cdd1/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp
[modify] https://crrev.com/4e7c9aa7f491f6a13cf419345db762c0d694cdd1/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.h
[modify] https://crrev.com/4e7c9aa7f491f6a13cf419345db762c0d694cdd1/third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp
[modify] https://crrev.com/4e7c9aa7f491f6a13cf419345db762c0d694cdd1/third_party/WebKit/Source/modules/filesystem/DirectoryReader.h
[modify] https://crrev.com/4e7c9aa7f491f6a13cf419345db762c0d694cdd1/third_party/WebKit/Source/modules/filesystem/DirectoryReaderBase.h
[modify] https://crrev.com/4e7c9aa7f491f6a13cf419345db762c0d694cdd1/third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.cpp
[modify] https://crrev.com/4e7c9aa7f491f6a13cf419345db762c0d694cdd1/third_party/WebKit/Source/modules/filesystem/EntriesCallback.h
[add] https://crrev.com/4e7c9aa7f491f6a13cf419345db762c0d694cdd1/third_party/WebKit/Source/modules/filesystem/EntryHeapVector.h
[modify] https://crrev.com/4e7c9aa7f491f6a13cf419345db762c0d694cdd1/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/4e7c9aa7f491f6a13cf419345db762c0d694cdd1/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h
[modify] https://crrev.com/4e7c9aa7f491f6a13cf419345db762c0d694cdd1/third_party/WebKit/Source/modules/filesystem/HTMLInputElementFileSystem.h
[modify] https://crrev.com/4e7c9aa7f491f6a13cf419345db762c0d694cdd1/third_party/WebKit/Source/modules/filesystem/SyncCallbackHelper.h
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15d8f913d19bde48cea7c87a0a5f0e00d617e330

commit 15d8f913d19bde48cea7c87a0a5f0e00d617e330
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Fri Jan 12 17:07:10 2018

v8binding: Uses filesystem's V8EntryCallback instead of EntryCallback.

This patch removes use of filesystem's EntryCallback.  The motivation
is the same as https://crrev.com/844307 .

Bug:  778580 
Change-Id: If0f7e6d6ea795e286e98091d75f450a9943fb2a2
Reviewed-on: https://chromium-review.googlesource.com/845660
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528975}
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.h
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/modules/filesystem/DOMWindowFileSystem.cpp
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/modules/filesystem/DOMWindowFileSystem.h
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/modules/filesystem/DirectoryEntry.cpp
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/modules/filesystem/DirectoryEntry.h
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/modules/filesystem/DirectoryEntrySync.cpp
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/modules/filesystem/Entry.cpp
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/modules/filesystem/Entry.h
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/modules/filesystem/EntrySync.cpp
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/modules/filesystem/SyncCallbackHelper.h
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/modules/filesystem/WorkerGlobalScopeFileSystem.cpp
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/modules/filesystem/WorkerGlobalScopeFileSystem.h
[modify] https://crrev.com/15d8f913d19bde48cea7c87a0a5f0e00d617e330/third_party/WebKit/Source/platform/heap/Persistent.h
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/744085364bb2a7f6f6a6efdea7924a7c7529c4ce

commit 744085364bb2a7f6f6a6efdea7924a7c7529c4ce
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Mon Jan 15 14:05:45 2018

v8binding: Fixes nullable EntryCallback of filesystem.

I misunderstood that there is no case of EntryCallback being
nullable, however, actually there are a lot of cases where
EntryCallback is optional.  So, https://crrev.com/845660 was
wrong on this point.

This patch allows EntryCallback to be null.

Bug:  778580 , 801990
Change-Id: I23d8a1b962876342160c3b9f2fb6a7d6f8df9894
Reviewed-on: https://chromium-review.googlesource.com/866656
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529267}
[modify] https://crrev.com/744085364bb2a7f6f6a6efdea7924a7c7529c4ce/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/744085364bb2a7f6f6a6efdea7924a7c7529c4ce/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e514bad57719dfbf6f80efea6d87c93c959c547

commit 4e514bad57719dfbf6f80efea6d87c93c959c547
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Tue Jan 23 10:24:32 2018

v8binding: Uses filesystem's V8FileCallback instead of FileCallback.

This patch removes use of filesystem's FileCallback.  The motivation
is the same as https://crrev.com/844307 .

Bug:  778580 
Change-Id: I5920c2c018cef9549fd382799a3677875a4c997f
Reviewed-on: https://chromium-review.googlesource.com/880124
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531198}
[modify] https://crrev.com/4e514bad57719dfbf6f80efea6d87c93c959c547/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/4e514bad57719dfbf6f80efea6d87c93c959c547/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
[modify] https://crrev.com/4e514bad57719dfbf6f80efea6d87c93c959c547/third_party/WebKit/Source/modules/filesystem/FileEntry.cpp
[modify] https://crrev.com/4e514bad57719dfbf6f80efea6d87c93c959c547/third_party/WebKit/Source/modules/filesystem/FileEntry.h
[modify] https://crrev.com/4e514bad57719dfbf6f80efea6d87c93c959c547/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/4e514bad57719dfbf6f80efea6d87c93c959c547/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18c9a8e9b9b88353d6cd76bcb5150a0942038a20

commit 18c9a8e9b9b88353d6cd76bcb5150a0942038a20
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Tue Jan 23 14:15:05 2018

v8binding: Uses filesystem's V8FileSystemCallback instead of FileSystemCallback.

This patch removes use of filesystem's FileSystemCallback.  The
motivation is the same as https://crrev.com/844307 .

Bug:  778580 
Change-Id: Id551add9762bd04655ebe2ba68be1e3b61e5a642
Reviewed-on: https://chromium-review.googlesource.com/880342
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531226}
[modify] https://crrev.com/18c9a8e9b9b88353d6cd76bcb5150a0942038a20/third_party/WebKit/Source/modules/filesystem/DOMWindowFileSystem.cpp
[modify] https://crrev.com/18c9a8e9b9b88353d6cd76bcb5150a0942038a20/third_party/WebKit/Source/modules/filesystem/DOMWindowFileSystem.h
[modify] https://crrev.com/18c9a8e9b9b88353d6cd76bcb5150a0942038a20/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/18c9a8e9b9b88353d6cd76bcb5150a0942038a20/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h
[modify] https://crrev.com/18c9a8e9b9b88353d6cd76bcb5150a0942038a20/third_party/WebKit/Source/modules/filesystem/SyncCallbackHelper.h
[modify] https://crrev.com/18c9a8e9b9b88353d6cd76bcb5150a0942038a20/third_party/WebKit/Source/modules/filesystem/WorkerGlobalScopeFileSystem.cpp
[modify] https://crrev.com/18c9a8e9b9b88353d6cd76bcb5150a0942038a20/third_party/WebKit/Source/modules/filesystem/WorkerGlobalScopeFileSystem.h
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12668a4cfab17fe2b62697327b65194ad80e81be

commit 12668a4cfab17fe2b62697327b65194ad80e81be
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Mon Jan 29 08:54:54 2018

v8binding: Uses filesystem's V8FileWriterCallback instead of FileWriterCallback.

This patch removes use of filesystem's FileWriterCallback.  The
motivation is the same as https://crrev.com/844307 .

Bug:  778580 
Change-Id: I69866c23290627a84ddedbaceaeae80b584b46e7
Reviewed-on: https://chromium-review.googlesource.com/886762
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532362}
[modify] https://crrev.com/12668a4cfab17fe2b62697327b65194ad80e81be/third_party/WebKit/Source/modules/filesystem/BUILD.gn
[modify] https://crrev.com/12668a4cfab17fe2b62697327b65194ad80e81be/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/12668a4cfab17fe2b62697327b65194ad80e81be/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
[modify] https://crrev.com/12668a4cfab17fe2b62697327b65194ad80e81be/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp
[modify] https://crrev.com/12668a4cfab17fe2b62697327b65194ad80e81be/third_party/WebKit/Source/modules/filesystem/FileEntry.cpp
[modify] https://crrev.com/12668a4cfab17fe2b62697327b65194ad80e81be/third_party/WebKit/Source/modules/filesystem/FileEntry.h
[modify] https://crrev.com/12668a4cfab17fe2b62697327b65194ad80e81be/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/12668a4cfab17fe2b62697327b65194ad80e81be/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h
[delete] https://crrev.com/d911a0a0018f350a931a3d0048dd9e97536405ef/third_party/WebKit/Source/modules/filesystem/FileWriterBaseCallback.h
[modify] https://crrev.com/12668a4cfab17fe2b62697327b65194ad80e81be/third_party/WebKit/Source/modules/filesystem/SyncCallbackHelper.h
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28d73918f695b43771c510846ebd0d15252ba9eb

commit 28d73918f695b43771c510846ebd0d15252ba9eb
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Mon Jan 29 12:41:38 2018

v8binding: Uses filesystem's V8MetadataCallback instead of MetadataCallback.

This patch removes use of filesystem's MetadataCallback.  The
motivation is the same as https://crrev.com/844307 .

Bug:  778580 
Change-Id: I75dda3272deb5cd641aa01da638b9ea5fee98bff
Reviewed-on: https://chromium-review.googlesource.com/886921
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532406}
[modify] https://crrev.com/28d73918f695b43771c510846ebd0d15252ba9eb/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/28d73918f695b43771c510846ebd0d15252ba9eb/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp
[modify] https://crrev.com/28d73918f695b43771c510846ebd0d15252ba9eb/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.h
[modify] https://crrev.com/28d73918f695b43771c510846ebd0d15252ba9eb/third_party/WebKit/Source/modules/filesystem/Entry.cpp
[modify] https://crrev.com/28d73918f695b43771c510846ebd0d15252ba9eb/third_party/WebKit/Source/modules/filesystem/Entry.h
[modify] https://crrev.com/28d73918f695b43771c510846ebd0d15252ba9eb/third_party/WebKit/Source/modules/filesystem/EntrySync.cpp
[modify] https://crrev.com/28d73918f695b43771c510846ebd0d15252ba9eb/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/28d73918f695b43771c510846ebd0d15252ba9eb/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h
[modify] https://crrev.com/28d73918f695b43771c510846ebd0d15252ba9eb/third_party/WebKit/Source/modules/filesystem/SyncCallbackHelper.h
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f83be3e72c1655c0c2bc1a9b0b398ae997ab903

commit 5f83be3e72c1655c0c2bc1a9b0b398ae997ab903
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Mon Jan 29 14:04:11 2018

v8binding: Uses filesystem's V8VoidCallback instead of VoidCallback.

This patch removes use of filesystem's VoidCallback.  The
motivation is the same as https://crrev.com/844307 .

Bug:  778580 
Change-Id: I2f57919461a31a4f64af287b40e0a3a6d1f242cb
Reviewed-on: https://chromium-review.googlesource.com/888234
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532414}
[modify] https://crrev.com/5f83be3e72c1655c0c2bc1a9b0b398ae997ab903/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/5f83be3e72c1655c0c2bc1a9b0b398ae997ab903/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/5f83be3e72c1655c0c2bc1a9b0b398ae997ab903/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp
[modify] https://crrev.com/5f83be3e72c1655c0c2bc1a9b0b398ae997ab903/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.h
[modify] https://crrev.com/5f83be3e72c1655c0c2bc1a9b0b398ae997ab903/third_party/WebKit/Source/modules/filesystem/DirectoryEntry.cpp
[modify] https://crrev.com/5f83be3e72c1655c0c2bc1a9b0b398ae997ab903/third_party/WebKit/Source/modules/filesystem/DirectoryEntry.h
[modify] https://crrev.com/5f83be3e72c1655c0c2bc1a9b0b398ae997ab903/third_party/WebKit/Source/modules/filesystem/DirectoryEntrySync.cpp
[modify] https://crrev.com/5f83be3e72c1655c0c2bc1a9b0b398ae997ab903/third_party/WebKit/Source/modules/filesystem/Entry.cpp
[modify] https://crrev.com/5f83be3e72c1655c0c2bc1a9b0b398ae997ab903/third_party/WebKit/Source/modules/filesystem/Entry.h
[modify] https://crrev.com/5f83be3e72c1655c0c2bc1a9b0b398ae997ab903/third_party/WebKit/Source/modules/filesystem/EntrySync.cpp
[modify] https://crrev.com/5f83be3e72c1655c0c2bc1a9b0b398ae997ab903/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/5f83be3e72c1655c0c2bc1a9b0b398ae997ab903/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h
[modify] https://crrev.com/5f83be3e72c1655c0c2bc1a9b0b398ae997ab903/third_party/WebKit/Source/modules/filesystem/SyncCallbackHelper.h
[modify] https://crrev.com/5f83be3e72c1655c0c2bc1a9b0b398ae997ab903/third_party/WebKit/Source/modules/filesystem/WorkerGlobalScopeFileSystem.cpp
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d6587d56de896aa04c3b0b2c100bdf5ef10c1b4

commit 2d6587d56de896aa04c3b0b2c100bdf5ef10c1b4
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Thu Feb 01 10:31:23 2018

v8binding: Refactors filesystem's DirectoryReader.

This patch is a kind of follow-up of https://crrev.com/844450 .
This patch makes DirectoryReader follow the same style as
other filesystem's callbacks.

Bug:  778580 
Change-Id: I64c89d54dfa8a91306a3ea6b94789a1fcdde2476
Reviewed-on: https://chromium-review.googlesource.com/890800
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533624}
[modify] https://crrev.com/2d6587d56de896aa04c3b0b2c100bdf5ef10c1b4/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp
[modify] https://crrev.com/2d6587d56de896aa04c3b0b2c100bdf5ef10c1b4/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.h
[modify] https://crrev.com/2d6587d56de896aa04c3b0b2c100bdf5ef10c1b4/third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp
[modify] https://crrev.com/2d6587d56de896aa04c3b0b2c100bdf5ef10c1b4/third_party/WebKit/Source/modules/filesystem/DirectoryReader.h
[modify] https://crrev.com/2d6587d56de896aa04c3b0b2c100bdf5ef10c1b4/third_party/WebKit/Source/modules/filesystem/DirectoryReaderBase.h
[modify] https://crrev.com/2d6587d56de896aa04c3b0b2c100bdf5ef10c1b4/third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.cpp
[modify] https://crrev.com/2d6587d56de896aa04c3b0b2c100bdf5ef10c1b4/third_party/WebKit/Source/modules/filesystem/DirectoryReaderSync.h
[modify] https://crrev.com/2d6587d56de896aa04c3b0b2c100bdf5ef10c1b4/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/2d6587d56de896aa04c3b0b2c100bdf5ef10c1b4/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h
[modify] https://crrev.com/2d6587d56de896aa04c3b0b2c100bdf5ef10c1b4/third_party/WebKit/Source/modules/filesystem/SyncCallbackHelper.h
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d76bcb3eef63cd2c4279bfc97b3070b9c9dc8d6

commit 8d76bcb3eef63cd2c4279bfc97b3070b9c9dc8d6
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Fri Feb 09 08:48:02 2018

v8binding: Uses generated callback interfaces of webdatabase.

This patch removes use of hand-written (non-generated) version
of callback classes of webdatabase, namely SQLStatementCallback,
SQLTransactionCallback, etc.  Uses V8SQLStatementCallback,
V8SQLTransactionCallback, etc. instead.

The motivation is the same as https://crrev.com/844307 .

Bug:  778580 
Change-Id: I0a27425bed734faae9dd034f7f07afc15e0de083
Reviewed-on: https://chromium-review.googlesource.com/904502
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535669}
[modify] https://crrev.com/8d76bcb3eef63cd2c4279bfc97b3070b9c9dc8d6/third_party/WebKit/Source/modules/webdatabase/Database.cpp
[modify] https://crrev.com/8d76bcb3eef63cd2c4279bfc97b3070b9c9dc8d6/third_party/WebKit/Source/modules/webdatabase/Database.h
[modify] https://crrev.com/8d76bcb3eef63cd2c4279bfc97b3070b9c9dc8d6/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp
[modify] https://crrev.com/8d76bcb3eef63cd2c4279bfc97b3070b9c9dc8d6/third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp
[modify] https://crrev.com/8d76bcb3eef63cd2c4279bfc97b3070b9c9dc8d6/third_party/WebKit/Source/modules/webdatabase/SQLStatement.h
[modify] https://crrev.com/8d76bcb3eef63cd2c4279bfc97b3070b9c9dc8d6/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp
[modify] https://crrev.com/8d76bcb3eef63cd2c4279bfc97b3070b9c9dc8d6/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.h
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03ab398df3f5ec6d6ff3aebc919fc334493b5767

commit 03ab398df3f5ec6d6ff3aebc919fc334493b5767
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Fri Feb 09 15:28:24 2018

v8binding: Converts ScrollStateCallback into callback function.

ScrollStateCallback has not yet been spec'ed (I'm not sure if
it's actively maintained), and there is no need to be callback
interface.  So this patch converts it from callback interface
to callback function, as callback function is preferable in
general and it's easier to refactor callback interface with
less number of callback interfaces.

Bug:  778580 
Change-Id: I973e7738a6ca10957156058ac2aeffceef6faf06
Reviewed-on: https://chromium-review.googlesource.com/911349
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535717}
[modify] https://crrev.com/03ab398df3f5ec6d6ff3aebc919fc334493b5767/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/03ab398df3f5ec6d6ff3aebc919fc334493b5767/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/03ab398df3f5ec6d6ff3aebc919fc334493b5767/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/03ab398df3f5ec6d6ff3aebc919fc334493b5767/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/03ab398df3f5ec6d6ff3aebc919fc334493b5767/third_party/WebKit/Source/core/dom/Element.idl
[modify] https://crrev.com/03ab398df3f5ec6d6ff3aebc919fc334493b5767/third_party/WebKit/Source/core/page/scrolling/ScrollStateCallback.cpp
[modify] https://crrev.com/03ab398df3f5ec6d6ff3aebc919fc334493b5767/third_party/WebKit/Source/core/page/scrolling/ScrollStateCallback.h
[delete] https://crrev.com/de8554cc465f42ee9dcc5a74e05a82105e1ebd89/third_party/WebKit/Source/core/page/scrolling/ScrollStateCallback.idl
[modify] https://crrev.com/03ab398df3f5ec6d6ff3aebc919fc334493b5767/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp
[modify] https://crrev.com/03ab398df3f5ec6d6ff3aebc919fc334493b5767/third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.cpp
[modify] https://crrev.com/03ab398df3f5ec6d6ff3aebc919fc334493b5767/third_party/WebKit/Source/core/page/scrolling/ViewportScrollCallback.h
Project Member

Comment 21 by bugdroid1@chromium.org, Feb 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa1bd96679306c85f20a9cf23e1ea27400ae1b8c

commit aa1bd96679306c85f20a9cf23e1ea27400ae1b8c
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Sat Feb 10 05:01:29 2018

v8binding: Removes unnecessary headers from callback interfaces.

Removes hand-written header files of callback interfaces, and
stops V8FooCallback inheriting FooCallback as there no longer
is any need.

Bug:  778580 
Change-Id: Ice287d73c08bb4ac83034b47e23cbc98f977ae61
Reviewed-on: https://chromium-review.googlesource.com/911648
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535957}
[modify] https://crrev.com/aa1bd96679306c85f20a9cf23e1ea27400ae1b8c/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
[modify] https://crrev.com/aa1bd96679306c85f20a9cf23e1ea27400ae1b8c/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py
[modify] https://crrev.com/aa1bd96679306c85f20a9cf23e1ea27400ae1b8c/third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py
[modify] https://crrev.com/aa1bd96679306c85f20a9cf23e1ea27400ae1b8c/third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl
[modify] https://crrev.com/aa1bd96679306c85f20a9cf23e1ea27400ae1b8c/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h
[modify] https://crrev.com/aa1bd96679306c85f20a9cf23e1ea27400ae1b8c/third_party/WebKit/Source/bindings/tests/results/core/V8TestLegacyCallbackInterface.cpp
[modify] https://crrev.com/aa1bd96679306c85f20a9cf23e1ea27400ae1b8c/third_party/WebKit/Source/bindings/tests/results/core/V8TestLegacyCallbackInterface.h
[delete] https://crrev.com/c4321f0e31fcf30a1adf437dc3427237b17979cf/third_party/WebKit/Source/core/html/VoidCallback.h
[modify] https://crrev.com/aa1bd96679306c85f20a9cf23e1ea27400ae1b8c/third_party/WebKit/Source/modules/filesystem/BUILD.gn
[delete] https://crrev.com/c4321f0e31fcf30a1adf437dc3427237b17979cf/third_party/WebKit/Source/modules/filesystem/EntriesCallback.h
[delete] https://crrev.com/c4321f0e31fcf30a1adf437dc3427237b17979cf/third_party/WebKit/Source/modules/filesystem/EntryCallback.h
[delete] https://crrev.com/c4321f0e31fcf30a1adf437dc3427237b17979cf/third_party/WebKit/Source/modules/filesystem/ErrorCallback.h
[delete] https://crrev.com/c4321f0e31fcf30a1adf437dc3427237b17979cf/third_party/WebKit/Source/modules/filesystem/FileCallback.h
[delete] https://crrev.com/c4321f0e31fcf30a1adf437dc3427237b17979cf/third_party/WebKit/Source/modules/filesystem/FileSystemCallback.h
[delete] https://crrev.com/c4321f0e31fcf30a1adf437dc3427237b17979cf/third_party/WebKit/Source/modules/filesystem/FileWriterCallback.h
[delete] https://crrev.com/c4321f0e31fcf30a1adf437dc3427237b17979cf/third_party/WebKit/Source/modules/filesystem/MetadataCallback.h
[delete] https://crrev.com/c4321f0e31fcf30a1adf437dc3427237b17979cf/third_party/WebKit/Source/modules/webdatabase/SQLStatementCallback.h
[delete] https://crrev.com/c4321f0e31fcf30a1adf437dc3427237b17979cf/third_party/WebKit/Source/modules/webdatabase/SQLStatementErrorCallback.h
[delete] https://crrev.com/c4321f0e31fcf30a1adf437dc3427237b17979cf/third_party/WebKit/Source/modules/webdatabase/SQLTransactionCallback.h
[delete] https://crrev.com/c4321f0e31fcf30a1adf437dc3427237b17979cf/third_party/WebKit/Source/modules/webdatabase/SQLTransactionErrorCallback.h
[modify] https://crrev.com/aa1bd96679306c85f20a9cf23e1ea27400ae1b8c/third_party/WebKit/Source/platform/bindings/CallbackInterfaceBase.h
Project Member

Comment 22 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5bc12649592f832123e751b65d115c987d841a2

commit f5bc12649592f832123e751b65d115c987d841a2
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Tue Feb 27 05:45:15 2018

v8binding: Supports "callback this value" in callback interfaces.

Makes callback interface's operations support "callback this value".

Also supports |InvokeAndReportException| member function as same as
callback function does.  The member function is defined only when
there is a single operation (without any overload) and its return
type is |void| (otherwise, the call sites must check the return value).

Bug:  778580 
Change-Id: I9e9b1e6eaf53d45356d7374963c14c321378af00
Reviewed-on: https://chromium-review.googlesource.com/936930
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539407}
[modify] https://crrev.com/f5bc12649592f832123e751b65d115c987d841a2/third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp
[modify] https://crrev.com/f5bc12649592f832123e751b65d115c987d841a2/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py
[modify] https://crrev.com/f5bc12649592f832123e751b65d115c987d841a2/third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py
[modify] https://crrev.com/f5bc12649592f832123e751b65d115c987d841a2/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
[modify] https://crrev.com/f5bc12649592f832123e751b65d115c987d841a2/third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl
[modify] https://crrev.com/f5bc12649592f832123e751b65d115c987d841a2/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp
[modify] https://crrev.com/f5bc12649592f832123e751b65d115c987d841a2/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h
[modify] https://crrev.com/f5bc12649592f832123e751b65d115c987d841a2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/f5bc12649592f832123e751b65d115c987d841a2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp
[modify] https://crrev.com/f5bc12649592f832123e751b65d115c987d841a2/third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp
[modify] https://crrev.com/f5bc12649592f832123e751b65d115c987d841a2/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/f5bc12649592f832123e751b65d115c987d841a2/third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp
[modify] https://crrev.com/f5bc12649592f832123e751b65d115c987d841a2/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp
Project Member

Comment 23 by bugdroid1@chromium.org, Feb 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f259cd13420496aae363fcaf2eed83f13af8fdc

commit 3f259cd13420496aae363fcaf2eed83f13af8fdc
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Wed Feb 28 06:19:39 2018

v8binding: Makes callback interface's operations return v8::Maybe.

Following the same way as callback function, callback interface's
operations also return v8::Maybe so that the callsites can handle
both of the return value and an exception.

Bug:  778580 
Change-Id: Id58bc69fe1eae00db29ac55b7f700c957f8038eb
Reviewed-on: https://chromium-review.googlesource.com/939227
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539732}
[delete] https://crrev.com/8ff6814a9ca223548f9d7f99821f225129e3908c/third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp
[modify] https://crrev.com/3f259cd13420496aae363fcaf2eed83f13af8fdc/third_party/WebKit/Source/bindings/modules/v8/custom/custom.gni
[modify] https://crrev.com/3f259cd13420496aae363fcaf2eed83f13af8fdc/third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py
[modify] https://crrev.com/3f259cd13420496aae363fcaf2eed83f13af8fdc/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
[modify] https://crrev.com/3f259cd13420496aae363fcaf2eed83f13af8fdc/third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl
[modify] https://crrev.com/3f259cd13420496aae363fcaf2eed83f13af8fdc/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp
[modify] https://crrev.com/3f259cd13420496aae363fcaf2eed83f13af8fdc/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h
[modify] https://crrev.com/3f259cd13420496aae363fcaf2eed83f13af8fdc/third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp
[modify] https://crrev.com/3f259cd13420496aae363fcaf2eed83f13af8fdc/third_party/WebKit/Source/modules/webdatabase/SQLStatementCallback.idl
[modify] https://crrev.com/3f259cd13420496aae363fcaf2eed83f13af8fdc/third_party/WebKit/Source/modules/webdatabase/SQLStatementErrorCallback.idl
[modify] https://crrev.com/3f259cd13420496aae363fcaf2eed83f13af8fdc/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp
[modify] https://crrev.com/3f259cd13420496aae363fcaf2eed83f13af8fdc/third_party/WebKit/Source/modules/webdatabase/SQLTransactionCallback.idl
[modify] https://crrev.com/3f259cd13420496aae363fcaf2eed83f13af8fdc/third_party/WebKit/Source/modules/webdatabase/SQLTransactionErrorCallback.idl
Project Member

Comment 24 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c241075464346e1abd9a7c9f7833168a8b15a7e7

commit c241075464346e1abd9a7c9f7833168a8b15a7e7
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Thu Mar 01 07:03:49 2018

v8binding: Implements V8PersistentCallbackInterface.

As same as callback function (V8PersistentCallback*Function*),
this patch implements V8PersistentCallback*Interface* in the
completely same way.  (Also see https://crrev.com/c/931561 .)

Following patches will changes CallbackInterfaceBase to use
wrapper-tracing instead of v8::Persistent, and then everything
will look the same as callback function.

Note that V8PersistentCallbackInterface is not yet actually
used in this patch.

Bug:  778580 
Change-Id: I08b70f5756d7a9128d8bff2a7a86c0b5cc4244a4
Reviewed-on: https://chromium-review.googlesource.com/940786
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540077}
[modify] https://crrev.com/c241075464346e1abd9a7c9f7833168a8b15a7e7/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
[modify] https://crrev.com/c241075464346e1abd9a7c9f7833168a8b15a7e7/third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl
[modify] https://crrev.com/c241075464346e1abd9a7c9f7833168a8b15a7e7/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp
[modify] https://crrev.com/c241075464346e1abd9a7c9f7833168a8b15a7e7/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h
[modify] https://crrev.com/c241075464346e1abd9a7c9f7833168a8b15a7e7/third_party/WebKit/Source/platform/bindings/CallbackInterfaceBase.cpp
[modify] https://crrev.com/c241075464346e1abd9a7c9f7833168a8b15a7e7/third_party/WebKit/Source/platform/bindings/CallbackInterfaceBase.h
Project Member

Comment 25 by bugdroid1@chromium.org, Mar 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91977d16a7f28a623e1295ac07791bccd46c2939

commit 91977d16a7f28a623e1295ac07791bccd46c2939
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Thu Mar 08 06:09:20 2018

v8binding: Enables wrapper-tracing in CallbackInterfaceBase.

Makes CallbackInterfaceBase and its subclasses use wrapper-tracing
to retain the underlying v8::Object.  Lets existing clients of
CallbackInterfaceBase, which don't support wrapper-tracing, use
V8PersistentCallbackInterface<T> instead.  The behavior and lifetime
shouldn't change.

Bug:  778580 
Change-Id: If5db42a3b8cd5622de0576a920128a0b5ab0861f
Reviewed-on: https://chromium-review.googlesource.com/951163
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541728}
[modify] https://crrev.com/91977d16a7f28a623e1295ac07791bccd46c2939/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp
[modify] https://crrev.com/91977d16a7f28a623e1295ac07791bccd46c2939/third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp
[modify] https://crrev.com/91977d16a7f28a623e1295ac07791bccd46c2939/third_party/WebKit/Source/modules/filesystem/DirectoryReader.h
[modify] https://crrev.com/91977d16a7f28a623e1295ac07791bccd46c2939/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/91977d16a7f28a623e1295ac07791bccd46c2939/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.h
[modify] https://crrev.com/91977d16a7f28a623e1295ac07791bccd46c2939/third_party/WebKit/Source/modules/webdatabase/SQLStatement.h
[modify] https://crrev.com/91977d16a7f28a623e1295ac07791bccd46c2939/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp
[modify] https://crrev.com/91977d16a7f28a623e1295ac07791bccd46c2939/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.h
[modify] https://crrev.com/91977d16a7f28a623e1295ac07791bccd46c2939/third_party/WebKit/Source/platform/bindings/CallbackInterfaceBase.cpp
[modify] https://crrev.com/91977d16a7f28a623e1295ac07791bccd46c2939/third_party/WebKit/Source/platform/bindings/CallbackInterfaceBase.h
Project Member

Comment 26 by bugdroid1@chromium.org, Mar 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/277ac433d0ce617bcdbc5b476260dc5e0c096e68

commit 277ac433d0ce617bcdbc5b476260dc5e0c096e68
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Thu Mar 08 12:56:11 2018

v8binding: Deletes WrapPersistent for wrapper-tracing callback interfaces.

Deletes |WrapPersistent| for wrapper-tracing version of callback
interfaces after https://crrev.com/c/951163 .

Bug:  778580 
Change-Id: I16e8c19d1c01f74bc841aa3bcc1f6dacdc2563f8
Reviewed-on: https://chromium-review.googlesource.com/954864
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541779}
[modify] https://crrev.com/277ac433d0ce617bcdbc5b476260dc5e0c096e68/third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl
[modify] https://crrev.com/277ac433d0ce617bcdbc5b476260dc5e0c096e68/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h
[modify] https://crrev.com/277ac433d0ce617bcdbc5b476260dc5e0c096e68/third_party/WebKit/Source/platform/bindings/CallbackInterfaceBase.h
Project Member

Comment 27 by bugdroid1@chromium.org, Apr 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2fd2557e304d4037627e4012fe2e574a66c42e0

commit d2fd2557e304d4037627e4012fe2e574a66c42e0
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Thu Apr 19 16:45:37 2018

v8binding: Allows an ES object to be an IDL callback interface type value.

The case that an IDL callback interface type value is an ES object,
not an ES function, was somehow slipped out of support by mistake.
This patch now supports such a case.  Now you can pass the following
object as a callback interface type value.

    obj = { handleEvent: function() {} }

Bug:  778580 
Change-Id: I491a859f604b1770fd5024515280031dd8804abe
Reviewed-on: https://chromium-review.googlesource.com/1017680
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552048}
[modify] https://crrev.com/d2fd2557e304d4037627e4012fe2e574a66c42e0/third_party/WebKit/LayoutTests/storage/websql/execute-sql-args-expected.txt
[modify] https://crrev.com/d2fd2557e304d4037627e4012fe2e574a66c42e0/third_party/WebKit/LayoutTests/storage/websql/execute-sql-args.js
[modify] https://crrev.com/d2fd2557e304d4037627e4012fe2e574a66c42e0/third_party/blink/renderer/bindings/templates/callback_interface.cpp.tmpl
[modify] https://crrev.com/d2fd2557e304d4037627e4012fe2e574a66c42e0/third_party/blink/renderer/bindings/templates/methods.cpp.tmpl
Project Member

Comment 28 by bugdroid1@chromium.org, May 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11ef1ec8c025bf4a7d712bb25324df38551b563f

commit 11ef1ec8c025bf4a7d712bb25324df38551b563f
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Wed May 09 16:44:57 2018

v8binding: Makes NodeFilter an IDL callback interface.

Re-implements NodeFilter based on CallbackInterfaceBase.

Major changes are the followings:

a) Custom implementation V8NodeFilterCondition is gone in
this patch as we have auto-generated V8NodeFilter.

b) NodeFilter.h is also gone.  V8NodeFilter provides
IDL constants directly.

c) The old implementation didn't perform any type check.
Passing 0 (zero) as NodeFilter was okay and it was
treated as if |null|.  With this patch, the generated
code performs a regular type check.

Bug:  778580 

Change-Id: Ifb95aa78ead36081ece9bd6616ffb23d0704b67b
Reviewed-on: https://chromium-review.googlesource.com/1011864
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557218}
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/WebKit/LayoutTests/fast/dom/TreeWalker/acceptNode-filter-expected.txt
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/WebKit/LayoutTests/fast/dom/node-filter-gc.html
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/WebKit/LayoutTests/fast/dom/node-filter-use-counters.html
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/WebKit/LayoutTests/traversal/size-zero-run.html
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/bindings.gni
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/core/v8/to_v8_for_core.h
[delete] https://crrev.com/7803d8c58f9b02d3d434b6c6c9f90d1f7919da31/third_party/blink/renderer/bindings/core/v8/v8_node_filter_condition.cc
[delete] https://crrev.com/7803d8c58f9b02d3d434b6c6c9f90d1f7919da31/third_party/blink/renderer/bindings/core/v8/v8_node_filter_condition.h
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/scripts/code_generator_v8.py
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/scripts/v8_callback_interface.py
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/scripts/v8_interface.py
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/scripts/v8_types.py
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/templates/callback_interface.cpp.tmpl
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/templates/callback_interface.h.tmpl
[delete] https://crrev.com/7803d8c58f9b02d3d434b6c6c9f90d1f7919da31/third_party/blink/renderer/bindings/templates/legacy_callback_interface.cpp.tmpl
[delete] https://crrev.com/7803d8c58f9b02d3d434b6c6c9f90d1f7919da31/third_party/blink/renderer/bindings/templates/legacy_callback_interface.h.tmpl
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/templates/methods.cpp.tmpl
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/templates/templates.gni
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/tests/idls/core/test_object.idl
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_functions.cc
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/tests/results/core/v8_test_legacy_callback_interface.cc
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/tests/results/core/v8_test_legacy_callback_interface.h
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/bindings/tests/results/core/v8_test_object.h
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/core/dom/BUILD.gn
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/core/dom/document.h
[delete] https://crrev.com/7803d8c58f9b02d3d434b6c6c9f90d1f7919da31/third_party/blink/renderer/core/dom/node_filter.h
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/core/dom/node_filter.idl
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/core/dom/node_iterator.cc
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/core/dom/node_iterator.h
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/core/dom/node_iterator_base.cc
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/core/dom/node_iterator_base.h
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/core/dom/tree_walker.cc
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/core/dom/tree_walker.h
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/platform/bindings/callback_interface_base.h
[modify] https://crrev.com/11ef1ec8c025bf4a7d712bb25324df38551b563f/third_party/blink/renderer/platform/bindings/to_v8.h

Comment 29 by yukishiino@chromium.org, Jun 4 2018

Status: Fixed (was: Started)
Project Member

Comment 30 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/204478edcf8b4698ab935a3c3f30516dfcf8bb76

commit 204478edcf8b4698ab935a3c3f30516dfcf8bb76
Author: Daniel Bratell <bratell@opera.com>
Date: Wed Oct 17 16:33:16 2018

Removed BUILD.gn reference to non-existing void_callback.h

The file void_callback.h has never existed but there was
a VoidCallback.h in third_party/WebKit until February this year
when it was deleted in a cleanup.

This might have triggered isolate step errors on trybots.

Bug:  778580 

Change-Id: I659c7ec456a8c21a274d1743d701061c798c7ace
Reviewed-on: https://chromium-review.googlesource.com/c/1286811
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#600418}
[modify] https://crrev.com/204478edcf8b4698ab935a3c3f30516dfcf8bb76/third_party/blink/renderer/core/html/BUILD.gn
Project Member

Comment 31 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60819d9f23201ee22c02982c011cbfed34bcea46

commit 60819d9f23201ee22c02982c011cbfed34bcea46
Author: Daniel Bratell <bratell@opera.com>
Date: Wed Oct 17 18:40:30 2018

Removed webdatabase/BUILD.gn references to deleted headers.

In February a number of obsolete header files were deleted but
some of them were still listed in sources lists. That might have
caused isolate step errors in trybots.

Bug:  778580 
Change-Id: Ica026a5d157c64f07465f520a15ed2ffab92c234
Reviewed-on: https://chromium-review.googlesource.com/c/1286428
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#600492}
[modify] https://crrev.com/60819d9f23201ee22c02982c011cbfed34bcea46/third_party/blink/renderer/modules/webdatabase/BUILD.gn
►

Sign in to add a comment