New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778575 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug

Blocking:
issue 667560



Sign in to add a comment

http/tests/devtools/tracing/timeline-js webkit_layout_tests fail on Mac

Project Member Reported by vasi...@chromium.org, Oct 26 2017

Issue description

https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/6658
http/tests/devtools/tracing/timeline-js/timeline-injected-script-eval.html is flaky

The output
CONSOLE ERROR: line 57: Uncaught TypeError: Cannot read property 'dispatchMessage' of undefined
Tests the Timeline API function call is not recorded for InjectedScript.eval.

https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/25392
http/tests/devtools/tracing/timeline-js/timeline-script-id.html is flaky
The output
CONSOLE ERROR: line 57: Uncaught TypeError: Cannot read property 'dispatchMessage' of undefined
Test that checks location resolving mechanics for TimerInstall TimerRemove and FunctionCall events with scriptId.

It expects two FunctionCall for InjectedScript, two TimerInstall events, two FunctionCall events and one TimerRemove event to be logged with performActions.js script name and some line number.

detailsTextContent for TimerInstall event: 'performActions.js:4'
details.textContent for TimerInstall event: 'performActions.js:4'
detailsTextContent for TimerInstall event: 'performActions.js:5'
details.textContent for TimerInstall event: 'performActions.js:5'
detailsTextContent for FunctionCall event: 'performActions.js:9'
details.textContent for FunctionCall event: 'intervalTimerWork @ performActions.js:9'
detailsTextContent for FunctionCall event: 'performActions.js:9'
details.textContent for FunctionCall event: 'intervalTimerWork @ performActions.js:9'
detailsTextContent for TimerRemove event: 'performActions.js:12'
details.textContent for TimerRemove event: 'performActions.js:12'

 
Blocking: 667560
Owner: chenwilliam@chromium.org
They were introduced in r498232.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/270a53c55ad0f51dee233784ef89c0a8f11b79ae

commit 270a53c55ad0f51dee233784ef89c0a8f11b79ae
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Oct 26 10:04:14 2017

Update expectations for http/tests/devtools/tracing/timeline-js tests

They are falky on Mac.

TBR=chenwilliam@chromium.org

Bug:  778575 
Change-Id: Ie7e763e408d47ce03af35c2382de24212f197126
Reviewed-on: https://chromium-review.googlesource.com/737997
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511778}
[modify] https://crrev.com/270a53c55ad0f51dee233784ef89c0a8f11b79ae/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97755939ec81f1aafb9cba6c8ee640d349dab9b4

commit 97755939ec81f1aafb9cba6c8ee640d349dab9b4
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Oct 26 13:25:34 2017

Update expectations for DevTools layout tests on Mac.

They all fail due to the same line in the output:
"CONSOLE ERROR: line 57: Uncaught TypeError: Cannot read property 'dispatchMessage' of undefined"

TBR=chenwilliam@chromium.org

Bug:  778575 
Change-Id: I5c47679f3b7dfc029be378a3b3193c1ceab41be6
Reviewed-on: https://chromium-review.googlesource.com/738383
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511802}
[modify] https://crrev.com/97755939ec81f1aafb9cba6c8ee640d349dab9b4/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d441ffd31a7093ff0dd028f1f75fa2cf3239528

commit 3d441ffd31a7093ff0dd028f1f75fa2cf3239528
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Oct 26 13:46:06 2017

Expect a Devtool Layout test to fail on Mac

timeline-script-parse.js fails with the same string as other tests.

TBR=chenwilliam@chromium.org

Bug:  778575 
Change-Id: I8a0edc91411026409cf56ac1999c6cef49f30f47
Reviewed-on: https://chromium-review.googlesource.com/739381
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511807}
[modify] https://crrev.com/3d441ffd31a7093ff0dd028f1f75fa2cf3239528/third_party/WebKit/LayoutTests/TestExpectations

Cc: nek...@chromium.org peria@chromium.org pdr@chromium.org
Labels: -Pri-2 Pri-1
Status: Assigned (was: Untriaged)
Increasing the priority. Devtools tests are randomly failing the whole shift.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4355a4b93cab97acef3ee3b76e452d5d6bc53e9

commit a4355a4b93cab97acef3ee3b76e452d5d6bc53e9
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Oct 26 14:04:46 2017

Mark flaky DevTools layout tests on Linux

TBR=chenwilliam@chromium.org

Bug:  778575 
Change-Id: I46a616ea86d8c52584620ce37f8971693965ef6d
Reviewed-on: https://chromium-review.googlesource.com/739442
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511813}
[modify] https://crrev.com/a4355a4b93cab97acef3ee3b76e452d5d6bc53e9/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4920a015426719e7f2bd6cacbf46375b5fd1b5b0

commit 4920a015426719e7f2bd6cacbf46375b5fd1b5b0
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Oct 26 14:38:04 2017

Disable some DevTools tests on Mac.

TBR=chenwilliam@chromium.org

Bug:  778575 
Change-Id: I20f7d0b9770ff1f6e7df0114981b8cd0d7a54018
Reviewed-on: https://chromium-review.googlesource.com/739483
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511815}
[modify] https://crrev.com/4920a015426719e7f2bd6cacbf46375b5fd1b5b0/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/257f10a30637b19c67f1c2d6219531415a2e20a4

commit 257f10a30637b19c67f1c2d6219531415a2e20a4
Author: Will Chen <chenwilliam@chromium.org>
Date: Tue Nov 14 20:52:34 2017

DevTools: enable timeline-js tests after fixing flakiness

These tests were disabled because of a flakiness with the new DevTools test
framework which has subsequently been fixed:
* https://chromium-review.googlesource.com/c/chromium/src/+/761957

TBR=vasilii@chromium.org

Bug:  778575 
Change-Id: I41417bfa31f3115a87e8015e995af1903fac6197
Reviewed-on: https://chromium-review.googlesource.com/769340
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516418}
[modify] https://crrev.com/257f10a30637b19c67f1c2d6219531415a2e20a4/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment