History screen has an empty space between the header and the content |
|||||
Issue descriptionChrome Version: 64.0.3250 What steps will reproduce the problem? (1) Open chrome with an account register but not signed in (2) Open history What is the expected result? The collection content should be right below the header. Or a message should be displayed in that space. What happens instead? There is an empty space between the header and the first history entry. Inspecting the view hierarchy, there is an empty HistoryEntriesStatusCell.
,
Nov 21 2017
To give more clarity, added screenshots. Build : 64.0.3271.0 Canary iOS Version: 11.1 Device: iPhone X
,
Dec 5 2017
While this bug isn't specific to iPhoneX, it looks much worse on the X. Marking RBS for M65.
,
Dec 16 2017
Some of the blank space is caused by the empty HistoryEntriesStatusCell The rest of the space is iOS 11 only, and its due the topInset changing. I have a CL inflight for this.
,
Dec 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d49ccee413bfe066d9357f42dbed4724ea0f1a2c commit d49ccee413bfe066d9357f42dbed4724ea0f1a2c Author: sczs <sczs@chromium.org> Date: Sat Dec 16 04:31:28 2017 [ios] Fixes History CollectionVC top margin. Before crrev.com/c/695934, a top message was always being displayed. Now thats not the case, this CLremoves the top cell that contains the message if there's no message. Also, on iOS11 the contentInset was being adjusted automatically, causing an even larger blank space on top. This is fixed by setting the ContentInsetAdjustmentBehavior to never. Screenshots: https://drive.google.com/open?id=1N6egGvEOeSF2uags3w4hmLupWy7Vk4v3 https://drive.google.com/open?id=1hCW15FIUtw2o5rJ7MiqDcRd1z6Xq42O0 Bug: 778571 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2b9f2b5f92e22f955fb10c5ea609f4ee4f130836 Reviewed-on: https://chromium-review.googlesource.com/830911 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#524588} [modify] https://crrev.com/d49ccee413bfe066d9357f42dbed4724ea0f1a2c/ios/chrome/browser/ui/history/history_collection_view_controller.mm [modify] https://crrev.com/d49ccee413bfe066d9357f42dbed4724ea0f1a2c/ios/chrome/browser/ui/history/history_collection_view_controller_unittest.mm [modify] https://crrev.com/d49ccee413bfe066d9357f42dbed4724ea0f1a2c/ios/chrome/browser/ui/history/history_entries_status_item.h [modify] https://crrev.com/d49ccee413bfe066d9357f42dbed4724ea0f1a2c/ios/chrome/browser/ui/history/history_entries_status_item.mm [modify] https://crrev.com/d49ccee413bfe066d9357f42dbed4724ea0f1a2c/ios/chrome/browser/ui/history/history_entries_status_item_unittest.mm
,
Dec 16 2017
,
Dec 19 2017
Issue verified under Version: 65.0.3299.0 canary Device: iPhoneX iOS: 11.1.2 Refer to: https://drive.google.com/open?id=15L6gcvFx0kJHIllMzst5pD_ghP6VDmBJ |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jdhakshinamoor@chromium.org
, Nov 21 2017