New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 778569 link

Starred by 2 users
Status: Assigned
Owner:
jdoerrie@chromium.org
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
hcarmona@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to Undo/Redo any keyword in Search settings text-box.

Reported by dchau...@etouch.net, Oct 26 2017 
Chrome Version: 64.0.3250.0 (Official Build) b311d7bf3bc03d9706c0d43624afdb56a7978610-refs/heads/master@{#511680} 32/64-bit.
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1).

What steps will reproduce the problem?
1. Launch Chrome and navigate to chrome://settings page.
2. Type any keyword(For Ex: X) in Search settings text-box.
3. Now press "Ctrl + Z" key from keyboard and observe.

Nothing happens on pressing "Ctrl + Z" key from keyboard.
Typed keyword should get removed on pressing "Ctrl + Z" key from keyboard.

This is a regression issue, broken in M-63 series, will soon update bisect info.

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
496 KB View Download
Expected behavior.mp4
643 KB View Download

Comment 1 by dchau...@etouch.net, Oct 26 2017

Labels: hasbisect-per-revision
Owner: jdoerrie@chromium.org
Status: Assigned (was: Unconfirmed)
Below is manual regression range and bisect info.

Good build: 63.0.3225.0
Bad build: 63.0.3226.0

You are probably looking for a change made after 504658 (known good), but no later than 504659 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/88d078811e5743304ab4407d01e401ac1b77948e..3bc5e2682778f84572efc5bf4383b34d5c48e699

Suspect: https://chromium.googlesource.com/chromium/src/+/3bc5e2682778f84572efc5bf4383b34d5c48e699

@jdoerrie: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Comment 2 by ranjitkan@chromium.org, Oct 26 2017

Labels: ReleaseBlock-Stable
Tagging with blocker label, please undo if not the case.

Comment 3 by jdoerrie@chromium.org, Oct 27 2017

Cc: hcarmona@chromium.org
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Breaking this was a conscious choice to enable the UNDO of password deletion via the CTRL+Z shortcut. I will look into how to restore this functionality once I am back mid November. I don't think this is P1 and release blocking, however.

Adding hcarmona@ to provide more feedback if necessary.

Comment 4 by dpa...@chromium.org, Oct 27 2017 

CTRL-Z should have the undo effect only when the user is in the Passwords supbage, no? Hijacking ctrl-z always seems like a sub-optimal solution. 

How about checking if there was anything to undo, and only then calling preventDefault(). If there was nothing to undo, the normal browser behavior for ctrl-z should be triggered.
►

Sign in to add a comment