New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778525 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Devtools window turns blank on clicking 'Restore defaults and reload' button.

Reported by avsha...@etouch.net, Oct 26 2017

Issue description

Chrome version : 64.0.3250.0 (Official Build) b311d7bf3bc03d9706c0d43624afdb56a7978610-refs/heads/master@{#511680} 32/64 bit
OS : Windows (7,8,10)

What steps will reproduce the problem?
1. Launch chrome and open devtools on NTP.
2. Hit F1 key to open 'Preferences', scroll down and click on 'Restore defaults and reload' button, observe.

Actual Result : Devtools window turns blank on clicking 'Restore defaults and reload' button and does not reload back.

Expected Result : Devtools window should reload properly after clicking on 'Restore defaults and reload' button.

This is a regression issue broken in ‘M-64’ and will soon update other info.
 
Actual_Result.mp4
774 KB View Download

Comment 1 by avsha...@etouch.net, Oct 26 2017

Expected_Result.mp4
857 KB View Download

Comment 2 by avsha...@etouch.net, Oct 26 2017

Labels: hasbisect-per-revision OS-Linux OS-Mac
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build : 64.0.3249.0 (Revision : 511319)
Bad build : 64.0.3250.0 (Revision : 511680)

You are probably looking for a change made after 511610 (known good), but no later than 511611 (first known bad).

CHANGELOG URL: 
https://chromium.googlesource.com/chromium/src/+log/3a39697331644a941b6501db7907c6942c7d8b3a..7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b

Suspect : https://chromium.googlesource.com/chromium/src/+/7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b

@dgozman : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note : 
1. Above issue is also observed on Mac(10.12.6) and Linux(14.04 LTS) OS.
2. This issue can also be reproduced by changing devtools theme from 'Light' to 'Dark'.

Thank you!
Labels: ReleaseBlock-Dev
Tagging with blocker label, please undo or reduce priority if not the case.

Thanks.!
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a955d2eaaa66336268b5e91118cd812dc28664d

commit 7a955d2eaaa66336268b5e91118cd812dc28664d
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Oct 26 22:32:48 2017

[DevTools] Only recreate DevToolsFrontendHost if the frame has changed

We used to recreate DevToolsFrontendHost on any navigation and rely
on the fact that destroying old instance does not cleanup in the
renderer. This has changed with migration to mojo, where we do
properly cleanup.

Bug:  776009 ,  778525 
Change-Id: I23c8a9d959e92eae394ac5029a0ac1b160363654
Reviewed-on: https://chromium-review.googlesource.com/740087
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511988}
[modify] https://crrev.com/7a955d2eaaa66336268b5e91118cd812dc28664d/chrome/browser/devtools/devtools_ui_bindings.cc

Status: Fixed (was: Assigned)

Sign in to add a comment