New issue
Advanced search Search tips

Issue 778507 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task


Sign in to add a comment

Select word/paragraph for SelectionController on layout NG

Project Member Reported by yosin@chromium.org, Oct 26 2017

Issue description

We should make selecting word/paragraph in SelectionController on layout NG.
 

Comment 1 by yosin@chromium.org, Oct 26 2017

Blocking: 707656
Labels: -Type-Bug Type-Task
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aa0b122e8c4e0f613a74bf15b2f1354ebb3fe3d

commit 4aa0b122e8c4e0f613a74bf15b2f1354ebb3fe3d
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Fri Oct 27 05:35:21 2017

Introduce tests for selecting word with -webkit-text-security

This patch introduces tests for selecting word with "-webkit-text-security"
CSS property, used for displaying bullets for password field, because we don't
have test cases for them.

Bug: 778507
Change-Id: I0e49a1d48ff6c9ec1c99b923d3badc11ac1e93c9
Reviewed-on: https://chromium-review.googlesource.com/737893
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512095}
[modify] https://crrev.com/4aa0b122e8c4e0f613a74bf15b2f1354ebb3fe3d/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
[modify] https://crrev.com/4aa0b122e8c4e0f613a74bf15b2f1354ebb3fe3d/third_party/WebKit/Source/core/editing/VisibleUnitsWordTest.cpp
[modify] https://crrev.com/4aa0b122e8c4e0f613a74bf15b2f1354ebb3fe3d/third_party/WebKit/Source/core/editing/testing/EditingTestBase.cpp
[modify] https://crrev.com/4aa0b122e8c4e0f613a74bf15b2f1354ebb3fe3d/third_party/WebKit/Source/core/editing/testing/EditingTestBase.h

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d8b852f1b3d1f4991ea3bf873a03b35ef98c46c

commit 4d8b852f1b3d1f4991ea3bf873a03b35ef98c46c
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Mon Oct 30 04:35:23 2017

Introduce EmitsSmallXForTextSecurity behavior to TextIteratorBehavior

This patch introduces |EmitsSmallXForTextSecurity| behavior to
|TextIteratorBehavior| to get "x" characters for |Text| node having
CSS property "-webkit-text-security" other than "none" from |TextIterator|.

This patch is a preparation of the patch[1].

[1] http://crrev.com/c/741303 Move text-security CSS property handling to
TextIterator

Bug: 778507
Change-Id: I1a7699bf5806d3746ed0917879d7a8ee4f7b41dc
Reviewed-on: https://chromium-review.googlesource.com/740926
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512441}
[modify] https://crrev.com/4d8b852f1b3d1f4991ea3bf873a03b35ef98c46c/third_party/WebKit/Source/core/editing/iterators/TextIteratorBehavior.cpp
[modify] https://crrev.com/4d8b852f1b3d1f4991ea3bf873a03b35ef98c46c/third_party/WebKit/Source/core/editing/iterators/TextIteratorBehavior.h

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70875fdbcfa084948aab6914a7ec5eb1fc9d6f3c

commit 70875fdbcfa084948aab6914a7ec5eb1fc9d6f3c
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Mon Oct 30 06:59:46 2017

Introduce RepeatString()

This patch introduces |RepeatString()| to make a string with repeated string,
e.g. RepeatString(3, "abc") returns "abcabcabc".

This patch is a preparation of the patch[1].

[1] http://crrev.com/c/741303 Move text-security CSS property handling to
TextIterator

Bug: 778507
Change-Id: I6324914fe228252ad611005be8b413b635edaa11
Reviewed-on: https://chromium-review.googlesource.com/741210
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512449}
[modify] https://crrev.com/70875fdbcfa084948aab6914a7ec5eb1fc9d6f3c/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/70875fdbcfa084948aab6914a7ec5eb1fc9d6f3c/third_party/WebKit/Source/core/editing/EditingUtilities.h
[modify] https://crrev.com/70875fdbcfa084948aab6914a7ec5eb1fc9d6f3c/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/326962726c2e14e5aed71307a5cef93b1fb0e87e

commit 326962726c2e14e5aed71307a5cef93b1fb0e87e
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Mon Oct 30 08:53:06 2017

Make SimplifiedBackwardsTextIterator to hold TextBehavior

This patch changes |SimplifiedBackwardsTextIterator| to hold |TextBehavior|
in member variable as replacement of |bool| member |stop_on_form_controls_|
as preparation of using other behavior options.


This patch is a preparation of the patch[1].


[1] http://crrev.com/c/741303 Move text-security CSS property handling to
TextIterator

Bug: 778507
Change-Id: I94d9bcf743d684d2121a1df1fda91ea6f6c65427
Reviewed-on: https://chromium-review.googlesource.com/741103
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512458}
[modify] https://crrev.com/326962726c2e14e5aed71307a5cef93b1fb0e87e/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp
[modify] https://crrev.com/326962726c2e14e5aed71307a5cef93b1fb0e87e/third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.h

Comment 6 by yosin@chromium.org, Oct 31 2017

Blockedon: 736970

Comment 7 by yosin@chromium.org, Oct 31 2017

Blocking: 779981
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bca48f5eff251b811cf361b73431bd2c72274b11

commit bca48f5eff251b811cf361b73431bd2c72274b11
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Fri Nov 10 06:35:25 2017

Utilize EmitsSmallXForTextSecurity TextIteratorBehavior in PreviousBoundary()

This patch changes |PreviousBoundary()| to utilize |EmitsSmallXForTextSecurity|
|TextIteratorBehavior| to handle -webkit-text-security CSS property in
|SimplifiedBackwardTextIterator| to reduce source code for improving code
health.

This patch is similar to the patch[1].

[1] http://crrev.com/c/760063: Utilize EmitsSmallXForTextSecurity
TextIteratorBehavior in NextBoundary()

Bug: 778507
Change-Id: I4612c7916498ee2604062ac50eb79803f93172e9
Reviewed-on: https://chromium-review.googlesource.com/760218
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515483}
[modify] https://crrev.com/bca48f5eff251b811cf361b73431bd2c72274b11/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4536c5ccb6e228d4c93e26ebd8a4672b31747738

commit 4536c5ccb6e228d4c93e26ebd8a4672b31747738
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Fri Nov 10 06:49:25 2017

Utilize EmitsSmallXForTextSecurity TextIteratorBehavior in NextBoundary()

This patch changes |NextBoundary()| to utilize |EmitsSmallXForTextSecurity|
|TextIteratorBehavior| to handle -webkit-text-security CSS property in
|TextIterator| to reduce source code for improving code health.

This patch is similar to the patch[1].

http://crrev.com/c/760218: Utilize EmitsSmallXForTextSecurity
TextIteratorBehavior in PreviousBoundary()

Bug: 778507
Change-Id: Ia62bcec825be863ff15a9075eeb22f2a6a9ee981
Reviewed-on: https://chromium-review.googlesource.com/760063
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515489}
[modify] https://crrev.com/4536c5ccb6e228d4c93e26ebd8a4672b31747738/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c41b7fbc487492f20401aafec634b0e2be0aab3

commit 7c41b7fbc487492f20401aafec634b0e2be0aab3
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Tue Jan 30 01:36:39 2018

Improve editing/selection/modify_move/move_around_image.html for ease of debugging

This patch changes "editing/selection/modify_move/move_around_image.html" to
verify one function call instead of multiple function calls for ease of
debugging.

Bug: 778507
Change-Id: I8a8eea53724f34e45c7fd3273635c1aee716773b
Reviewed-on: https://chromium-review.googlesource.com/890899
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532719}
[modify] https://crrev.com/7c41b7fbc487492f20401aafec634b0e2be0aab3/third_party/WebKit/LayoutTests/editing/selection/modify_move/move_around_image.html

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8c029b4e431dac489aa6113f93dfe6abfc080a9

commit f8c029b4e431dac489aa6113f93dfe6abfc080a9
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Wed Jan 31 02:32:50 2018

Introduce VisibleUnitsWordTest.EndOfWordBasic

This patch introduces |VisibleUnitsWordTest.EndOfWordBasic| unit test
to record current behavior as a preparation of the patch[1].

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection

Bug: 778507
Change-Id: Ic65a6a646806465c05b1a8fb7d5213beeb71e6e4
Reviewed-on: https://chromium-review.googlesource.com/892761
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533169}
[modify] https://crrev.com/f8c029b4e431dac489aa6113f93dfe6abfc080a9/third_party/WebKit/Source/core/editing/VisibleUnitsWordTest.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3aa3399563efac1105a8ed659d4d5d066105a30

commit a3aa3399563efac1105a8ed659d4d5d066105a30
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Feb 01 01:57:33 2018

Introduce test cases for EndOfWord() with PreviousWordIfOnBoundaryBasic

This patch introduces test cases for |EndOfWord()| with
|PreviousWordIfOnBoundaryBasic| to record current behavior as a preparation of
the patch[1].

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection

Bug: 778507
Change-Id: I598b650c495af5587f6417f04fff4f8236b69903
Reviewed-on: https://chromium-review.googlesource.com/895228
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533523}
[modify] https://crrev.com/a3aa3399563efac1105a8ed659d4d5d066105a30/third_party/WebKit/Source/core/editing/VisibleUnitsWordTest.cpp

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/482fd9a30baa5066f8f44bd8484bcb7b3b5ea918

commit 482fd9a30baa5066f8f44bd8484bcb7b3b5ea918
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Feb 01 02:16:36 2018

Introduce test cases for StartOfWord() with PreviousWordIfOnBoundaryBasic

This patch introduces test cases for |StartOfWord()| with
|PreviousWordIfOnBoundaryBasic| to record current behavior as a preparation of
the patch[1].

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection

Bug: 778507
Change-Id: I5b2452cf45c3063ed67d436def4b05a3a617b424
Reviewed-on: https://chromium-review.googlesource.com/895208
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533529}
[modify] https://crrev.com/482fd9a30baa5066f8f44bd8484bcb7b3b5ea918/third_party/WebKit/Source/core/editing/VisibleUnitsWordTest.cpp

Project Member

Comment 14 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e8415b6517e4e252c10fed82898196e429a3e41

commit 8e8415b6517e4e252c10fed82898196e429a3e41
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Feb 01 05:50:32 2018

Introduce test cases for NextWordPosition()

This patch introduces test cases for |NextWordPosition()| to record current
behavior as a preparation of the patch[1].

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection

Bug: 778507
Change-Id: Ic98cdea94e5be2f3d13448aa9e087a02b70a0df0
Reviewed-on: https://chromium-review.googlesource.com/895236
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533577}
[modify] https://crrev.com/8e8415b6517e4e252c10fed82898196e429a3e41/third_party/WebKit/Source/core/editing/VisibleUnits.h
[modify] https://crrev.com/8e8415b6517e4e252c10fed82898196e429a3e41/third_party/WebKit/Source/core/editing/VisibleUnitsWordTest.cpp

Blockedon: 810623
Blocking: 811502
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f05e9b361d4179ebb9456f9eaf851a96bfbd230

commit 9f05e9b361d4179ebb9456f9eaf851a96bfbd230
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Fri Feb 16 06:52:20 2018

Introduce FlatTreeTraversal:: AncestorsOf()

This patch introduces |FlatTreeTraversal::AncestorsOf()| as |NodeTraversal|.

This patch is a preparation of the patch[1].

Note: The patch[2] introduces |FlatTreeTraversal::InclusiveAncestorsOf()|.

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection
[2] http://crrev.com/c/742770 Introduce FlatTreeTraversal::InclusiveAncestorsOf

Bug: 778507
Change-Id: I5f76f00c06a4e02b5981600049af11853fa2f60b
Reviewed-on: https://chromium-review.googlesource.com/923443
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537237}
[modify] https://crrev.com/9f05e9b361d4179ebb9456f9eaf851a96bfbd230/third_party/WebKit/Source/core/dom/FlatTreeTraversal.h
[modify] https://crrev.com/9f05e9b361d4179ebb9456f9eaf851a96bfbd230/third_party/WebKit/Source/core/dom/FlatTreeTraversalTest.cpp

Project Member

Comment 18 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/122362823284a913e64f2a60dc3a4691d5dce810

commit 122362823284a913e64f2a60dc3a4691d5dce810
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Mon Feb 19 07:36:30 2018

Introduce test cases for PreviousWordPosition()

This patch introduces test cases for |PreviousWordPosition()| to record current
behavior as a preparation of the patch[1].

Note: The patch[2] introduces test case for |NextWordPosition()|.

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection
[2] http://crrev.com/c/895236 Introduce test cases for NextWordPosition()

Bug: 778507
Change-Id: Ie1b3933336ddd9d6afca246700a9f7e9a588d61d
Reviewed-on: https://chromium-review.googlesource.com/923686
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537595}
[modify] https://crrev.com/122362823284a913e64f2a60dc3a4691d5dce810/third_party/WebKit/Source/core/editing/VisibleUnits.h
[modify] https://crrev.com/122362823284a913e64f2a60dc3a4691d5dce810/third_party/WebKit/Source/core/editing/VisibleUnitsWordTest.cpp

Project Member

Comment 19 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47080ffd267b8db3d5cd9633f91c6d99919cd4ba

commit 47080ffd267b8db3d5cd9633f91c6d99919cd4ba
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Mar 22 10:03:34 2018

Introduce FindWord{Back,For}ward()

This patch introduces |FindWordBackward()| and |FindWordForward()| for a
preparation of the patch[1].

[1] http://crrev.com/c/737981 Simplify word granularity handling

Bug: 778507
Change-Id: I405683cd07a0dc3a5f8cc26c307e1d980dcb2961
Reviewed-on: https://chromium-review.googlesource.com/970191
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545030}
[modify] https://crrev.com/47080ffd267b8db3d5cd9633f91c6d99919cd4ba/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/47080ffd267b8db3d5cd9633f91c6d99919cd4ba/third_party/WebKit/Source/platform/text/TextBoundaries.cpp
[modify] https://crrev.com/47080ffd267b8db3d5cd9633f91c6d99919cd4ba/third_party/WebKit/Source/platform/text/TextBoundaries.h
[add] https://crrev.com/47080ffd267b8db3d5cd9633f91c6d99919cd4ba/third_party/WebKit/Source/platform/text/TextBoundariesTest.cpp

Project Member

Comment 20 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec91713175f2e38e14df515cfb444bbe80e16d18

commit ec91713175f2e38e14df515cfb444bbe80e16d18
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Mon Mar 26 08:07:23 2018

Record current behavior of NGInlineNode::CollectInlines() with inline-block and float

This patch introduces tests for hanling of "inline-block" and "float" of
|NGInlineNode::CollectInlines()| to avoid regression for improving code health.

This patch is a preparation the patch[1].

[1] http://crrev.com/c/737981 Simplify word granularity handling

Bug: 778507
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ifead65d6df83a19dbe2b82b509ef39427b56962c
Reviewed-on: https://chromium-review.googlesource.com/979751
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545735}
[modify] https://crrev.com/ec91713175f2e38e14df515cfb444bbe80e16d18/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node_test.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30da1aa45b5c2ce0be750da81c9ac4f0980cfd04

commit 30da1aa45b5c2ce0be750da81c9ac4f0980cfd04
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Tue Mar 27 03:17:55 2018

Record current behavior of TextIterator with inline-block and float

This patch introduces tests for hanling of "inline-block" and "float" of
|TextIterator| to avoid regression for improving code health.

This patch is a preparation the patch[1].

[1] http://crrev.com/c/737981 Simplify word granularity handling

Bug: 778507
Change-Id: I9259afac827cbfdd95a60da7d10c9e0844235e54
Reviewed-on: https://chromium-review.googlesource.com/979748
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545949}
[modify] https://crrev.com/30da1aa45b5c2ce0be750da81c9ac4f0980cfd04/third_party/WebKit/Source/core/editing/iterators/TextIteratorTest.cpp

Project Member

Comment 22 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0421bf02d3c157ddb314f392b6f16589a2faa4e

commit b0421bf02d3c157ddb314f392b6f16589a2faa4e
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Tue Apr 03 08:47:49 2018

Introduce TextOffsetMapping class for text segment handling

This patch Introduces |TextOffsetMapping|[1] class to mapping between character
offset in block and DOM position for ease of implementing selection modification
with text segments, such as word/sentence/paragraph.

This patch is a preparation of the patch[2].

[1] https://goo.gl/v2Ax8d Text Offset Mapping
[2] http://crrev.com/c/737981 Simplify word granularity handling

Bug: 778507
Change-Id: I63957165ab2741d5c3f1e2b1d29302541d12841b
Reviewed-on: https://chromium-review.googlesource.com/983336
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547651}
[modify] https://crrev.com/b0421bf02d3c157ddb314f392b6f16589a2faa4e/third_party/WebKit/Source/core/editing/BUILD.gn
[add] https://crrev.com/b0421bf02d3c157ddb314f392b6f16589a2faa4e/third_party/WebKit/Source/core/editing/TextOffsetMapping.cpp
[add] https://crrev.com/b0421bf02d3c157ddb314f392b6f16589a2faa4e/third_party/WebKit/Source/core/editing/TextOffsetMapping.h
[add] https://crrev.com/b0421bf02d3c157ddb314f392b6f16589a2faa4e/third_party/WebKit/Source/core/editing/TextOffsetMappingTest.cpp
[modify] https://crrev.com/b0421bf02d3c157ddb314f392b6f16589a2faa4e/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp
[modify] https://crrev.com/b0421bf02d3c157ddb314f392b6f16589a2faa4e/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.h

Project Member

Comment 23 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1324be868df000cb2e070199ce2d10cd0c5a2706

commit 1324be868df000cb2e070199ce2d10cd0c5a2706
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Thu Apr 12 08:30:26 2018

Make NextWordPosition() to utilize TextOffsetMapping

This patch changes |NextWordPosition()| to utilize |TextOffsetMapping| to make
|NextWordPosition()| to work with LayoutNG.

This patch is a part of the patch[1].

[1] http://crrev.com/c/737981 Simplify word granularity handling

Bug: 778507, 810579

Change-Id: I7e196b0ee390d68b93f2494333554279d6fbd42d
Reviewed-on: https://chromium-review.googlesource.com/1004536
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550106}
[modify] https://crrev.com/1324be868df000cb2e070199ce2d10cd0c5a2706/third_party/blink/renderer/core/editing/visible_units_word.cc
[modify] https://crrev.com/1324be868df000cb2e070199ce2d10cd0c5a2706/third_party/blink/renderer/core/editing/visible_units_word_test.cc

Comment 24 by yosin@chromium.org, Apr 19 2018

Blockedon: 834623
Project Member

Comment 25 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/288e1d95df6c7c88182bf51f37c903f79268b737

commit 288e1d95df6c7c88182bf51f37c903f79268b737
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Mon Apr 23 03:32:36 2018

Make CharacterIterator::GetPosition{After,Before}() to work with BR

This patch makes |CharacterIterator::GetPosition{After,Before}()| to work with
BR.

Before this patch, |GetPosition{After,Before}()| return after/before BODY
instead after/before BR in CharacterIteratorTest.GetPositionWithBR, because
|TextIterator::CurrentContainer()| returns BODY.

Bug: 778507
Change-Id: Id0acfd71d7b563680e16aa49919998ce9e7f64fb
Reviewed-on: https://chromium-review.googlesource.com/1021430
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552627}
[modify] https://crrev.com/288e1d95df6c7c88182bf51f37c903f79268b737/third_party/blink/renderer/core/editing/iterators/character_iterator.cc
[modify] https://crrev.com/288e1d95df6c7c88182bf51f37c903f79268b737/third_party/blink/renderer/core/editing/iterators/character_iterator_test.cc

Project Member

Comment 26 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6535528f00c742b6cb9dcce8e46567048ac0dadc

commit 6535528f00c742b6cb9dcce8e46567048ac0dadc
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Tue May 29 04:05:29 2018

Make EndOfSentence() to utilize TextOffsetMapping

This patch changes |EndOfSentence()| to utilize |TextOffsetMapping| to make
|EndOfSentence()| to work with LayoutNG by introducing |FindBoundaryForward()|
to share logic with |NextWordPosition()|.

Because of |TextOffsetMapping| traverses flat tree, DOM tree version of
|EndOfSentence()| works as same as flat tree version.

Bug: 778507, 810579
Change-Id: Ib3e2ad8aa4a0e8b8657a0363c2f3e3da8355eae3
Reviewed-on: https://chromium-review.googlesource.com/1009346
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562334}
[modify] https://crrev.com/6535528f00c742b6cb9dcce8e46567048ac0dadc/third_party/blink/renderer/core/editing/visible_units.cc
[modify] https://crrev.com/6535528f00c742b6cb9dcce8e46567048ac0dadc/third_party/blink/renderer/core/editing/visible_units.h
[modify] https://crrev.com/6535528f00c742b6cb9dcce8e46567048ac0dadc/third_party/blink/renderer/core/editing/visible_units_sentence.cc
[modify] https://crrev.com/6535528f00c742b6cb9dcce8e46567048ac0dadc/third_party/blink/renderer/core/editing/visible_units_sentence_test.cc
[modify] https://crrev.com/6535528f00c742b6cb9dcce8e46567048ac0dadc/third_party/blink/renderer/core/editing/visible_units_word.cc

Project Member

Comment 27 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ea45774b43642488abee6688f0ac328903c2400

commit 6ea45774b43642488abee6688f0ac328903c2400
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Fri Jun 01 12:49:37 2018

Introduce TextSegments class with Finder interface

This patch introduces |TextSegments| class with |Finder| interface as
replacement of |FindBoundaryForwrad()| and |FindBoundaryBackward()| along with
call sites, to implementing sentence boundary function with state instead of
|std::function<>|.

This patch also changes |TextOffsetMapping::GetPositionAfter()| to return
correct value.

This patch is a preparation of the patch[1].

[1] http://crrev.com/c/1075918 Make NextSentencePosition() to utilize
TextOffsetMapping

Bug: 778507, 810579
Change-Id: I56c6d08589740709cfe1a4d7281274f2f56fbac6
Reviewed-on: https://chromium-review.googlesource.com/1078167
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563599}
[modify] https://crrev.com/6ea45774b43642488abee6688f0ac328903c2400/third_party/blink/renderer/core/editing/BUILD.gn
[modify] https://crrev.com/6ea45774b43642488abee6688f0ac328903c2400/third_party/blink/renderer/core/editing/text_offset_mapping.cc
[modify] https://crrev.com/6ea45774b43642488abee6688f0ac328903c2400/third_party/blink/renderer/core/editing/text_offset_mapping_test.cc
[add] https://crrev.com/6ea45774b43642488abee6688f0ac328903c2400/third_party/blink/renderer/core/editing/text_segments.cc
[add] https://crrev.com/6ea45774b43642488abee6688f0ac328903c2400/third_party/blink/renderer/core/editing/text_segments.h
[modify] https://crrev.com/6ea45774b43642488abee6688f0ac328903c2400/third_party/blink/renderer/core/editing/visible_units.cc
[modify] https://crrev.com/6ea45774b43642488abee6688f0ac328903c2400/third_party/blink/renderer/core/editing/visible_units.h
[modify] https://crrev.com/6ea45774b43642488abee6688f0ac328903c2400/third_party/blink/renderer/core/editing/visible_units_sentence.cc
[modify] https://crrev.com/6ea45774b43642488abee6688f0ac328903c2400/third_party/blink/renderer/core/editing/visible_units_word.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4040a4d9004dd3258db0b9abea5c66757987bb5e

commit 4040a4d9004dd3258db0b9abea5c66757987bb5e
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Mon Jun 04 07:56:13 2018

Make NextSentencePosition() to utilize TextSegments class

This patch changes |NextSentencePosition()| to utilize |TextSegments| class
to make |NextSentencePosition()| to work with LayoutNG.

Bug: 778507, 810579
Change-Id: If750dec03584cd1e5631fd37d1ab6516d5963eb3
Reviewed-on: https://chromium-review.googlesource.com/1075918
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564012}
[modify] https://crrev.com/4040a4d9004dd3258db0b9abea5c66757987bb5e/third_party/blink/renderer/core/editing/visible_units_sentence.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c063974c76f9579fbccd11f6939dffaf8ca26055

commit c063974c76f9579fbccd11f6939dffaf8ca26055
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Wed Jun 06 09:52:11 2018

Make EndOfWordPosition() to utilize TextSegments class

This patch changes |EndOfWordPosition()| to utilize |TextSegments| class
to make |EndOfWordPosition()| to work with LayoutNG.

This patch also changes |GranularityAdjuster| to handle end of word position in
flat tree mapped before start of word position in DOM tree.

This patch changes following test expectations:
* third_party/WebKit/LayoutTests/fast/text/international/cjk-segmentation.html
|TextSegments| provides more context characters to ICU word breaker.
* VisibleSelectionTest.expandUsingGranularity
* ParameterizedVisibleUnitsWordTest.EndOfWordShadowDOM
Due by |PositionInFlatTree| to |Position| conversion.

Bug: 778507, 810579
Change-Id: Ie888f8b76e00386bc728a5c647aecf8f33ef7b6e
Reviewed-on: https://chromium-review.googlesource.com/1086811
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564839}
[modify] https://crrev.com/c063974c76f9579fbccd11f6939dffaf8ca26055/third_party/WebKit/LayoutTests/fast/text/international/cjk-segmentation.html
[modify] https://crrev.com/c063974c76f9579fbccd11f6939dffaf8ca26055/third_party/blink/renderer/core/editing/selection_adjuster.cc
[modify] https://crrev.com/c063974c76f9579fbccd11f6939dffaf8ca26055/third_party/blink/renderer/core/editing/visible_selection_test.cc
[modify] https://crrev.com/c063974c76f9579fbccd11f6939dffaf8ca26055/third_party/blink/renderer/core/editing/visible_units.h
[modify] https://crrev.com/c063974c76f9579fbccd11f6939dffaf8ca26055/third_party/blink/renderer/core/editing/visible_units_word.cc
[modify] https://crrev.com/c063974c76f9579fbccd11f6939dffaf8ca26055/third_party/blink/renderer/core/editing/visible_units_word_test.cc

Blocking: 886589
Project Member

Comment 31 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/350228ed5cd0e43c4ce2a5a04fe58eb86f5270e8

commit 350228ed5cd0e43c4ce2a5a04fe58eb86f5270e8
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Wed Oct 31 04:31:59 2018

Make PreviousWordPosition() utilitize TextSegments class

This patch changes |PreviousWordPosition()| to utilize |TextSegments|
class to make |PreviousWordPosition()| work with LayoutNG.

This patch also reveals an existing bug (or feature?) in editing
boundary adjustments, as shown in the changed layout test.

Bug: 778507, 900060
Change-Id: Ic797c960715576dc85a946a7b34b0be568c19805
Reviewed-on: https://chromium-review.googlesource.com/c/1307056
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604152}
[modify] https://crrev.com/350228ed5cd0e43c4ce2a5a04fe58eb86f5270e8/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/350228ed5cd0e43c4ce2a5a04fe58eb86f5270e8/third_party/WebKit/LayoutTests/editing/selection/mixed-editability-8.html
[modify] https://crrev.com/350228ed5cd0e43c4ce2a5a04fe58eb86f5270e8/third_party/blink/renderer/core/editing/text_segments.cc
[modify] https://crrev.com/350228ed5cd0e43c4ce2a5a04fe58eb86f5270e8/third_party/blink/renderer/core/editing/text_segments.h
[modify] https://crrev.com/350228ed5cd0e43c4ce2a5a04fe58eb86f5270e8/third_party/blink/renderer/core/editing/visible_units_word.cc
[modify] https://crrev.com/350228ed5cd0e43c4ce2a5a04fe58eb86f5270e8/third_party/blink/renderer/core/editing/visible_units_word_test.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d2b731cfd6e12c9fcf2cdbddca59243d716e228

commit 3d2b731cfd6e12c9fcf2cdbddca59243d716e228
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Tue Nov 13 23:04:21 2018

Make StartOfWord() utilitize TextSegments class

This patch changes |StartOfWord()| to utilize |TextSegments|
class to make it work with LayoutNG.

This patch also fixes existing incorrect behavior on
fast/text/international/cjk-segmentation.html

Bug: 778507
Change-Id: Iedee4632206154c8e813f3e43136c1a000e39435
Reviewed-on: https://chromium-review.googlesource.com/c/1309227
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607796}
[modify] https://crrev.com/3d2b731cfd6e12c9fcf2cdbddca59243d716e228/third_party/WebKit/LayoutTests/fast/text/international/cjk-segmentation.html
[modify] https://crrev.com/3d2b731cfd6e12c9fcf2cdbddca59243d716e228/third_party/blink/renderer/core/editing/visible_selection_test.cc
[modify] https://crrev.com/3d2b731cfd6e12c9fcf2cdbddca59243d716e228/third_party/blink/renderer/core/editing/visible_units.h
[modify] https://crrev.com/3d2b731cfd6e12c9fcf2cdbddca59243d716e228/third_party/blink/renderer/core/editing/visible_units_word.cc
[modify] https://crrev.com/3d2b731cfd6e12c9fcf2cdbddca59243d716e228/third_party/blink/renderer/core/editing/visible_units_word_test.cc

Project Member

Comment 33 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29ca362336b4e89e49000ed5e24f0e0ba983bb3b

commit 29ca362336b4e89e49000ed5e24f0e0ba983bb3b
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Thu Nov 15 05:08:20 2018

Make fast/dom/Range/range-expand.html match its intention

The layout test has a "multiline" test case which isn't really multiline,
as the linebreak characters in HTML are turned into whitespaces.

This patch changes the <p> element into <pre> so that the linebreak
characters are really breaking text into lines, and the test case is a
multiline test case.

This patch is a preparation for changing StartOfSentence() to use
TextOffsetMapping (crrev.com/c/1335959).

Bug: 778507
Change-Id: I77cd48eb13a1ff442e7ecbe1c71819055bccf078
Reviewed-on: https://chromium-review.googlesource.com/c/1336785
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608263}
[modify] https://crrev.com/29ca362336b4e89e49000ed5e24f0e0ba983bb3b/third_party/WebKit/LayoutTests/fast/dom/Range/range-expand.html

Project Member

Comment 34 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c60e4f57baf085d992f39c0e4a0c4bf02a797b7

commit 0c60e4f57baf085d992f39c0e4a0c4bf02a797b7
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Thu Nov 15 17:48:48 2018

Make StartOfSentence utilize TextSegments class

This patch changes |StartOfSentence()| to utilize |TextSegments|
class to make it work with LayoutNG.

Bug: 778507
Change-Id: I462e99f3a3c5cf84dfeab67cc324d985478ed570
Reviewed-on: https://chromium-review.googlesource.com/c/1335959
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608422}
[modify] https://crrev.com/0c60e4f57baf085d992f39c0e4a0c4bf02a797b7/third_party/blink/renderer/core/editing/visible_units_sentence.cc
[modify] https://crrev.com/0c60e4f57baf085d992f39c0e4a0c4bf02a797b7/third_party/blink/renderer/core/editing/visible_units_sentence_test.cc

Project Member

Comment 35 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aee1ee31da3be29fe241265b39ed05c45f4d49d4

commit aee1ee31da3be29fe241265b39ed05c45f4d49d4
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Fri Nov 16 18:02:39 2018

Make EndOfSentence stop at block boundaries

This patch stops EndOfSentence from crossing block boundaries, since
block boundaries are also sentence boundaries.

Bug: 778507
Change-Id: I19ec97de1bbaac50db4c55b38ffb158339003993
Reviewed-on: https://chromium-review.googlesource.com/c/1337432
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608850}
[modify] https://crrev.com/aee1ee31da3be29fe241265b39ed05c45f4d49d4/third_party/WebKit/LayoutTests/fast/dom/Range/range-expand.html
[modify] https://crrev.com/aee1ee31da3be29fe241265b39ed05c45f4d49d4/third_party/blink/renderer/core/editing/visible_units_sentence.cc

Project Member

Comment 36 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/148c350663e65a1fd8707251d4aaea1498266767

commit 148c350663e65a1fd8707251d4aaea1498266767
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Mon Nov 19 10:11:34 2018

Revert "Make EndOfSentence stop at block boundaries"

This reverts commit aee1ee31da3be29fe241265b39ed05c45f4d49d4.

Reason for revert: Suspect this CL caused https://bugs.chromium.org/p/monorail/issues/detail?id=4576

Original change's description:
> Make EndOfSentence stop at block boundaries
> 
> This patch stops EndOfSentence from crossing block boundaries, since
> block boundaries are also sentence boundaries.
> 
> Bug: 778507
> Change-Id: I19ec97de1bbaac50db4c55b38ffb158339003993
> Reviewed-on: https://chromium-review.googlesource.com/c/1337432
> Reviewed-by: Yoichi Osato <yoichio@chromium.org>
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608850}

TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 778507
Change-Id: I7d48146bd7fb27c34427f543ad3b54443ae63715
Reviewed-on: https://chromium-review.googlesource.com/c/1340815
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609224}
[modify] https://crrev.com/148c350663e65a1fd8707251d4aaea1498266767/third_party/WebKit/LayoutTests/fast/dom/Range/range-expand.html
[modify] https://crrev.com/148c350663e65a1fd8707251d4aaea1498266767/third_party/blink/renderer/core/editing/visible_units_sentence.cc

Project Member

Comment 37 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58cb97c41c7eec5a2e98ebe646aa4a22724b848c

commit 58cb97c41c7eec5a2e98ebe646aa4a22724b848c
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Wed Nov 21 22:46:15 2018

Make PreviousSentencePosition utilize TextSegments class

This patch changes |PreviousSentencePosition()| to utilize
|TextSegments| class to make it work with LayoutNG.

Since the original implementation is a duplicate of
|StartOfSentence|, so is the new implementation.

Bug: 778507
Change-Id: I7ba9fe19c74ff87c121d6c2bfce7f28765976ca1
Reviewed-on: https://chromium-review.googlesource.com/c/1337282
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610244}
[modify] https://crrev.com/58cb97c41c7eec5a2e98ebe646aa4a22724b848c/third_party/blink/renderer/core/editing/visible_units_sentence.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4744148709b055982d2acda22a86a27e3083ace

commit b4744148709b055982d2acda22a86a27e3083ace
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Fri Nov 23 21:40:20 2018

Reland "Make EndOfSentence stop at block boundaries"

This reverts commit 148c350663e65a1fd8707251d4aaea1498266767.

Reason for reland: The original patch is not the cause of
test failure. Test still fails after the revert:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Win10/43312

Original change's description:
> Revert "Make EndOfSentence stop at block boundaries"
>
> This reverts commit aee1ee31da3be29fe241265b39ed05c45f4d49d4.
>
> Reason for revert: Suspect this CL caused https://bugs.chromium.org/p/monorail/issues/detail?id=4576
>
> Original change's description:
> > Make EndOfSentence stop at block boundaries
> >
> > This patch stops EndOfSentence from crossing block boundaries, since
> > block boundaries are also sentence boundaries.
> >
> > Bug: 778507
> > Change-Id: I19ec97de1bbaac50db4c55b38ffb158339003993
> > Reviewed-on: https://chromium-review.googlesource.com/c/1337432
> > Reviewed-by: Yoichi Osato <yoichio@chromium.org>
> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#608850}
>
> TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 778507
> Change-Id: I7d48146bd7fb27c34427f543ad3b54443ae63715
> Reviewed-on: https://chromium-review.googlesource.com/c/1340815
> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609224}

TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org,kolos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 778507
Change-Id: If89bc2d7b9379af17dd326d92f9eb6e31d5d78f8
Reviewed-on: https://chromium-review.googlesource.com/c/1347032
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610673}
[modify] https://crrev.com/b4744148709b055982d2acda22a86a27e3083ace/third_party/WebKit/LayoutTests/fast/dom/Range/range-expand.html
[modify] https://crrev.com/b4744148709b055982d2acda22a86a27e3083ace/third_party/blink/renderer/core/editing/visible_units_sentence.cc

Project Member

Comment 39 by bugdroid1@chromium.org, Nov 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7f4f01e0c96c7d4f0b68cb70de0afe4b97e16b2

commit c7f4f01e0c96c7d4f0b68cb70de0afe4b97e16b2
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Sat Nov 24 18:44:21 2018

Remove obsolete PreviousBoundary

PreviousBoundary is the legacy utility function for word and sentence
boundary algorithms. This patch removes it as it now doesn't have any
usage.

Bug: 778507
Change-Id: I3792d1786867b3e68549267bba36d4ad54263dc2
Reviewed-on: https://chromium-review.googlesource.com/c/1337284
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610707}
[modify] https://crrev.com/c7f4f01e0c96c7d4f0b68cb70de0afe4b97e16b2/third_party/blink/renderer/core/editing/visible_units.cc
[modify] https://crrev.com/c7f4f01e0c96c7d4f0b68cb70de0afe4b97e16b2/third_party/blink/renderer/core/editing/visible_units.h

Sign in to add a comment