New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778497 link

Starred by 11 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 810117



Sign in to add a comment

FetchEvent.resultingClientId

Project Member Reported by falken@chromium.org, Oct 26 2017

Issue description

There is interest in having a kind of client id for fetch events for navigations. Right now clientId is null since there is no client yet.

The idea is to have a reservedClientId that will become the client ID if the navigation is successful.

This is related to  issue 514148  but rather than the full-blown reserved client, this bug is about just exposing an ID.

I'm investigating the current spec and implementation.
 

Comment 1 by falken@chromium.org, Oct 26 2017

The most recent spec discussion appears to be:
https://github.com/w3c/ServiceWorker/issues/1091

See especially:
https://github.com/w3c/ServiceWorker/issues/1091#issuecomment-311023682

* clientId - the client that initiates the request.
* resultingClientId - the potentially-reserved client that will house the resulting document/worker.
* targetClientId - an existing client that will be replaced, or have its document replaced.

We're interested in resultingClientId.

Comment 2 by falken@chromium.org, Oct 26 2017

There are WIP tests at https://github.com/w3c/web-platform-tests/pull/6343

Comment 3 by falken@chromium.org, Oct 26 2017

I synced with Jungkee. The spec discussions are still progressing but the basic idea of reservedClientId is aligned. #1091 is the issue for discussion.

Implementation-wise it looks pretty simple at least in the PlzNavigate world. We already have a ServiceWorkerProviderHost for the navigation and in fact the browser process passes the client ID down to the renderer and into Blink. Then in ServiceWorkerGlobalScopeProxy::DispatchFetchEvent we avoid using the client id for navigations:

  event_init.setClientId(
      web_request.IsMainResourceLoad() ? WebString() : web_request.ClientId());

So we'll just have to expose ClientId as reservedClientId once the spec finishes.

I'm not too sure what the behavior of Clients.get(id) and Clients.matchAll() would be. The spec provides an includeReserved flag, but I'd rather avoid implementing that unless necessary.

Comment 4 by falken@chromium.org, Oct 26 2017

In the current implementation, Clients.get(id) and Clients.matchAll() from within the fetch event won't be able to get the reserved client, because the ProviderHost isn't added to ContextCore until the OnProviderCreated IPC is sent from the renderer, which happens after the navigation is committed.

Comment 5 by falken@chromium.org, Oct 26 2017

I started on some WPT tests here:
https://chromium-review.googlesource.com/c/chromium/src/+/737396

The actual impl shouldn't be too bad, if we just make it so clients.get(reservedClientId) returns undefined and matchAll doesn't return the reserved client.
I believe this would work for the partners who have been asking for this. Let's confirm at the next sync-up.
If I'm following this correctly, it sounds like reserved Client ID will be exposed as the client ID for the initial navigation event but won't be visible from Clients.get()/matchAll(). If so, that works for us.

Comment 8 by bke...@mozilla.com, Nov 13 2017

I believe at TPAC we agreed the reserved id would be exposed and Clients.get() would not resolve until the Client is created.  A Clients.matchAll() will not include reserved Client objects.

Also, I think we agreed to rename FetchEvent.reservedClientId to FetchEvent.resultingClientId.  Sometimes resultingClientId will be reserved and sometimes it will be an active Client.  You get an active client id in the initial about:blank case where the global is created early and re-used for the final document load.

Comment 9 by leon....@intel.com, Dec 13 2017

Cc: falken@chromium.org
Owner: ----
Status: Started (was: Assigned)
I'd like to start the implementation for Chrome.

Comment 10 by bke...@mozilla.com, Dec 13 2017

> I'd like to start the implementation for Chrome.

Just curious from an interop perspective, but what parts of this are you planning to tackle?  I can think of a few separate parts here:

1. Exposing FetchEvent.resultingClientId
2. Exposing FetchEvent.targetClientId
3. Making Clients.get() delay resolving its promise until the client is marked execution ready
4. Exposing initial about:blank windows as execution ready clients

I put (4) in there because it effects what sites will see with `Clients.get(evt.resultingClientId)`.

Thanks.  Just trying to figure out priority for implement on our end.

Comment 11 by leon....@intel.com, Dec 14 2017

Owner: leon....@intel.com
bkelly@: Ah, I meant that I'll take this issue ;-) And I'm still looking through all the related discussions and investigating the current behavior/impl of Chrome, to find out a clear path to get all done. Thanks you very much for the suggestions about the above separated steps, and I'll keep updating my findings/questions/plans here.
Cc: leon....@intel.com
Owner: ----
Status: Available (was: Started)
Summary: FetchEvent.resultingClientId (was: FetchEvent.reservedClientId)
Updating labels.

Regarding c#10, the plan is to do at least (1) and (3) at the same time. (2) and (4) might come later.
Cc: jimmyshen@google.com
Owner: jimmyshen@google.com
Going to take a stab at this.
Cc: michaeln@chromium.org nhiroki@chromium.org mlamouri@chromium.org
 Issue 514148  has been merged into this issue.
Status: Assigned (was: Available)
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f265d393a6510995bca20dd2bb361b6ee6d5d0b

commit 4f265d393a6510995bca20dd2bb361b6ee6d5d0b
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Sep 04 09:51:44 2018

WPT: More refactoring navigation-redirect.https.html

This makes the test more extensible. Preparation for adding tests for
the Clients API and resultingClientId. Specifically, the requestInfos
from the workers and the expectations will have a resultingClientId
in addition to the URL.

Bug: 876223,  778497 
Change-Id: Id7c25a77f43f33d40b64ea77c2cf51a0745f57c6
Reviewed-on: https://chromium-review.googlesource.com/1203711
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588479}
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/redirected-response.https.html
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-other-origin.html
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/redirect-worker.js

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f265d393a6510995bca20dd2bb361b6ee6d5d0b

commit 4f265d393a6510995bca20dd2bb361b6ee6d5d0b
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Sep 04 09:51:44 2018

WPT: More refactoring navigation-redirect.https.html

This makes the test more extensible. Preparation for adding tests for
the Clients API and resultingClientId. Specifically, the requestInfos
from the workers and the expectations will have a resultingClientId
in addition to the URL.

Bug: 876223,  778497 
Change-Id: Id7c25a77f43f33d40b64ea77c2cf51a0745f57c6
Reviewed-on: https://chromium-review.googlesource.com/1203711
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588479}
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/redirected-response.https.html
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-other-origin.html
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/redirect-worker.js

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f265d393a6510995bca20dd2bb361b6ee6d5d0b

commit 4f265d393a6510995bca20dd2bb361b6ee6d5d0b
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Sep 04 09:51:44 2018

WPT: More refactoring navigation-redirect.https.html

This makes the test more extensible. Preparation for adding tests for
the Clients API and resultingClientId. Specifically, the requestInfos
from the workers and the expectations will have a resultingClientId
in addition to the URL.

Bug: 876223,  778497 
Change-Id: Id7c25a77f43f33d40b64ea77c2cf51a0745f57c6
Reviewed-on: https://chromium-review.googlesource.com/1203711
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588479}
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/redirected-response.https.html
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-other-origin.html
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/redirect-worker.js

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/398ba6bd4e98ca437d05274df6bd6ac5deb87276

commit 398ba6bd4e98ca437d05274df6bd6ac5deb87276
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Sep 19 10:47:49 2018

service worker: Add WPT tests for resultingClientId.

This adds a ?client variant to navigation-redirect.https.html, which
does a lot of redirect tests. This tests the following:
- resultingClientId is the id of the client, if one was created via
  that request.
- get(resultingClientId) for requests that did not create a client
  resolves with undefined.
- resultingClientId is reset on cross-origin redirects.
- Client.url is the creation URL.

Bug:  778497 
Change-Id: I08387e96a97df4656d800637862b67b7c8466e14
Reviewed-on: https://chromium-review.googlesource.com/1206054
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592363}
[modify] https://crrev.com/398ba6bd4e98ca437d05274df6bd6ac5deb87276/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt
[modify] https://crrev.com/398ba6bd4e98ca437d05274df6bd6ac5deb87276/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html
[add] https://crrev.com/398ba6bd4e98ca437d05274df6bd6ac5deb87276/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https_client-expected.txt
[modify] https://crrev.com/398ba6bd4e98ca437d05274df6bd6ac5deb87276/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-other-origin.html
[modify] https://crrev.com/398ba6bd4e98ca437d05274df6bd6ac5deb87276/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/redirect-worker.js

Project Member

Comment 21 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d8287d0d1002fc3cbb9a66d3039eecda6d151e2

commit 0d8287d0d1002fc3cbb9a66d3039eecda6d151e2
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Sep 26 02:38:15 2018

Revert "service worker: Add WPT tests for resultingClientId."

This reverts commit 398ba6bd4e98ca437d05274df6bd6ac5deb87276.

Reason for revert: Flakily times out.

Original change's description:
> service worker: Add WPT tests for resultingClientId.
> 
> This adds a ?client variant to navigation-redirect.https.html, which
> does a lot of redirect tests. This tests the following:
> - resultingClientId is the id of the client, if one was created via
>   that request.
> - get(resultingClientId) for requests that did not create a client
>   resolves with undefined.
> - resultingClientId is reset on cross-origin redirects.
> - Client.url is the creation URL.
> 
> Bug:  778497 
> Change-Id: I08387e96a97df4656d800637862b67b7c8466e14
> Reviewed-on: https://chromium-review.googlesource.com/1206054
> Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592363}

TBR=falken@chromium.org,shimazu@chromium.org,wanderview@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  778497 ,  889307 
Change-Id: I21b3d7fd684c879f4f8f11d5b8fb9b69d8bba3a6
Reviewed-on: https://chromium-review.googlesource.com/1244178
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594193}
[modify] https://crrev.com/0d8287d0d1002fc3cbb9a66d3039eecda6d151e2/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt
[modify] https://crrev.com/0d8287d0d1002fc3cbb9a66d3039eecda6d151e2/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html
[delete] https://crrev.com/50670cfe6b0cb951a65e5dc58daf9c165fcf9911/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https_client-expected.txt
[modify] https://crrev.com/0d8287d0d1002fc3cbb9a66d3039eecda6d151e2/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-other-origin.html
[modify] https://crrev.com/0d8287d0d1002fc3cbb9a66d3039eecda6d151e2/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/redirect-worker.js

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f328a7f306ae64c0af4f2a4cb5da7f3214f6fc7

commit 4f328a7f306ae64c0af4f2a4cb5da7f3214f6fc7
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Sep 27 15:02:01 2018

WPT: service worker: Fix potential race in navigation-redirect.https.html.

Before this CL, the test makes a frame which posts a message to the test
window. But if the test fails, we might not consume the message with
`await` and move on the next test. It's possible the next test gets an
unexpected message from the previous test.

I think a related issue caused the timeout after the Clients variant was
added to the test, since the message handler was created after the frame
was created and it was possible the message arrived after that.

Fix things by explicitly asking the frame for the message when we're
ready for it.

Bug: 876223,  778497 
Change-Id: I82b8685df2977aeadea7475965ecccf69bd33111
Reviewed-on: https://chromium-review.googlesource.com/1249423
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594723}
[modify] https://crrev.com/4f328a7f306ae64c0af4f2a4cb5da7f3214f6fc7/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html
[modify] https://crrev.com/4f328a7f306ae64c0af4f2a4cb5da7f3214f6fc7/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-out-scope.py
[modify] https://crrev.com/4f328a7f306ae64c0af4f2a4cb5da7f3214f6fc7/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-scope1.py
[modify] https://crrev.com/4f328a7f306ae64c0af4f2a4cb5da7f3214f6fc7/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-scope2.py

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/238d82b2384cfebd56a2660c1ae68e1f615f987a

commit 238d82b2384cfebd56a2660c1ae68e1f615f987a
Author: Matt Falkenhagen <falken@chromium.org>
Date: Fri Sep 28 23:37:07 2018

Reland: service worker: Add WPT tests for resultingClientId.

Reland of r592363, which was reverted due to timeouts. The timeout issue
should be fixed by r594723, which changed the mechanism of sending the
"last url" message from the navigated frame.

Other revisions from the original patch:
- Removed the unused expected_tags parameter from the default
  variant test function.
- Removed the dummy message resolver for "last url" from
  client_variant_test, which is no longer needed after the change
  mentioned above.
- Fixed a bug in redirect-worker.js's getClients(), where
  we returned instead of continued to the next iteration.

Original commit description:
> This adds a ?client variant to navigation-redirect.https.html, which
> does a lot of redirect tests. This tests the following:
> - resultingClientId is the id of the client, if one was created via
>   that request.
> - get(resultingClientId) for requests that did not create a client
>   resolves with undefined.
> - resultingClientId is reset on cross-origin redirects.
> - Client.url is the creation URL.
>
> Bug:  778497 
> Change-Id: I08387e96a97df4656d800637862b67b7c8466e14
> Reviewed-on: https://chromium-review.googlesource.com/1206054
> Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592363}

Bug:  778497 
Change-Id: I770f98cef7618c89c1b54245bc89a9c53a19bd5c
Reviewed-on: https://chromium-review.googlesource.com/1250306
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595249}
[modify] https://crrev.com/238d82b2384cfebd56a2660c1ae68e1f615f987a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt
[modify] https://crrev.com/238d82b2384cfebd56a2660c1ae68e1f615f987a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html
[add] https://crrev.com/238d82b2384cfebd56a2660c1ae68e1f615f987a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https_client-expected.txt
[modify] https://crrev.com/238d82b2384cfebd56a2660c1ae68e1f615f987a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-other-origin.html
[modify] https://crrev.com/238d82b2384cfebd56a2660c1ae68e1f615f987a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/redirect-worker.js

Cc: -falken@chromium.org
Labels: -Pri-2 Target-72 Pri-1
Owner: falken@chromium.org
Owner: nhiroki@chromium.org
Blocking: 810117
Owner: shimazu@chromium.org
Summary of work up till now.
- WPT for redirects landed at navigation-redirect.https.html?client via https://chromium-review.googlesource.com/c/chromium/src/+/1250306/
- There are some more WIP WPT at: https://chromium- review.googlesource.com/c/chromium/src/+/737396
- Jimmy had a WIP implementation patch at https://chromium-review.googlesource.com/c/chromium/src/+/1053431
Project Member

Comment 29 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81b9c9974aa4ce57577df56c16249160e1f6dcb4

commit 81b9c9974aa4ce57577df56c16249160e1f6dcb4
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Wed Nov 14 23:32:38 2018

Fix wpt: service-worker/navigation-redirect.https.html

As preparation for adding FetchEvent#resultingClientId, this CL fixes
the test to make it pass once resultingClientId is impelmeneted.

Bug:  778497 
Change-Id: I6309a13d4315e6a99149275a6d7889f14ce0d757
Reviewed-on: https://chromium-review.googlesource.com/c/1335055
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608167}
[modify] https://crrev.com/81b9c9974aa4ce57577df56c16249160e1f6dcb4/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html
[modify] https://crrev.com/81b9c9974aa4ce57577df56c16249160e1f6dcb4/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/redirect-worker.js

Status: Started (was: Assigned)
Started implementation.
WIP CL: https://crrev.com/c/1331105
Project Member

Comment 31 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd

commit c62a00c1ec3f07bba4355be8e1c7b37d488c82cd
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Fri Nov 16 12:14:16 2018

ServiceWorker: Adds resultingClientId to fetch events

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/V4ZqlL0ngC4/-VeAA6qvAQAJ

The original CL was https://crrev.com/c/1053431. This CL is based on
that.

Before this CL, ServiceWorkerProviderHost::client_uuid() always returns the same
value, but it's actually needed to be renewed when cross origin redirect
happens. It became observable by introducing resultingClientId. This CL tries to
update the client id when cross origin redirect.

Bug:  778497 
Change-Id: I7b1490dbe2b2038953bb923d355b42d9d8dd0bd0
Reviewed-on: https://chromium-review.googlesource.com/c/1331105
Reviewed-by: Philip J├Ągenstedt <foolip@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608738}
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/content/browser/service_worker/service_worker_navigation_loader.cc
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/content/browser/service_worker/service_worker_navigation_loader.h
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/content/browser/service_worker/service_worker_version.h
[delete] https://crrev.com/5559d4aef1f297b2c51e5450e5e2568aab139834/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https_client-expected.txt
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/third_party/blink/renderer/modules/service_worker/fetch_event.cc
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/third_party/blink/renderer/modules/service_worker/fetch_event.h
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/third_party/blink/renderer/modules/service_worker/fetch_event.idl
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/third_party/blink/renderer/modules/service_worker/fetch_event_init.idl
[modify] https://crrev.com/c62a00c1ec3f07bba4355be8e1c7b37d488c82cd/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc

I'll check if WPT added by https://bugzilla.mozilla.org/show_bug.cgi?id=1264177 is passing.
Labels: M-72
Status: Fixed (was: Started)
I could confirm it's working well.
Project Member

Comment 34 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3629f6dc18938e3f3cee312c1d758390175c20f3

commit 3629f6dc18938e3f3cee312c1d758390175c20f3
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Nov 20 14:41:44 2018

Refine wpt/service-workers/service-worker/clients-get.https.html

Used async functions, arrow functions, and const, and added some comments.

Bug:  778497 
Change-Id: I03f23c6adddbb0e317edb197dc8af197597b2381
Reviewed-on: https://chromium-review.googlesource.com/c/1343416
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609693}
[modify] https://crrev.com/3629f6dc18938e3f3cee312c1d758390175c20f3/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get-client-types.https.html
[modify] https://crrev.com/3629f6dc18938e3f3cee312c1d758390175c20f3/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-get.https.html
[modify] https://crrev.com/3629f6dc18938e3f3cee312c1d758390175c20f3/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/clients-get-cross-origin-frame.html
[modify] https://crrev.com/3629f6dc18938e3f3cee312c1d758390175c20f3/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/clients-get-resultingClientId-worker.js
[modify] https://crrev.com/3629f6dc18938e3f3cee312c1d758390175c20f3/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/clients-get-worker.js

Sign in to add a comment