The image version in Dome bundle is empty on if the image is uploaded with .tar.xz format. |
|||
Issue descriptionWhat steps will reproduce the problem? The image version information won't show on the Umpire bundle version column if the image is uploaded with .tar.xz format. The version information is correctly parsed with "cros_payload.sh add a.json test_image xxx.tar.xz". What is the expected result? The version should show information like: "10066.0.0 (Official Build) dev-channel fizz-unibuild (fizz sion teemo kench talon) test" What happens instead? The version info is empty
,
Oct 26 2017
Looks like the docker image doesn't contain xz binary. Output listed below: /usr/local/factory # bin/cros_payload add a.json test_image /mnt/umpire/fizz/ChromeOS-test-R64-1006 6.0.0-fizz.tar.xz bin/cros_payload: line 989: xz: not found INFO: Decompressing xz input file /mnt/umpire/fizz/ChromeOS-test-R64-10066.0.0-fizz.tar.xz... bin/cros_payload: line 989: xz: not found partx: /tmp/tmp.GIpIwLd3qM: failed to read partition table
,
Oct 26 2017
I thought we have pixz. No?
,
Oct 26 2017
seems like both are not included. you can send a CL to add package pixz and xz into Docker file.
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/9ffa69b7943a0b3de674aaf9d33b39ae2e5806ab commit 9ffa69b7943a0b3de674aaf9d33b39ae2e5806ab Author: Yilun Lin <yllin@google.com> Date: Thu Oct 26 11:17:54 2017 dome: Add xz package to docker image. cros_payload support .xz format files, however, there isn't xz package in the docker image. Add xz package into the docker image. BUG= chromium:778496 TEST=docker run; upload an image; check version info. Change-Id: I374292b8fe159938e0932d609d8951ac52bd13bc Reviewed-on: https://chromium-review.googlesource.com/737493 Commit-Ready: Yilun Lin <yllin@chromium.org> Tested-by: Yilun Lin <yllin@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/9ffa69b7943a0b3de674aaf9d33b39ae2e5806ab/setup/Dockerfile
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/09d689ce5cf3227cef142ad0e8c8f6efda0e8471 commit 09d689ce5cf3227cef142ad0e8c8f6efda0e8471 Author: Hung-Te Lin <hungte@chromium.org> Date: Fri Oct 27 01:09:25 2017 setup: Add static prebuilt 'pixz' into cros_factory docker image. 'pixz' is not available in Alpine packages but we do want to have it in Docker image so when input Chrome OS test images were compressed by pixz, the decompression should be pretty fast. On z840, time xz -d by_xz.xz => real 1m4s time pixz -d by_xz.xz => real 1m1s time xz -d by_pixz.xz => real 1m3s time pixz -d by_pixz.xz => real 4~6s, user 1m22s BUG= chromium:778496 TEST=./cros_docker.sh build Change-Id: Ie2df68ceba367cdb4db6f9465b589633fd3e6010 Reviewed-on: https://chromium-review.googlesource.com/737600 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Yilun Lin <yllin@chromium.org> [modify] https://crrev.com/09d689ce5cf3227cef142ad0e8c8f6efda0e8471/setup/Dockerfile [modify] https://crrev.com/09d689ce5cf3227cef142ad0e8c8f6efda0e8471/setup/cros_docker.sh
,
Aug 1
,
Aug 6
|
|||
►
Sign in to add a comment |
|||
Comment 1 by hungte@chromium.org
, Oct 26 2017