New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778492 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

views_unittests and others ignore --enable-features=MyNewFeature command line arguments

Project Member Reported by tapted@chromium.org, Oct 26 2017

Issue description

This makes it hard to ensure tests pass leading up to an on-by-default flag flip.

CL -> https://chromium-review.googlesource.com/#/c/chromium/src/+/738013
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5e504d99b942c59736cac47803ae43bfc19ec22

commit c5e504d99b942c59736cac47803ae43bfc19ec22
Author: Trent Apted <tapted@chromium.org>
Date: Thu Oct 26 23:19:26 2017

base::TestSuite: Obey --{en,dis}able-features=.. command line arguments.

base::TestSuite currently calls base::FeatureList::InitFromCommandLine()
with empty strings. There's a TODO to use the actual command line.

To fix, move switches::k{En,Dis}ableFeatures from content_switches.h
to base_switches.h and pass the args to InitFromCommandLine().

TBR=boliu@chromium.org, halliwell@chromium.org, bengr@chromium.org

Bug:  778492 
Change-Id: I988e5aad6dc926c7f9d783766c4a35275154fbee
Reviewed-on: https://chromium-review.googlesource.com/738013
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512005}
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/android_webview/browser/aw_field_trial_creator.cc
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/android_webview/browser/command_line_helper.cc
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/android_webview/browser/command_line_helper_unittest.cc
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/base/base_switches.cc
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/base/base_switches.h
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/base/test/test_suite.cc
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/chrome/browser/about_flags.cc
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager_unittest.cc
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_browsertest.cc
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/components/dom_distiller/core/dom_distiller_switches.h
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/components/ukm/content/source_url_recorder_browsertest.cc
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/content/public/common/content_switches.cc
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/content/public/common/content_switches.h
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/content/public/test/browser_test_base.cc
[modify] https://crrev.com/c5e504d99b942c59736cac47803ae43bfc19ec22/content/public/test/test_utils.cc

Comment 2 by tapted@chromium.org, Oct 27 2017

Status: Fixed (was: Started)

Sign in to add a comment