New issue
Advanced search Search tips

Issue 778485 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Match Patterns article has incorrect domains listed for a match

Reported by cheatcce...@gmail.com, Oct 26 2017

Issue description

This is to report a typo on the following developer webpage:

https://developer.chrome.com/extensions/match_patterns

The bottom of the page gives examples of Url patterns. The third Pattern which is "https://*.google.com/foo*bar" lists the following two example urls: "http://www.google.com/foo/baz/bar"
and
"http://docs.google.com/foobar"

The two examples should be changed to include "https" instead of "http" in the example.
 

Comment 1 by ajha@chromium.org, Oct 26 2017

Components: Platform>Extensions>API
Labels: Documentation
Owner: rdevlin....@chromium.org
Status: Assigned (was: Unconfirmed)
Assigning to  rdevlin.cronin@ based on similar assignment of Issue 318195, for more inputs on this.
Components: -Platform>Extensions>API Platform>Extensions>Documentation
Summary: Match Patterns article has incorrect domains listed for a match (was: Typo)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbe91dee2c1d47d691fa84edbf721d8b362800a9

commit fbe91dee2c1d47d691fa84edbf721d8b362800a9
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Sat Oct 28 01:44:19 2017

[Extensions Docs] Fix incorrect match pattern example

An example in the match patterns documentation listed
"https://*.google.com/foo*bar" as matching
"http://www.google.com/foo/baz/bar" and "http://docs.google.com/foobar",
but the example URLs should be https.

Bug:  778485 
Change-Id: I9cf928f34ed5240b2197c286143479f3ec7d0ad8
Reviewed-on: https://chromium-review.googlesource.com/741180
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512368}
[modify] https://crrev.com/fbe91dee2c1d47d691fa84edbf721d8b362800a9/chrome/common/extensions/docs/templates/articles/match_patterns.html

Status: Fixed (was: Assigned)
This is fixed, and changes are live on the server.

Thanks for the report!

Sign in to add a comment