New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778476 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Delay Animated App Menu Icon

Project Member Reported by spqc...@chromium.org, Oct 26 2017

Issue description

The animation is too fast for anyone to notice. To fix this issue, delay the animation by 1500ms
 

Comment 1 by meh...@chromium.org, Oct 26 2017

Hi. Is issue 648729 may be related?
No, they're different things

Comment 3 by meh...@chromium.org, Oct 26 2017

upps, sorry for the confusing. I misread the summary (App icon vs. User account icon). Sorry again :-(
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/277679ec415394c46d3630041508aa94ab21166f

commit 277679ec415394c46d3630041508aa94ab21166f
Author: spqchan <spqchan@chromium.org>
Date: Fri Nov 03 08:14:42 2017

[Mac] Animated App Menu Icon Delay

Add a "HasDelay" parameter for the Animated App
Menu Icon feature.

If HasDelay is true, then the icon's animation will
be delayed by 1500ms before it animates. The
animation is delayed unless the user clicks on the
menu button or the icon is already animating.

Testing: AppToolbarButtonTest unit tests

Bug:  778476 
Change-Id: Ib2c33043e43bc2225a157f3f0b60dc5dbfb6146d
Reviewed-on: https://chromium-review.googlesource.com/745036
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513722}
[modify] https://crrev.com/277679ec415394c46d3630041508aa94ab21166f/chrome/browser/ui/cocoa/animated_icon.h
[modify] https://crrev.com/277679ec415394c46d3630041508aa94ab21166f/chrome/browser/ui/cocoa/animated_icon.mm
[modify] https://crrev.com/277679ec415394c46d3630041508aa94ab21166f/chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm
[modify] https://crrev.com/277679ec415394c46d3630041508aa94ab21166f/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/277679ec415394c46d3630041508aa94ab21166f/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.h
[modify] https://crrev.com/277679ec415394c46d3630041508aa94ab21166f/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm
[add] https://crrev.com/277679ec415394c46d3630041508aa94ab21166f/chrome/browser/ui/cocoa/toolbar/app_toolbar_button_unittest.mm
[modify] https://crrev.com/277679ec415394c46d3630041508aa94ab21166f/chrome/test/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2ab7ab3f46fc295b5962f60898ae9a83555d47d

commit c2ab7ab3f46fc295b5962f60898ae9a83555d47d
Author: Sarah Chan <spqchan@chromium.org>
Date: Wed Nov 08 20:02:39 2017

[Views] Add delay to the animated app menu icon

Add a "HasDelay" parameter for the Animated App
Menu Icon feature.

If HasDelay is true, then the icon's animation will
be delayed by 1500ms before it animates. The
animation is delayed unless the user clicks on the
menu button or the icon is already animating.

Bug:  778476 
Change-Id: I12613473f1418da0d35552c9f3689953bf4cf40d
Reviewed-on: https://chromium-review.googlesource.com/756361
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514916}
[modify] https://crrev.com/c2ab7ab3f46fc295b5962f60898ae9a83555d47d/chrome/browser/ui/views/toolbar/app_menu_button.cc
[modify] https://crrev.com/c2ab7ab3f46fc295b5962f60898ae9a83555d47d/chrome/browser/ui/views/toolbar/app_menu_button.h
[modify] https://crrev.com/c2ab7ab3f46fc295b5962f60898ae9a83555d47d/ui/views/controls/animated_icon_view.cc
[modify] https://crrev.com/c2ab7ab3f46fc295b5962f60898ae9a83555d47d/ui/views/controls/animated_icon_view.h

Status: Fixed (was: Started)

Sign in to add a comment