New issue
Advanced search Search tips

Issue 778473 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature
M64



Sign in to add a comment

feedbackPrivate.readLogSource: Print name of log source upon failure to read

Project Member Reported by sque@chromium.org, Oct 26 2017

Issue description

This gives us more info about what log source was attempted to be read from, when something went wrong.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa02b4fcc906e0175cbdc3446ecb3fbea74c3d37

commit fa02b4fcc906e0175cbdc3446ecb3fbea74c3d37
Author: Simon Que <sque@chromium.org>
Date: Thu Oct 26 01:36:00 2017

Print name of log source during failed readLogSource()

BUG= 778473 
R=afakhry@chromium.org, tbarzic@chromium.org

Change-Id: I18de052ef94fffae63a93d9a09527d16ff845579
Reviewed-on: https://chromium-review.googlesource.com/737441
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511685}
[modify] https://crrev.com/fa02b4fcc906e0175cbdc3446ecb3fbea74c3d37/extensions/browser/api/feedback_private/feedback_private_api.cc

Comment 2 by sque@chromium.org, Oct 26 2017

Labels: Merge-Request-63
Status: Fixed (was: Started)

Comment 3 by gkihumba@google.com, Oct 26 2017

Labels: -Merge-Request-63 Merge-Approved-63
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 26 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9dabac5e196066b8736c8452c69c5e74ab3ae51

commit f9dabac5e196066b8736c8452c69c5e74ab3ae51
Author: Simon Que <sque@chromium.org>
Date: Thu Oct 26 14:35:06 2017

Print name of log source during failed readLogSource()

BUG= 778473 
R=​afakhry@chromium.org, tbarzic@chromium.org

Change-Id: I18de052ef94fffae63a93d9a09527d16ff845579
Reviewed-on: https://chromium-review.googlesource.com/737441
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#511685}(cherry picked from commit fa02b4fcc906e0175cbdc3446ecb3fbea74c3d37)
Reviewed-on: https://chromium-review.googlesource.com/739184
Reviewed-by: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#239}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/f9dabac5e196066b8736c8452c69c5e74ab3ae51/extensions/browser/api/feedback_private/feedback_private_api.cc

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 6 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment