Crash on adding a printer |
||
Issue descriptionGoogle Chrome 62.0.3202.63 (Official Build) beta (64-bit) Revision 0 Platform 9901.49.0 (Official Build) beta-channel samus Was trying to add a printer - several (10ish?) unsuccessful tries. Crash occurred. Device came back. I restored tabs and then after a few seconds it crashed AGAIN. Did not restore tabs the second time. crash/40452023e08607d1 and crash/f337ba6f48ec4794
,
Oct 26 2017
This is the line from the first crash https://chromium.googlesource.com/chromium/src/+/e8a498472788c1c6834c/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc#311 The crash indicates SIGSEGV but I'm not sure how that's possible in the code. I wonder if there's a configuration we're not testing. Is Sync enabled?
,
Oct 26 2017
This seems to happen when I get a printer added with a particular invalid config. I can't tell what that config is because now as soon as I go into printer config it immediately crashes. Is there some info I can collect?
,
Oct 26 2017
It looks like that it's possible that GetPrinterInfo() returns a null pointer. In this case, when |printers_list| tries to append the value to the list, it will try to use * to get the value the pointer points to (see https://cs.chromium.org/chromium/src/base/values.cc?rcl=c9d234ccd01690deaeba611d6e13d9105b68c025&l=1314), then it will crash if it's a null pointer. It seems like we only need to make sure not to append a nullptr to the list should fix the issue.
,
Oct 26 2017
,
Oct 28 2017
I see it now. If the uri is invalid, we return a nullptr which we probably shouldn't do. I think it's possible that an invalid url can be entered into settings. |
||
►
Sign in to add a comment |
||
Comment 1 by x...@chromium.org
, Oct 26 2017