New issue
Advanced search Search tips

Issue 778467 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug

Blocked on:
issue 914627

Blocking:
issue 796979



Sign in to add a comment

Bring-up content layer layout tests on Fuchsia

Project Member Reported by w...@chromium.org, Oct 25 2017

Issue description

Eventually we will want to run layout tests on Fuchsia, using content-shell.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/010464ad1c6d042d29565b488f0cf88be790bba5

commit 010464ad1c6d042d29565b488f0cf88be790bba5
Author: Wez <wez@chromium.org>
Date: Thu Oct 26 17:42:23 2017

Bring up content_shell for Fuchsia.

- Add a stub implementation of the Blink test platform APIs.
- Disable Breakpad crash-reporter integration under Fuchsia.
- Fix preprocessor checks around Linux crash-reporter integration to
  specify Linux explicitly rather than POSIX with exclusions.
- Fix additional-mapped-files setup for child processes to only apply
  to Linux & Android, where they're required.

(This is just a cleaned-up version of
https://chromium-review.googlesource.com/c/chromium/src/+/706422)

Bug: 778467
Change-Id: I767fb89b49c783a3fa8fededc229420f90329285
Reviewed-on: https://chromium-review.googlesource.com/737058
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511871}
[modify] https://crrev.com/010464ad1c6d042d29565b488f0cf88be790bba5/content/shell/BUILD.gn
[add] https://crrev.com/010464ad1c6d042d29565b488f0cf88be790bba5/content/shell/app/blink_test_platform_support_fuchsia.cc
[modify] https://crrev.com/010464ad1c6d042d29565b488f0cf88be790bba5/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/010464ad1c6d042d29565b488f0cf88be790bba5/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/010464ad1c6d042d29565b488f0cf88be790bba5/content/shell/browser/shell_content_browser_client.h

Blocking: 796979
Status: Assigned (was: Untriaged)
Owner: sergeyu@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd73ff10b53af7ebee6c8145b8bd782c3384b52f

commit bd73ff10b53af7ebee6c8145b8bd782c3384b52f
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Jan 02 18:14:21 2018

Remove CHECK() from content::Shell::PlatformExit()

content::Shell::PlatformExit() may be called more than once: ~Shell()
and Shell::CloseAllWindows() call it. Aura implementation of
PlatformExit() had a CHECK() that didn't allow to call it more than
once. Removed that CHECK().

Bug: 778467
Change-Id: I6ee25c57c3df75431033c000b20febf1bcdc3e2b
Reviewed-on: https://chromium-review.googlesource.com/846340
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526504}
[modify] https://crrev.com/bd73ff10b53af7ebee6c8145b8bd782c3384b52f/content/shell/browser/shell_aura.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebe6b4d79bd5395aa0ee5268e82c3d9d441fb8d9

commit ebe6b4d79bd5395aa0ee5268e82c3d9d441fb8d9
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Jan 02 19:58:49 2018

[Fuchsia] Add --forward-ssh-port in exe_runner.py

The new flag enables SSH port forwarding from the host to the VM. It
will be useful for layout tests to start VM with --no-autorun and
then start and communicate with content_shell over SSH.

Bug: 778467
Change-Id: Ied45b3dd0a5f545def85274a91cc96cae2399832
Reviewed-on: https://chromium-review.googlesource.com/843481
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526523}
[modify] https://crrev.com/ebe6b4d79bd5395aa0ee5268e82c3d9d441fb8d9/build/fuchsia/exe_runner.py
[modify] https://crrev.com/ebe6b4d79bd5395aa0ee5268e82c3d9d441fb8d9/build/fuchsia/runner_common.py
[modify] https://crrev.com/ebe6b4d79bd5395aa0ee5268e82c3d9d441fb8d9/build/fuchsia/test_runner.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/daa25ebc6fbd4b9dcef4c229f62cd948b256c05f

commit daa25ebc6fbd4b9dcef4c229f62cd948b256c05f
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Jan 03 02:32:54 2018

Enable webkit_layout_tests target on Fuchsia

With this CL it's possible to build webkit_layout_tests target for
Fuchsia. The tests don't run yet.

Bug: 778467
Change-Id: Ib869f6f98c52d99f069f9aa431c0c1cafcc7a1d1
Reviewed-on: https://chromium-review.googlesource.com/843013
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526595}
[modify] https://crrev.com/daa25ebc6fbd4b9dcef4c229f62cd948b256c05f/BUILD.gn

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1983dde1d868a8605b4b037904c10c43573dd15

commit b1983dde1d868a8605b4b037904c10c43573dd15
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Jan 03 21:29:29 2018

[Fuchsia] Use Mesa as GL implementation for headless Ozone

Previously all layout tests were failing because
HeadlessSurfaceFactory::GetGLOzone() was always returning nullptr. Now
content_shell can initialize headless ozone backend using mesa.

Bug: 778467
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id0ec9576d9972dedf7d5f6cb5953aef5f0dbfc3e
Reviewed-on: https://chromium-review.googlesource.com/846262
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526821}
[modify] https://crrev.com/b1983dde1d868a8605b4b037904c10c43573dd15/gpu/ipc/service/image_transport_surface_fuchsia.cc
[modify] https://crrev.com/b1983dde1d868a8605b4b037904c10c43573dd15/ui/gl/BUILD.gn
[modify] https://crrev.com/b1983dde1d868a8605b4b037904c10c43573dd15/ui/gl/gl_implementation_osmesa.cc
[modify] https://crrev.com/b1983dde1d868a8605b4b037904c10c43573dd15/ui/ozone/common/gl_ozone_osmesa.cc
[modify] https://crrev.com/b1983dde1d868a8605b4b037904c10c43573dd15/ui/ozone/platform/headless/headless_surface_factory.cc

Blockedon: 800156
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/660ff99a094be171290b0f1fe4a6a3e450ca55ef

commit 660ff99a094be171290b0f1fe4a6a3e450ca55ef
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed Jan 10 01:59:59 2018

Roll Fuchsia SDK to 6b4cb32d100d2ecfaaa9642adfb0de451c5b9a69.

- Fixes argv[0] to report package-relative path for "main" binary.
- Fixes 'threads' utility not to hang if threads exit mid-dump.
- Adds tracing command & service to the SDK, for easier debugging.
- Fixes SSH to return valid exit codes from remote commands.
- Fixes "run" to correctly route program output via stdout/stderr.
- Fixes NET-354 (SSH leaving processes hanging after client disconnects.)

Bug: 707030,  799268 ,  793412 ,  798851 , 778467
Change-Id: Ie3ab3fed54df1884089b57e1638883684de6836f
Reviewed-on: https://chromium-review.googlesource.com/857809
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528206}
[modify] https://crrev.com/660ff99a094be171290b0f1fe4a6a3e450ca55ef/DEPS

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56aeaff6b072eaca59c3aa9d602105c06aaa52d3

commit 56aeaff6b072eaca59c3aa9d602105c06aaa52d3
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Jan 11 20:24:36 2018

[Fuchsia] Fixes in //gpu for layout tests

1. Removed ifdef in GLES2CommandBufferStub::Initialize() that's no
   longer needed.
2. Fixed ImageTransportSurface::CreateNativeSurface() to initialize
   returned Mesa surface.

Bug: 778467
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic2a6af569aa36b0e9a843ed6353ab5ae7a0e33b6
Reviewed-on: https://chromium-review.googlesource.com/858481
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528731}
[modify] https://crrev.com/56aeaff6b072eaca59c3aa9d602105c06aaa52d3/gpu/ipc/service/gles2_command_buffer_stub.cc
[modify] https://crrev.com/56aeaff6b072eaca59c3aa9d602105c06aaa52d3/gpu/ipc/service/image_transport_surface_fuchsia.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62157460a07ed38f23d4ee24146205306ca9d1a1

commit 62157460a07ed38f23d4ee24146205306ca9d1a1
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Jan 16 20:06:54 2018

[Fuchsia] Turn-off multiplexed connections in SSH config

Multiplexed connections currently do not work well because of select()
restrictions on Fuchsia (see ZX-1555): each session adds at least 3
pipes that sshd needs to select on, so it hits 16 FDs limit very easily.
Second problem is that sshd doesn't know how to create new jobs for each
session and since there is no SIGHUP and won't kill child processes when
the client disconnects.

Bug: 778467
Change-Id: I1e6332a817b26dd80e3fe944b51f3ead1cb6c1d8
Reviewed-on: https://chromium-review.googlesource.com/865523
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529494}
[modify] https://crrev.com/62157460a07ed38f23d4ee24146205306ca9d1a1/build/fuchsia/runner_v2/boot_image.py

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7de8580b8ae85e1a713588944b2708e289d6f63e

commit 7de8580b8ae85e1a713588944b2708e289d6f63e
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Jan 19 19:50:34 2018

[Fuchsia] Add layout_test_proxy

When running layout tests on Fuchsia the test runner and content_shell
will run on separate machines. The tests still expect to be loaded from
localhost, so HTTP connections need to be proxied from the Fuchsia
to the host that runs http server. Potentially this can be done with
SSH, but TCP forwarding is broken in sshd on Fuchsia at the moment
due to select() limitations (see ZX-1555).

This CL adds a new executable that will be used proxy connections for
layout tests. The implementation is based on the socket proxy
that's currently used to proxy test_server connections in
net_unittests. That code is also being moved from
net/test/spawned_test_server to net/test.


Bug: 778467
Change-Id: I9c86cf5f27cbfd01b0c475ec242c6262bf7c6b57
Reviewed-on: https://chromium-review.googlesource.com/858289
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530587}
[modify] https://crrev.com/7de8580b8ae85e1a713588944b2708e289d6f63e/BUILD.gn
[add] https://crrev.com/7de8580b8ae85e1a713588944b2708e289d6f63e/build/fuchsia/layout_test_proxy/BUILD.gn
[add] https://crrev.com/7de8580b8ae85e1a713588944b2708e289d6f63e/build/fuchsia/layout_test_proxy/DEPS
[add] https://crrev.com/7de8580b8ae85e1a713588944b2708e289d6f63e/build/fuchsia/layout_test_proxy/layout_test_proxy.cc
[modify] https://crrev.com/7de8580b8ae85e1a713588944b2708e289d6f63e/net/BUILD.gn
[modify] https://crrev.com/7de8580b8ae85e1a713588944b2708e289d6f63e/net/test/spawned_test_server/remote_test_server.cc
[modify] https://crrev.com/7de8580b8ae85e1a713588944b2708e289d6f63e/net/test/spawned_test_server/remote_test_server.h
[delete] https://crrev.com/60916ba1169d9207e048e2eca290c946ba37fcad/net/test/spawned_test_server/remote_test_server_proxy.h
[rename] https://crrev.com/7de8580b8ae85e1a713588944b2708e289d6f63e/net/test/tcp_socket_proxy.cc
[add] https://crrev.com/7de8580b8ae85e1a713588944b2708e289d6f63e/net/test/tcp_socket_proxy.h
[rename] https://crrev.com/7de8580b8ae85e1a713588944b2708e289d6f63e/net/test/tcp_socket_proxy_unittest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/292dd3e446a022f533e79bc9c1c9d0cb757f792d

commit 292dd3e446a022f533e79bc9c1c9d0cb757f792d
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Sat Jan 20 00:36:40 2018

[Fuchsia] Update ImageTransportSurface to use gl::init::CreateViewGLSurface()

Previously ImageTransportSurface was creating GLSurfaceOSMesa, but
that this is wrong because GLSurfaceOSMesa doesn't support
SwapBuffers(). Updated ImageTransportSurface to call
CreateViewGLSurface(), which in turn creates GLSurfaceOSMesaHeadless.
That class handles SwapBuffers() correctly.

Bug: 778467
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I701dd219ad5867359ade613fbb1ea24d722f55f3
Reviewed-on: https://chromium-review.googlesource.com/876993
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530693}
[modify] https://crrev.com/292dd3e446a022f533e79bc9c1c9d0cb757f792d/gpu/ipc/service/image_transport_surface_fuchsia.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd206867750f9f0b32a695701a488db153410548

commit fd206867750f9f0b32a695701a488db153410548
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Sat Jan 20 01:43:44 2018

Roll Fuchsia SDK 6b4cb32 -> 8a3a2690

New version fixes stdout/stderr redirection for packaged applications.

Bug: 778467
Change-Id: Ie704dd144accc10b8cbc61dfdcc468f5ec9762e7
Reviewed-on: https://chromium-review.googlesource.com/876986
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530726}
[modify] https://crrev.com/fd206867750f9f0b32a695701a488db153410548/DEPS

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6c7b59c2cd20cf5fdb7f769a03a144fa0562a62

commit a6c7b59c2cd20cf5fdb7f769a03a144fa0562a62
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Jan 22 19:23:33 2018

[Fuchsia] Add --stdin-redirect flag in content_shell.

Layout tests use stdin to pass commands to content_shell. Stdin is not
supported on Fuchsia for packaged apps. The new --stdin-redirect flag
allows to workaround this issue by redirecting stdin stream to a TCP
socket.

Bug: 778467
Change-Id: I8a162bfe9946322345471d1dd51c042573a083b0
Reviewed-on: https://chromium-review.googlesource.com/876648
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530942}
[modify] https://crrev.com/a6c7b59c2cd20cf5fdb7f769a03a144fa0562a62/content/shell/browser/layout_test/layout_test_browser_main.cc
[modify] https://crrev.com/a6c7b59c2cd20cf5fdb7f769a03a144fa0562a62/content/shell/browser/layout_test/test_info_extractor.cc
[modify] https://crrev.com/a6c7b59c2cd20cf5fdb7f769a03a144fa0562a62/content/shell/browser/layout_test/test_info_extractor.h

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12550a7b2446c1de28011c46c3550d61e45eafad

commit 12550a7b2446c1de28011c46c3550d61e45eafad
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Jan 23 19:47:22 2018

[Fuchsia] Update PathProvideFuchsia to avoid blocking IO.

Previously GetPackageRoot() was calling base::FileExists(), which requires
blocking IO, i.e. it DCHECKs on some threads. Updated the logic used to
detect that the app is packaged to avoid blocking IO.

Bug:  796779 , 778467
Change-Id: I3ae8f5fefea182295a7fda4ff40964f21ba63e5c
Reviewed-on: https://chromium-review.googlesource.com/876660
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531308}
[modify] https://crrev.com/12550a7b2446c1de28011c46c3550d61e45eafad/base/base_paths_fuchsia.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cea1c6cef8146e0a81c6c494964b946abb15e13

commit 6cea1c6cef8146e0a81c6c494964b946abb15e13
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Jan 30 00:32:50 2018

[Fuchsia] Fix assets loading for content_shell package.

content_shell previously was failing to find V8 natives file and resources
when packaged on Fuchsia. Update paths used to locate these assets to make
content_shell usable again.

Bug:  796779 , 778467
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I257124223f953bbf048ca6ab649322e8f726bf5d
Reviewed-on: https://chromium-review.googlesource.com/865466
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532695}
[modify] https://crrev.com/6cea1c6cef8146e0a81c6c494964b946abb15e13/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/6cea1c6cef8146e0a81c6c494964b946abb15e13/gin/v8_initializer.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7580124dfb49b562b3928267170a8140d64bbb6

commit c7580124dfb49b562b3928267170a8140d64bbb6
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Jan 30 23:26:19 2018

Add layout_tests Port implementation for Fuchsia.

The new port allows to run layout tests on Fuchsia. It starts QEmu with
Fuchsia and then connects to it over SSH to execute content_shell.

Bug: 778467
Change-Id: If14317553c7e605b3d1c693d006faf0120d214fc
Reviewed-on: https://chromium-review.googlesource.com/876932
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533078}
[add] https://crrev.com/c7580124dfb49b562b3928267170a8140d64bbb6/build/fuchsia/runner_v2/__init__.py
[modify] https://crrev.com/c7580124dfb49b562b3928267170a8140d64bbb6/build/fuchsia/runner_v2/qemu_target.py
[modify] https://crrev.com/c7580124dfb49b562b3928267170a8140d64bbb6/build/fuchsia/runner_v2/target.py
[modify] https://crrev.com/c7580124dfb49b562b3928267170a8140d64bbb6/content/shell/app/blink_test_platform_support_fuchsia.cc
[modify] https://crrev.com/c7580124dfb49b562b3928267170a8140d64bbb6/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
[modify] https://crrev.com/c7580124dfb49b562b3928267170a8140d64bbb6/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/c7580124dfb49b562b3928267170a8140d64bbb6/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/c7580124dfb49b562b3928267170a8140d64bbb6/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py
[modify] https://crrev.com/c7580124dfb49b562b3928267170a8140d64bbb6/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py
[add] https://crrev.com/c7580124dfb49b562b3928267170a8140d64bbb6/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/fuchsia.py
[modify] https://crrev.com/c7580124dfb49b562b3928267170a8140d64bbb6/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
[modify] https://crrev.com/c7580124dfb49b562b3928267170a8140d64bbb6/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Project Member

Comment 21 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/def62d54c45d5598eea3b4808f8cce07f308e1cd

commit def62d54c45d5598eea3b4808f8cce07f308e1cd
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Feb 02 20:26:38 2018

[Fuchsia] Copy fonts from the host for layout tests

Now layout tests runner copies fonts from the host to the target
machine. This is the same approach that is used for Android. It will
allow to reuse layout tests expectations from Linux/Android.

Bug: 778467
Change-Id: Id878966c435476b8fb22441441108a74c9e40f1b
Reviewed-on: https://chromium-review.googlesource.com/887745
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534133}
[modify] https://crrev.com/def62d54c45d5598eea3b4808f8cce07f308e1cd/build/fuchsia/runner_v2/remote_cmd.py
[modify] https://crrev.com/def62d54c45d5598eea3b4808f8cce07f308e1cd/build/fuchsia/runner_v2/target.py
[modify] https://crrev.com/def62d54c45d5598eea3b4808f8cce07f308e1cd/content/shell/app/blink_test_platform_support_fuchsia.cc
[modify] https://crrev.com/def62d54c45d5598eea3b4808f8cce07f308e1cd/skia/BUILD.gn
[add] https://crrev.com/def62d54c45d5598eea3b4808f8cce07f308e1cd/skia/ext/fontmgr_default_fuchsia.cc
[add] https://crrev.com/def62d54c45d5598eea3b4808f8cce07f308e1cd/skia/ext/fontmgr_default_fuchsia.h
[modify] https://crrev.com/def62d54c45d5598eea3b4808f8cce07f308e1cd/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/def62d54c45d5598eea3b4808f8cce07f308e1cd/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/def62d54c45d5598eea3b4808f8cce07f308e1cd/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/fuchsia.py

Project Member

Comment 22 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1500dcd06d1005bbe4b659cb7732978c2d24019

commit a1500dcd06d1005bbe4b659cb7732978c2d24019
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Feb 05 21:03:15 2018

Update layout tests to use correct path for Fuchsia packages

The build scripts were updated to use gen/<path>/<name>/<name>.far
instead of package/<name>.far for packaged targets on Fuchsia.

Bug: 778467
Change-Id: I04e2b19850037ab50a73cc62ee9c70f05d5c7225
Reviewed-on: https://chromium-review.googlesource.com/902172
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534492}
[modify] https://crrev.com/a1500dcd06d1005bbe4b659cb7732978c2d24019/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/fuchsia.py

Project Member

Comment 23 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0034884cda16a0371d0f80b865278218205312ef

commit 0034884cda16a0371d0f80b865278218205312ef
Author: Sergey Ulanov <sergeyu@google.com>
Date: Wed Feb 07 21:07:35 2018

[Blink] Simplify font render style handling on Linux, Android & Fuchsia

Previously font render styler logic was mostly platform specific,
which made it hard to ensure that font rendering is consistent across
supported platforms. This CL moves code previously used on Linux and
Android, so it can be shared with Fuchsia.
 1. FontRenderStyle class out of linux directory and renames it to
    WebFontRenderStyle.
 2. Removed WebFontRendering class, which allows to remove one layer
    between content and font config stored in FontRenderStyle.
 3. Default font size now is stored in FontCache instead of
    LayoutThemeFontProvider. Mainly for consistency, since FontCache
    is responsible for handling all other font-related settings.

With these changes font rendering on Fuchsia is consistent with Linux,
which will allow to reuse layout test expectations.

In future WebFontRenderStyle can be used on Windows as well.

Bug: 778467, 808221
Change-Id: I6a7ef7e87f4c51e9d78d077c6cb796f3cbe5c8e1
Reviewed-on: https://chromium-review.googlesource.com/896839
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535140}
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/content/child/child_process_sandbox_support_impl_linux.cc
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/content/renderer/render_view_linux.cc
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/content/zygote/zygote_main_linux.cc
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/core/css/CSSFontFaceSourceTest.cpp
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/core/layout/BUILD.gn
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/core/layout/LayoutThemeDefault.h
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/core/layout/LayoutThemeFontProvider.cpp
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/core/layout/LayoutThemeFontProvider.h
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/core/layout/LayoutThemeFontProviderDefault.cpp
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/core/layout/LayoutThemeFontProviderWin.cpp
[delete] https://crrev.com/c8a484b5f69327d05a95c0298b1ef2a18f192532/third_party/WebKit/Source/core/layout/WebFontRenderingAndroid.cpp
[delete] https://crrev.com/c8a484b5f69327d05a95c0298b1ef2a18f192532/third_party/WebKit/Source/core/layout/WebFontRenderingLinux.cpp
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/platform/BUILD.gn
[delete] https://crrev.com/c8a484b5f69327d05a95c0298b1ef2a18f192532/third_party/WebKit/Source/platform/exported/linux/WebFontRenderStyle.cpp
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/platform/fonts/FontCache.cpp
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/platform/fonts/FontCache.h
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/platform/fonts/FontMetrics.cpp
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/platform/fonts/FontPlatformData.h
[add] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/platform/fonts/WebFontRenderStyle.cpp
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/platform/fonts/fuchsia/FontCacheFuchsia.cpp
[delete] https://crrev.com/c8a484b5f69327d05a95c0298b1ef2a18f192532/third_party/WebKit/Source/platform/fonts/fuchsia/FontPlatformDataFuchsia.cpp
[delete] https://crrev.com/c8a484b5f69327d05a95c0298b1ef2a18f192532/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp
[delete] https://crrev.com/c8a484b5f69327d05a95c0298b1ef2a18f192532/third_party/WebKit/Source/platform/fonts/linux/FontRenderStyle.cpp
[delete] https://crrev.com/c8a484b5f69327d05a95c0298b1ef2a18f192532/third_party/WebKit/Source/platform/fonts/linux/FontRenderStyle.h
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizerTest.cpp
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp
[modify] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/0034884cda16a0371d0f80b865278218205312ef/third_party/WebKit/public/platform/WebFontRenderStyle.h
[delete] https://crrev.com/c8a484b5f69327d05a95c0298b1ef2a18f192532/third_party/WebKit/public/platform/linux/WebFontRenderStyle.h
[delete] https://crrev.com/c8a484b5f69327d05a95c0298b1ef2a18f192532/third_party/WebKit/public/web/linux/WebFontRendering.h

Project Member

Comment 24 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/209b731df0bf0446f03b8722184cf5fed6b32fb9

commit 209b731df0bf0446f03b8722184cf5fed6b32fb9
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Feb 09 19:06:06 2018

[Fuchsia] Implement blink::FontCache::PlatformFallbackFontForCharacter()

Currently the implementation of PlatformFallbackFontForCharacter() is the same as
on Android.

Also some minor cleanups in FontCache.h

Bug: 778467
Change-Id: I2367e2cbe5dc52b6436aa20407d2914395bf1784
Reviewed-on: https://chromium-review.googlesource.com/909793
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535774}
[modify] https://crrev.com/209b731df0bf0446f03b8722184cf5fed6b32fb9/third_party/WebKit/Source/platform/fonts/FontCache.cpp
[modify] https://crrev.com/209b731df0bf0446f03b8722184cf5fed6b32fb9/third_party/WebKit/Source/platform/fonts/FontCache.h
[modify] https://crrev.com/209b731df0bf0446f03b8722184cf5fed6b32fb9/third_party/WebKit/Source/platform/fonts/fuchsia/FontCacheFuchsia.cpp
[modify] https://crrev.com/209b731df0bf0446f03b8722184cf5fed6b32fb9/third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp
[modify] https://crrev.com/209b731df0bf0446f03b8722184cf5fed6b32fb9/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

Project Member

Comment 25 by bugdroid1@chromium.org, Feb 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2462e59f962af98014a02c1cf2b9e8804cd36c10

commit 2462e59f962af98014a02c1cf2b9e8804cd36c10
Author: Sergey Ulanov <sergeyu@google.com>
Date: Sat Feb 10 03:09:46 2018

[Fuchsia] Implement RenderViewImpl::UpdateFontRenderingFromRendererPrefs()

Bug: 778467
Change-Id: I4d5c662915b34237f706abdccd110748f1dbabcc
Reviewed-on: https://chromium-review.googlesource.com/912669
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535947}
[modify] https://crrev.com/2462e59f962af98014a02c1cf2b9e8804cd36c10/content/renderer/render_view_fuchsia.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e21a127f2085ecfab817147bc650632cf3fa599

commit 8e21a127f2085ecfab817147bc650632cf3fa599
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Feb 13 19:12:07 2018

Update http server config to match tests expections.

Layout tests in fast/hardness/perftests expect to be able to load JS
files from PerformanceTests dir. This wasn't working previously because
the directory was exposed in apache as all-perf-tests instead of
PerforanceTests. Updated Android and Fuchsia ports so the paths on http
server match the patch on FS.

Also removed Android expectation file for perf-runner-compute-statistics,
as the test passes properly now.

Bug: 778467
Change-Id: Id420441b1b61a4a1cc8585a9f91398cbd36ffe54
Reviewed-on: https://chromium-review.googlesource.com/914716
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536411}
[modify] https://crrev.com/8e21a127f2085ecfab817147bc650632cf3fa599/third_party/WebKit/LayoutTests/platform/android/fast/events/simulated-click-on-anchor-with-target-blank-expected.txt
[delete] https://crrev.com/54d60411fa5e3e4077f9369ce153d8701b72f870/third_party/WebKit/LayoutTests/platform/android/fast/harness/perftests/perf-runner-compute-statistics-expected.txt
[modify] https://crrev.com/8e21a127f2085ecfab817147bc650632cf3fa599/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/8e21a127f2085ecfab817147bc650632cf3fa599/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/fuchsia.py

Project Member

Comment 27 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a303ff2ae7cf94459bdb504db2bc88e2d8ff438e

commit a303ff2ae7cf94459bdb504db2bc88e2d8ff438e
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Feb 13 19:13:17 2018

Disabled subpixel text positioning in tests on Fuchsia.

Subpixel text positioning was disabled in tests on Linux and Android.
Disabling it on Fuchsia as well.

Bug: 778467
Change-Id: I8d22d2b7e6836677ce03fc39f167bcf86bb48448
Reviewed-on: https://chromium-review.googlesource.com/907969
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536413}
[modify] https://crrev.com/a303ff2ae7cf94459bdb504db2bc88e2d8ff438e/content/shell/test_runner/test_runner.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81325ee9e2a61676bc3b020e1170a6f7b93f2556

commit 81325ee9e2a61676bc3b020e1170a6f7b93f2556
Author: Sergey Ulanov <sergeyu@google.com>
Date: Thu Feb 15 01:38:16 2018

Add NotoSansCJK font to content_shell_fonts collection.

Currently the set of fonts used for layout tests on Android and Fuchsia
doesn't include any Chinese, Japanese or Korean fonts, so they render tofu
on the pixel tests that contain text in these languages. Adding NotoSansCJK
so these tests can render properly.

Bug: 778467,  787020 
Change-Id: Id29b65525d5af0be96984db69e62d9d198b87fd4
Reviewed-on: https://chromium-review.googlesource.com/910122
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536920}
[modify] https://crrev.com/81325ee9e2a61676bc3b020e1170a6f7b93f2556/content/shell/test_runner/resources/fonts/android_fallback_fonts.xml
[modify] https://crrev.com/81325ee9e2a61676bc3b020e1170a6f7b93f2556/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/81325ee9e2a61676bc3b020e1170a6f7b93f2556/third_party/content_shell_fonts/BUILD.gn
[modify] https://crrev.com/81325ee9e2a61676bc3b020e1170a6f7b93f2556/third_party/content_shell_fonts/README.chromium
[modify] https://crrev.com/81325ee9e2a61676bc3b020e1170a6f7b93f2556/third_party/content_shell_fonts/content_shell_test_fonts.tar.gz.sha1
[modify] https://crrev.com/81325ee9e2a61676bc3b020e1170a6f7b93f2556/ui/gfx/test/fontconfig_util_linux.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d12e87aae0af652e39687d856c7979a1ad4a36b

commit 9d12e87aae0af652e39687d856c7979a1ad4a36b
Author: Tim Schumann <tschumann@chromium.org>
Date: Thu Feb 15 13:27:12 2018

Revert "Add NotoSansCJK font to content_shell_fonts collection."

This reverts commit 81325ee9e2a61676bc3b020e1170a6f7b93f2556.

Reason for revert: Seems to have broken the Webkit Android build.

Example from: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Android__Nexus4_%2F74342%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout

BUG= 812597 

Original change's description:
> Add NotoSansCJK font to content_shell_fonts collection.
> 
> Currently the set of fonts used for layout tests on Android and Fuchsia
> doesn't include any Chinese, Japanese or Korean fonts, so they render tofu
> on the pixel tests that contain text in these languages. Adding NotoSansCJK
> so these tests can render properly.
> 
> Bug: 778467,  787020 
> Change-Id: Id29b65525d5af0be96984db69e62d9d198b87fd4
> Reviewed-on: https://chromium-review.googlesource.com/910122
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536920}

TBR=sky@chromium.org,dpranke@chromium.org,sergeyu@chromium.org,drott@chromium.org

Change-Id: I3894b1c956837796b1b0bb5fa4fc3e9e2e6eba8f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 778467,  787020 
Reviewed-on: https://chromium-review.googlesource.com/921501
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537002}
[modify] https://crrev.com/9d12e87aae0af652e39687d856c7979a1ad4a36b/content/shell/test_runner/resources/fonts/android_fallback_fonts.xml
[modify] https://crrev.com/9d12e87aae0af652e39687d856c7979a1ad4a36b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/9d12e87aae0af652e39687d856c7979a1ad4a36b/third_party/content_shell_fonts/BUILD.gn
[modify] https://crrev.com/9d12e87aae0af652e39687d856c7979a1ad4a36b/third_party/content_shell_fonts/README.chromium
[modify] https://crrev.com/9d12e87aae0af652e39687d856c7979a1ad4a36b/third_party/content_shell_fonts/content_shell_test_fonts.tar.gz.sha1
[modify] https://crrev.com/9d12e87aae0af652e39687d856c7979a1ad4a36b/ui/gfx/test/fontconfig_util_linux.cc

Project Member

Comment 30 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a523cc82cda39354613d28d82aaf100df9867019

commit a523cc82cda39354613d28d82aaf100df9867019
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Feb 16 20:08:34 2018

Reland "Add NotoSansCJK font to content_shell_fonts collection."

This is a reland of 81325ee9e2a61676bc3b020e1170a6f7b93f2556.

Fixed issue in base.py: NotoSansCJKkr-Regular.otf -> NotoSansCJKjp-Regular.otf

Original change's description:
> Add NotoSansCJK font to content_shell_fonts collection.
>
> Currently the set of fonts used for layout tests on Android and Fuchsia
> doesn't include any Chinese, Japanese or Korean fonts, so they render tofu
> on the pixel tests that contain text in these languages. Adding NotoSansCJK
> so these tests can render properly.
>
> Bug: 778467,  787020 
> Change-Id: Id29b65525d5af0be96984db69e62d9d198b87fd4
> Reviewed-on: https://chromium-review.googlesource.com/910122
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536920}

TBR=sky@chromium.org,dpranke@chromium.org,drott@chromium.org

Bug: 778467,  787020 
Change-Id: I722cb2989504848a7ecc131ab5a8209fe8cafca6
Reviewed-on: https://chromium-review.googlesource.com/923720
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537394}
[modify] https://crrev.com/a523cc82cda39354613d28d82aaf100df9867019/content/shell/test_runner/resources/fonts/android_fallback_fonts.xml
[modify] https://crrev.com/a523cc82cda39354613d28d82aaf100df9867019/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/a523cc82cda39354613d28d82aaf100df9867019/third_party/content_shell_fonts/BUILD.gn
[modify] https://crrev.com/a523cc82cda39354613d28d82aaf100df9867019/third_party/content_shell_fonts/README.chromium
[modify] https://crrev.com/a523cc82cda39354613d28d82aaf100df9867019/third_party/content_shell_fonts/content_shell_test_fonts.tar.gz.sha1
[modify] https://crrev.com/a523cc82cda39354613d28d82aaf100df9867019/ui/gfx/test/fontconfig_util_linux.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eca148ae891c734bc109476fc085af4c3b59205c

commit eca148ae891c734bc109476fc085af4c3b59205c
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Feb 16 21:39:23 2018

Add content_shell_fonts in content_shell's data_deps on Fuchsia and Android

After crrev.com/534819 content_shell_fonts are used on Android, but they
were not pulled in data_deps for content shell, so they were not
included when running tests on swarming bots. Now content_shell depends
//third_party//content_shell_fonts, same as it was on Linux.

Also added Android font config files to data_deps on Fuchsia.

Bug: 778467,  787020 
Change-Id: I23b65f381ac31012d88b9f66b457cfb7496223d4
Reviewed-on: https://chromium-review.googlesource.com/919875
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537417}
[modify] https://crrev.com/eca148ae891c734bc109476fc085af4c3b59205c/content/shell/BUILD.gn
[modify] https://crrev.com/eca148ae891c734bc109476fc085af4c3b59205c/content/shell/test_runner/BUILD.gn
[modify] https://crrev.com/eca148ae891c734bc109476fc085af4c3b59205c/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/eca148ae891c734bc109476fc085af4c3b59205c/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/eca148ae891c734bc109476fc085af4c3b59205c/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/fuchsia.py

Project Member

Comment 32 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85835a0145a686c5b2ec3e076b6ee03d3ee8946a

commit 85835a0145a686c5b2ec3e076b6ee03d3ee8946a
Author: Sergey Ulanov <sergeyu@google.com>
Date: Fri Feb 23 23:57:07 2018

Enable layout_tests on the Fuchsia FYI bot.

Enabling layout tests on Fuchsia bots. Only smoke tests are currently
enabled. For most tests output matches Linux. Added new expectations for
the cases when the results are different from Linux (in such cases they
often match Android).

Bug: 778467
Change-Id: Id26f7de9ec397cca46a83fae9937f7c3f6d6ce60
Reviewed-on: https://chromium-review.googlesource.com/917188
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538951}
[modify] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/third_party/WebKit/LayoutTests/platform/fuchsia/fast/beacon/beacon-basic-expected.txt
[add] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/third_party/WebKit/LayoutTests/platform/fuchsia/fast/events/simulated-click-on-anchor-with-target-blank-expected.txt
[add] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/third_party/WebKit/LayoutTests/platform/fuchsia/fast/filesystem/simple-persistent-expected.txt
[add] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/third_party/WebKit/LayoutTests/platform/fuchsia/fast/inspector-support/cssURLQuotes-expected.txt
[add] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/third_party/WebKit/LayoutTests/platform/fuchsia/fast/text/international/001-expected.png
[add] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/third_party/WebKit/LayoutTests/platform/fuchsia/fast/text/international/003-expected.png
[add] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/third_party/WebKit/LayoutTests/platform/fuchsia/fast/url/invalid-urls-utf8-expected.txt
[add] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/third_party/WebKit/LayoutTests/platform/fuchsia/fast/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt
[add] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/third_party/WebKit/LayoutTests/platform/fuchsia/plugins/instance-available-before-stylesheets-loaded-expected.txt
[modify] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
[modify] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/85835a0145a686c5b2ec3e076b6ee03d3ee8946a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/fuchsia.py

Comment 33 by sergeyu@google.com, Feb 26 2018

Blockedon: -800156

Comment 34 by sergeyu@google.com, Feb 26 2018

Status: Fixed (was: Started)
Project Member

Comment 35 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c961d1c1002b4feac4c963dc99103d000edc100

commit 4c961d1c1002b4feac4c963dc99103d000edc100
Author: Robert Ma <robertma@chromium.org>
Date: Tue Feb 27 15:54:02 2018

Add Fuchsia to webkitpy's builders.json

So that layout_tests.port.factory can return the correct list of
builders and ports that contain Fuchsia. One use case of these lists is
to get rid of stray expectations after rebaseline (similar to Android).

Bug: 778467
Change-Id: Ia41fba2ea802518ce0d8418a02d07bd26250b5bc
Reviewed-on: https://chromium-review.googlesource.com/938584
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539437}
[modify] https://crrev.com/4c961d1c1002b4feac4c963dc99103d000edc100/third_party/WebKit/Tools/Scripts/webkitpy/common/config/builders.json

Status: Assigned (was: Fixed)
Reactivating the bug as there will be more work needed due to the switch  from archives to packages.
Project Member

Comment 37 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f0d5ec0ae298a782a347807ba8bde3f93c25aee

commit 0f0d5ec0ae298a782a347807ba8bde3f93c25aee
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed Feb 28 02:54:02 2018

Fuchsia: install binaries and dependencies using package/blob system.

This solution deploys and runs applications using Fuchsia's package
infrastructure. Files are copied into the blobstore as hashed blobs
and executed from a signed and packaged manifest file.

Also:
* Disable Fuchsia layout tests. The Fuchsia deployment script
for layout tests needs to be tweaked before it can run with packages.
* Add an extra verbose '-vv' switch to cut down on 'scp -v' chatter.
* Add a getter to Target to check if the target was freshly booted.

Bug:  798851 ,778467
Change-Id: Idf061a3b78844bf63b6c8e0c1a01e99db62f3e20
Reviewed-on: https://chromium-review.googlesource.com/935741
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539677}
[modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/build/fuchsia/runner_v2/common_args.py
[modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/build/fuchsia/runner_v2/device_target.py
[modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/build/fuchsia/runner_v2/qemu_target.py
[modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/build/fuchsia/runner_v2/remote_cmd.py
[modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/build/fuchsia/runner_v2/run_package.py
[modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/build/fuchsia/runner_v2/target.py
[modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/testing/buildbot/waterfalls.pyl

Project Member

Comment 38 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2caed08e80433af553cc5d348e1790e4fcc3563

commit c2caed08e80433af553cc5d348e1790e4fcc3563
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu May 10 19:02:18 2018

[Fuchsia] Remove layout_test_proxy

layout_test_proxy is no longer needed for layout tests because we can
use SSH.

Bug: 778467
Change-Id: I802ee687a9dab6448fc902a074553dbeb5bbafee
Reviewed-on: https://chromium-review.googlesource.com/1053394
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557609}
[modify] https://crrev.com/c2caed08e80433af553cc5d348e1790e4fcc3563/BUILD.gn
[delete] https://crrev.com/0a8d63a429473075f332dc786c110fd0e225a7fd/build/fuchsia/layout_test_proxy/BUILD.gn
[delete] https://crrev.com/0a8d63a429473075f332dc786c110fd0e225a7fd/build/fuchsia/layout_test_proxy/DEPS
[delete] https://crrev.com/0a8d63a429473075f332dc786c110fd0e225a7fd/build/fuchsia/layout_test_proxy/layout_test_proxy.cc

Project Member

Comment 39 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd758856f402c7851de6c7e1d238ec35787ea365

commit dd758856f402c7851de6c7e1d238ec35787ea365
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu May 10 22:15:06 2018

[Fuchsia] Implement gpu::CollectContextGraphicsInfo()

CollectContextGraphicsInfo() now calls CollectGraphicsInfoGL(), same as
on Linux and Mac. Layout tests were failing to start due to
CollectContextGraphicsInfo() returning false.

Bug: 778467
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If089e57b167fb74f95da4462cbe2b1756a76c2be
Reviewed-on: https://chromium-review.googlesource.com/1054265
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557682}
[modify] https://crrev.com/dd758856f402c7851de6c7e1d238ec35787ea365/gpu/config/gpu_info_collector_fuchsia.cc

Project Member

Comment 40 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74a80a86c13c35b614ba3335171eccf37bdccb92

commit 74a80a86c13c35b614ba3335171eccf37bdccb92
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu May 10 22:49:02 2018

[Fuchsia] Fix layout tests

Layout tests were disabled on Fuchsia, so they bitrotted in the last
couple of month. This CL includes the following changes to make layout
tests runnable on Fuchsia again:
1. Content shell package is installed with "pm install" command.
2. Fonts no longer need to be copied - they are part of the content_shell
   package as data deps.
3. Now SSH can used to forward TCP connections instead of
   layout_test_proxy.
4. libosmesa.so can be loaded from the package, so it no longer needs
   to be copied to /system/lib .

Bug: 778467
Change-Id: Ie16f7ad6b9088153450194b280a6f69e9cb25328
Reviewed-on: https://chromium-review.googlesource.com/1054332
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557711}
[modify] https://crrev.com/74a80a86c13c35b614ba3335171eccf37bdccb92/third_party/blink/tools/blinkpy/web_tests/port/fuchsia.py

Project Member

Comment 41 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bc40199c85509708dcc0705fb5b61778d590e2d

commit 0bc40199c85509708dcc0705fb5b61778d590e2d
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri May 11 23:12:11 2018

Use DIR_TEMP instead of DIR_EXE for content_shell.log

content_shell was trying to create log file in DIR_EXE. This doesn work
on platforms where the directory is not writable, particularly on
Fuchsia. Updated content_shell to use DIR_TEMP on Fuchsia.

Bug: 778467
Change-Id: I03198062e0c067340479209c99056a4e0b460ea4
Reviewed-on: https://chromium-review.googlesource.com/1054785
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558054}
[modify] https://crrev.com/0bc40199c85509708dcc0705fb5b61778d590e2d/content/shell/app/shell_main_delegate.cc

Project Member

Comment 42 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e7e650e6f51f0727d9c67c56d1b5f934d4ef414

commit 6e7e650e6f51f0727d9c67c56d1b5f934d4ef414
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon May 14 19:43:48 2018

Add Ahem.ttf to test_fonts.

Ahem font is designed specifically for tests. There are serveral
copies checked in in chromium. Putting it in third_party/test_fonts
will allow to deploy it for layout tests on all platforms same way
as other fonts.

I will remove AHEM_____.TTF later in a separate CL(s).

Bug:  787020 , 778467
Change-Id: Id4bf45792c591ac1f0ac5ef94f7a1b95cef3b6f1
Reviewed-on: https://chromium-review.googlesource.com/1055811
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558419}
[modify] https://crrev.com/6e7e650e6f51f0727d9c67c56d1b5f934d4ef414/content/shell/test_runner/resources/fonts/android_main_fonts.xml
[modify] https://crrev.com/6e7e650e6f51f0727d9c67c56d1b5f934d4ef414/third_party/blink/tools/blinkpy/web_tests/port/base.py
[modify] https://crrev.com/6e7e650e6f51f0727d9c67c56d1b5f934d4ef414/third_party/test_fonts/BUILD.gn
[modify] https://crrev.com/6e7e650e6f51f0727d9c67c56d1b5f934d4ef414/third_party/test_fonts/LICENSE
[modify] https://crrev.com/6e7e650e6f51f0727d9c67c56d1b5f934d4ef414/third_party/test_fonts/README.chromium
[modify] https://crrev.com/6e7e650e6f51f0727d9c67c56d1b5f934d4ef414/third_party/test_fonts/test_fonts.tar.gz.sha1

Project Member

Comment 43 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c43766666030f7416ac4456a8b915b37d0250b6c

commit c43766666030f7416ac4456a8b915b37d0250b6c
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed May 16 02:56:32 2018

Revert "[Fuchsia] Remove layout_test_proxy"

This reverts commit c2caed08e80433af553cc5d348e1790e4fcc3563.

Reason for revert: Still need it: SSH port forwarding is unreliable

Original change's description:
> [Fuchsia] Remove layout_test_proxy
> 
> layout_test_proxy is no longer needed for layout tests because we can
> use SSH.
> 
> Bug: 778467
> Change-Id: I802ee687a9dab6448fc902a074553dbeb5bbafee
> Reviewed-on: https://chromium-review.googlesource.com/1053394
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557609}

TBR=wez@chromium.org,sergeyu@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 778467
Change-Id: I167b09be65c610fa3dde2e93e283602823be32c1
Reviewed-on: https://chromium-review.googlesource.com/1059862
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558944}
[modify] https://crrev.com/c43766666030f7416ac4456a8b915b37d0250b6c/BUILD.gn
[add] https://crrev.com/c43766666030f7416ac4456a8b915b37d0250b6c/build/fuchsia/layout_test_proxy/BUILD.gn
[add] https://crrev.com/c43766666030f7416ac4456a8b915b37d0250b6c/build/fuchsia/layout_test_proxy/DEPS
[add] https://crrev.com/c43766666030f7416ac4456a8b915b37d0250b6c/build/fuchsia/layout_test_proxy/layout_test_proxy.cc

Blockedon: 914627
Project Member

Comment 45 by bugdroid1@chromium.org, Dec 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cff12ea72d49d5839eca9e209a3fa520c308a4cc

commit cff12ea72d49d5839eca9e209a3fa520c308a4cc
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Sat Dec 22 03:14:17 2018

Fix MakeGLImage() to handle SHARED_MEMORY_BUFFER without ImageFactory

Previously SharedImageBackingFactoryGLTexture::MakeGLImage() was failing
when it didn't have ImageFactory, even when creating an image from a
shared memory buffer. Textures can be created from shared memory
without ImageFactory. Updated MakeGLImage() to handle this case
properly.

Bug: 778467
Change-Id: I43b522dbfd76dafd0aba8d95d37c3fabcaf33b0e
Reviewed-on: https://chromium-review.googlesource.com/c/1389159
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618720}
[modify] https://crrev.com/cff12ea72d49d5839eca9e209a3fa520c308a4cc/gpu/command_buffer/service/shared_image_backing_factory_gl_texture.cc

Project Member

Comment 46 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0875d122691f3dde6fa2757f1350dc6c3c4fd2a

commit f0875d122691f3dde6fa2757f1350dc6c3c4fd2a
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Jan 03 20:33:23 2019

content_shell: Destroy WebContents before calling PlatformExit().

Previously PlatformExit() was called before WebContents is destroyed. On
Fuchsia PlatformExit destroys the Screen sigleton, but WebContents
was trying to use it while destroying the window. With this change
WebContents is destroyed before the Screen.

Bug: 778467
Change-Id: I3200e9339771b001c9b8b4fe0e311b1ef42d8d01
Reviewed-on: https://chromium-review.googlesource.com/c/1389026
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619740}
[modify] https://crrev.com/f0875d122691f3dde6fa2757f1350dc6c3c4fd2a/content/shell/browser/shell.cc

Project Member

Comment 47 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db26041c8e72a32d14c1ad58aad59d954bc6b4c1

commit db26041c8e72a32d14c1ad58aad59d954bc6b4c1
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Jan 04 20:25:57 2019

[Fuchsia] Use PassThroughImageTransportSurface

Now ImageTransportSurface::CreateNativeSurface() will return an
PassThroughImageTransportSurface instance on Fuchsia same as it does on
most other platforms. Without PassThroughImageTransportSurface
pixel-based layout tests were timing out because the browser wasn't
receiving notification from the GPU process when an image is presented
(ImageTransportSurfaceDelegate::BufferPresented() was never called).

Bug: 778467
Change-Id: If71f7032662fc873ef48afa0aed88e3060f8b3f5
Reviewed-on: https://chromium-review.googlesource.com/c/1395421
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620047}
[modify] https://crrev.com/db26041c8e72a32d14c1ad58aad59d954bc6b4c1/gpu/ipc/service/image_transport_surface_fuchsia.cc

Project Member

Comment 48 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6754ba20007550f953b4ef4a9ed5983baa51ac20

commit 6754ba20007550f953b4ef4a9ed5983baa51ac20
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Jan 09 03:15:09 2019

[Fuchsia] Update Fuchsia layout tests port

Fuchsia layout tests port wasn't working with the current version of runner
scripts (because they were not enabled on the bots). Update it and the
runner scripts to make them compatible again.

Bug: 778467
Change-Id: I54d214d4fbe8b808a5ff3f4e615913cbf66a5b3a
Reviewed-on: https://chromium-review.googlesource.com/c/1396308
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621027}
[modify] https://crrev.com/6754ba20007550f953b4ef4a9ed5983baa51ac20/build/fuchsia/qemu_target.py
[modify] https://crrev.com/6754ba20007550f953b4ef4a9ed5983baa51ac20/build/fuchsia/remote_cmd.py
[modify] https://crrev.com/6754ba20007550f953b4ef4a9ed5983baa51ac20/build/fuchsia/target.py
[modify] https://crrev.com/6754ba20007550f953b4ef4a9ed5983baa51ac20/third_party/blink/tools/blinkpy/web_tests/port/fuchsia.py

Project Member

Comment 49 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/106afaeaf514462329e1955ef340ac916fd34edf

commit 106afaeaf514462329e1955ef340ac916fd34edf
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Jan 09 22:19:25 2019

[Fuchsia] Update layout tests expectations

Updated test expectations for some layout tests and also updated some tests
to pass on Fuchsia.

With this change all smoke tests run as expected on Fuchsia locally, but they
require a SwiftShader change for executable memory. Once that change is rolled
I'll enable layout tests on FYI fuchsia bots.

Bug: 778467
Change-Id: I2dfd842b6c5323f3df4c9c8e4756dce95c7b591c
Reviewed-on: https://chromium-review.googlesource.com/c/1396710
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621331}
[modify] https://crrev.com/106afaeaf514462329e1955ef340ac916fd34edf/third_party/blink/tools/blinkpy/web_tests/port/fuchsia.py
[modify] https://crrev.com/106afaeaf514462329e1955ef340ac916fd34edf/third_party/blink/web_tests/TestExpectations
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/compositing/sibling-positioning-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/css3/selectors3/html/css3-modsel-18-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/css3/selectors3/html/css3-modsel-61-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/css3/selectors3/xhtml/css3-modsel-17-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/css3/selectors3/xhtml/css3-modsel-18-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/css3/selectors3/xml/css3-modsel-17-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/css3/selectors3/xml/css3-modsel-18-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/css3/selectors3/xml/css3-modsel-61-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/execCommand/5190926-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/inserting/5156401-2-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/pasteboard/drop-text-without-selection-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/pasteboard/drop-text-without-selection-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/pasteboard/paste-line-endings-001-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/pasteboard/paste-line-endings-001-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/pasteboard/paste-line-endings-002-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/pasteboard/paste-line-endings-002-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/pasteboard/paste-line-endings-003-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/pasteboard/paste-line-endings-003-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/pasteboard/paste-line-endings-004-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/pasteboard/paste-line-endings-004-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/pasteboard/paste-line-endings-005-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/pasteboard/paste-line-endings-005-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/pasteboard/paste-text-016-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/selection/4402375-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/selection/6476-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/selection/6476-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/selection/leave-requested-block-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/selection/leave-requested-block-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/selection/previous-line-position-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/selection/previous-line-position-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/editing/style/block-styles-007-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/external/wpt/bluetooth/requestDevice/canonicalizeFilter/no-arguments.https-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/external/wpt/css/cssom/medialist-interfaces-004-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/external/wpt/custom-elements/reactions/Attr-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/external/wpt/custom-elements/reactions/Selection-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/external/wpt/dom/historical-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/external/wpt/gamepad/idlharness-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/external/wpt/input-events/idlharness-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/external/wpt/user-timing/invoke_with_timing_attributes-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/external/wpt/web-animations/interfaces/Animatable/animate-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/external/wpt/web-animations/timing-model/animations/finishing-an-animation-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/external/wpt/web-animations/timing-model/time-transformations/transformed-progress-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/backgrounds/background-clip-text-expected.png
[modify] https://crrev.com/106afaeaf514462329e1955ef340ac916fd34edf/third_party/blink/web_tests/platform/fuchsia/fast/beacon/beacon-basic-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/block/basic/018-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/block/float/002-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/block/float/centered-float-avoidance-complexity-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/block/float/float-in-float-hit-testing-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/block/float/float-in-float-painting-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/block/margin-collapse/019-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/block/margin-collapse/020-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/block/margin-collapse/block-inside-inline/019-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/block/margin-collapse/block-inside-inline/020-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css/child-style-can-override-visited-style-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css/clip-zooming-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css/compare-content-style-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css/first-letter-hover-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css/first-letter-visibility-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css/focus-ring-multiline-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css/invalid-percentage-property-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css/line-height-font-order-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css/line-thickness-underline-strikethrough-overline-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css/nth-child-dynamic-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css/text-overflow-ellipsis-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css/text-overflow-ellipsis-strict-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css3-text/css3-text-decoration/text-decoration-style-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css3-text/css3-text-decoration/text-decoration-style-inherit-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css3-text/css3-text-decoration/text-decoration-style-inherit-links-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css3-text/css3-text-decoration/text-decoration-style-inherit-not-propagated-by-out-of-flow-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/css3-text/css3-text-decoration/text-decoration-style-inherit-simple-underlines-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/events/reveal-link-when-focused-expected.png
[modify] https://crrev.com/106afaeaf514462329e1955ef340ac916fd34edf/third_party/blink/web_tests/platform/fuchsia/fast/events/simulated-click-on-anchor-with-target-blank-expected.txt
[modify] https://crrev.com/106afaeaf514462329e1955ef340ac916fd34edf/third_party/blink/web_tests/platform/fuchsia/fast/filesystem/simple-persistent-expected.txt
[modify] https://crrev.com/106afaeaf514462329e1955ef340ac916fd34edf/third_party/blink/web_tests/platform/fuchsia/fast/hidpi/clip-text-in-hidpi-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/inline-block/14498-positionForCoordinates-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/inline-block/overflow-clip-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/inline/inline-box-background-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/inline/inline-box-background-repeat-x-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/inline/inline-box-background-repeat-y-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/inline/inline-focus-ring-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/invalid/009-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/layers/normal-flow-hit-test-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/layers/opacity-transforms-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/lists/003-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/lists/scrolled-marker-paint-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/overflow/position-fixed-transform-clipping-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/replaced/selection-rect-transform-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/selectors/018-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/selectors/061-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/table/border-collapsing/004-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/text/international/001-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/text/international/bidi-LDB-2-HTML-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/text/international/bidi-LDB-2-formatting-characters-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/text/stroking-decorations-expected.png
[modify] https://crrev.com/106afaeaf514462329e1955ef340ac916fd34edf/third_party/blink/web_tests/platform/fuchsia/fast/url/invalid-urls-utf8-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/fast/writing-mode/english-lr-text-expected.png
[modify] https://crrev.com/106afaeaf514462329e1955ef340ac916fd34edf/third_party/blink/web_tests/platform/fuchsia/fast/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/paint/invalidation/outline/focus-layers-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/paint/invalidation/selection/selected-replaced-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/paint/invalidation/selection/selection-in-composited-scrolling-container-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/paint/invalidation/selection/selection-in-composited-scrolling-container-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/paint/invalidation/shadow-multiple-expected.png
[modify] https://crrev.com/106afaeaf514462329e1955ef340ac916fd34edf/third_party/blink/web_tests/platform/fuchsia/plugins/instance-available-before-stylesheets-loaded-expected.txt
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/svg/batik/text/textAnchor3-expected.png
[modify] https://crrev.com/106afaeaf514462329e1955ef340ac916fd34edf/third_party/blink/web_tests/platform/fuchsia/tables/mozilla/bugs/bug1188-expected.png
[modify] https://crrev.com/106afaeaf514462329e1955ef340ac916fd34edf/third_party/blink/web_tests/platform/fuchsia/tables/mozilla/bugs/bug2479-3-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/tables/mozilla/bugs/bug2479-4-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/tables/mozilla/bugs/bug59354-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/tables/mozilla/bugs/bug7342-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/tables/mozilla/bugs/bug8950-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/tables/mozilla/collapsing_borders/bug41262-3-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/tables/mozilla/core/bloomberg-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/tables/mozilla_expected_failures/bugs/bug1010-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/transforms/transformed-caret-expected.png
[delete] https://crrev.com/d1d72d368873aebd39537d5725de69f94d290843/third_party/blink/web_tests/platform/fuchsia/virtual/layout_ng/fast/block/margin-collapse/019-expected.png

Project Member

Comment 50 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96e39a1de42af45f5b609adf439deafd0032e55c

commit 96e39a1de42af45f5b609adf439deafd0032e55c
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Jan 11 19:57:18 2019

Roll SwiftShader f8374cf..24e7192

https://swiftshader.googlesource.com/SwiftShader.git/+log/f8374cf..24e7192

Bug: 778467

TEST=bots

CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: I4617e82b69a9b2de877c63f735d8ea461c960e57
Reviewed-on: https://chromium-review.googlesource.com/c/1406132
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622113}
[modify] https://crrev.com/96e39a1de42af45f5b609adf439deafd0032e55c/DEPS

Sign in to add a comment