New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778465 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression


Participants' hotlists:
Hotlist-1


Sign in to add a comment

word wrap doesn't wrap long strings while 'focused' in Element/Styles panel 'live edit' mode

Reported by jeremy...@gmail.com, Oct 25 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.62 Safari/537.36

Steps to reproduce the problem:
1. Dev Tools > Elements > Styles tab 
2. Create new style rule for any element in DOM
3. Type: 'background-image:'
4. and paste something like the following after the background-image property

url("data:image/svg+xml;charset=utf8,%3Csvg viewBox='0 0 68 72' xmlns='http://www.w3.org/2000/svg'%3E%3Cpath fill='%232F322B' transform='translate(13 5)' d='M53,1.1,15.5,39,0,23.4l1.1-1.1L15.5,36.9,51.9,0Z'/%3E%3C/svg%3E),url("data:image/svg+xml;charset=utf8,%3Csvg viewBox='0 0 68 72' xmlns='http://www.w3.org/2000/svg'%3E%3Cpath fill='%23FFF' transform='translate(0 10)' d='M0,30a30,30 0 1,0 60,0a30,30 0 1,0 -60,0'/%3E%3C/svg%3E)

5. Focus out of the panel and notice the url string pasted wraps just fine within the panel container
6. Focus/click back on the string as if to edit and note the wrapping goes away.

What is the expected behavior?
When user click/focus's on string, wrap it within the confines of container.

What went wrong?
String loses word wrap formatting and now user has to arrow left/right in order to edit parts of string that exist beyond containers border.

Did this work before? No 

Chrome version: 62.0.3202.62  Channel: stable
OS Version: OS X 10.11.6
Flash Version: 

This can be a time suck when dealing with long strings - either in a 'live-edit' context or when tracking down 1-2 character substrings within
 
chrome-developer-styles-no-wordwrap.swf
1015 KB Download
Labels: Needs-Triage-M62
Cc: sc00335...@techmahindra.com
Labels: -Type-Bug -Pri-2 hasbisect-per-revision Triaged-ET M-64 OS-Linux OS-Windows Pri-1 Type-Bug-Regression
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on reported version 62.0.3202.62 and on latest canary 64.0.3253.0 using Ubuntu 14.04,MAc 10.12.6 and Windows 10 with steps mentioned in comment#0.

Manual Bisect Info:
===============
Good Build:55.0.2866.0 
Bad Build: 55.0.2867.0 

You are probably looking for a change made after 419835 (known good), but no later than 419836 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/757046435088c8630dd67a8abffa44dbfc079a3f..5b494767ab26e78c514244b4cf3d1e8fda2c7e77

Review-Url: https://codereview.chromium.org/2327983002

Suspecting same from changelog.

@dgozman: Please confirm the bug and help in re-assigning if it is not related to your change.

Thanks!

Owner: einbinder@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84a6e8e3bcf56988a496cc9e286fd55800fc5576

commit 84a6e8e3bcf56988a496cc9e286fd55800fc5576
Author: Joel Einbinder <einbinder@chromium.org>
Date: Fri Nov 10 22:14:34 2017

DevTools: Wrap lines when editing css in styles sidebar

Bug:  778465 
Change-Id: I3c4dac92b6c532058f6994ebe3cb12fc267dc8ed
Reviewed-on: https://chromium-review.googlesource.com/761257
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515710}
[modify] https://crrev.com/84a6e8e3bcf56988a496cc9e286fd55800fc5576/third_party/WebKit/Source/devtools/front_end/elements/stylesSectionTree.css

Labels: TE-Verified-M64 TE-Verified-64.0.3267.0
Tested the  issue #64 .0.3267.0 on Win 10 and Linux Ubuntu 14.04 as per the steps mentioned in comment#0. Observed the fix is working as expected

Please find the screencast. Hence adding Verified labels.

Note: Mac build got failed for #64.0.3267.0. Hence verified in other OS's

Thanks!!


778465.webm
2.8 MB View Download
Issue has been fixed in #64.0.3265.0 on Mac 10.12.6 as well.

Please find the screencast.

Thanks!!
778465_Mac.webm
2.0 MB View Download

Comment 7 by jeremy...@gmail.com, Feb 16 2018

FYI (from the original submitter) this appears to be fixed on:
 mac os 10.11.6
 64.0.3282.167

Thank you!


Status: Fixed (was: Assigned)

Sign in to add a comment