New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778461 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Last visit 25 days ago
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Experiment with tab organization

Project Member Reported by brettw@chromium.org, Oct 25 2017

Issue description

This is a tracking bug for some investigations.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bf4fa875c1bbec14ea870e256ac82cf84396f48

commit 0bf4fa875c1bbec14ea870e256ac82cf84396f48
Author: Brett Wilson <brettw@chromium.org>
Date: Thu Oct 26 19:05:52 2017

Virtualize TabStripModel interface

This will facilitate replacing the model with a different implementation
for some experimentation I will be doing.

There should be no behavior change from this patch.

Bug:  778461 
Change-Id: Ib37e7bb2724f0a9f64a7923817f07fff44dd60ce
Reviewed-on: https://chromium-review.googlesource.com/737580
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511909}
[modify] https://crrev.com/0bf4fa875c1bbec14ea870e256ac82cf84396f48/chrome/browser/resource_coordinator/tab_manager_unittest.cc
[modify] https://crrev.com/0bf4fa875c1bbec14ea870e256ac82cf84396f48/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/0bf4fa875c1bbec14ea870e256ac82cf84396f48/chrome/browser/ui/browser.cc
[modify] https://crrev.com/0bf4fa875c1bbec14ea870e256ac82cf84396f48/chrome/browser/ui/content_settings/content_setting_image_model_browsertest.cc
[modify] https://crrev.com/0bf4fa875c1bbec14ea870e256ac82cf84396f48/chrome/browser/ui/tabs/tab_strip_model.cc
[modify] https://crrev.com/0bf4fa875c1bbec14ea870e256ac82cf84396f48/chrome/browser/ui/tabs/tab_strip_model.h
[add] https://crrev.com/0bf4fa875c1bbec14ea870e256ac82cf84396f48/chrome/browser/ui/tabs/tab_strip_model_impl.cc
[add] https://crrev.com/0bf4fa875c1bbec14ea870e256ac82cf84396f48/chrome/browser/ui/tabs/tab_strip_model_impl.h
[rename] https://crrev.com/0bf4fa875c1bbec14ea870e256ac82cf84396f48/chrome/browser/ui/tabs/tab_strip_model_impl_unittest.cc
[modify] https://crrev.com/0bf4fa875c1bbec14ea870e256ac82cf84396f48/chrome/browser/ui/tabs/tab_strip_model_stats_recorder_unittest.cc
[modify] https://crrev.com/0bf4fa875c1bbec14ea870e256ac82cf84396f48/chrome/test/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4d5877181300733fcf1a9a7aa97b3ae146b4eb2

commit f4d5877181300733fcf1a9a7aa97b3ae146b4eb2
Author: Brett Wilson <brettw@chromium.org>
Date: Mon Oct 30 21:37:57 2017

Add a command line switch for tab experimentation.

This is currently unused. I will use it in a follow-up patch to control
some tab experiments I will be doing.

Bug:  778461 
Change-Id: Iec9a72c6bc682719f45a619f0a3bd752eebbfae5
Reviewed-on: https://chromium-review.googlesource.com/740950
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512632}
[modify] https://crrev.com/f4d5877181300733fcf1a9a7aa97b3ae146b4eb2/chrome/browser/about_flags.cc
[modify] https://crrev.com/f4d5877181300733fcf1a9a7aa97b3ae146b4eb2/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/f4d5877181300733fcf1a9a7aa97b3ae146b4eb2/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/f4d5877181300733fcf1a9a7aa97b3ae146b4eb2/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/f4d5877181300733fcf1a9a7aa97b3ae146b4eb2/chrome/browser/ui/tabs/tab_features.cc
[add] https://crrev.com/f4d5877181300733fcf1a9a7aa97b3ae146b4eb2/chrome/browser/ui/tabs/tab_features.h
[modify] https://crrev.com/f4d5877181300733fcf1a9a7aa97b3ae146b4eb2/tools/metrics/histograms/README.md
[modify] https://crrev.com/f4d5877181300733fcf1a9a7aa97b3ae146b4eb2/tools/metrics/histograms/enums.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dc8ed2d0c4c0d06b189f26a425741b701374c4b

commit 4dc8ed2d0c4c0d06b189f26a425741b701374c4b
Author: Brett Wilson <brettw@chromium.org>
Date: Mon Oct 30 22:48:22 2017

Add experimental tab controller.

It is currently disabled but most of the mechanics to create this
are hooked up. This patch should have no behavior change.

Make the TabStripModelOrderController refer to the Impl and not the
abstract TabStripModel base since it's really a part of the
implementation. This allows a number of ordering-related functions
to be moved only to the Impl.

Remove comments in tab_strip_model_impl.h that duplicate those in
tab_strip_model.h. Make ConstrainInsertionIndex private since it was
not used by any external caller.

Bug:  778461 
Change-Id: I63fa9dcbf62a02ff332c73234b457d33b81d9667
Reviewed-on: https://chromium-review.googlesource.com/742642
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512655}
[modify] https://crrev.com/4dc8ed2d0c4c0d06b189f26a425741b701374c4b/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/4dc8ed2d0c4c0d06b189f26a425741b701374c4b/chrome/browser/ui/browser.cc
[modify] https://crrev.com/4dc8ed2d0c4c0d06b189f26a425741b701374c4b/chrome/browser/ui/tabs/tab_features.cc
[modify] https://crrev.com/4dc8ed2d0c4c0d06b189f26a425741b701374c4b/chrome/browser/ui/tabs/tab_features.h
[modify] https://crrev.com/4dc8ed2d0c4c0d06b189f26a425741b701374c4b/chrome/browser/ui/tabs/tab_strip_model.h
[add] https://crrev.com/4dc8ed2d0c4c0d06b189f26a425741b701374c4b/chrome/browser/ui/tabs/tab_strip_model_experimental.cc
[add] https://crrev.com/4dc8ed2d0c4c0d06b189f26a425741b701374c4b/chrome/browser/ui/tabs/tab_strip_model_experimental.h
[modify] https://crrev.com/4dc8ed2d0c4c0d06b189f26a425741b701374c4b/chrome/browser/ui/tabs/tab_strip_model_impl.cc
[modify] https://crrev.com/4dc8ed2d0c4c0d06b189f26a425741b701374c4b/chrome/browser/ui/tabs/tab_strip_model_impl.h
[modify] https://crrev.com/4dc8ed2d0c4c0d06b189f26a425741b701374c4b/chrome/browser/ui/tabs/tab_strip_model_impl_unittest.cc
[modify] https://crrev.com/4dc8ed2d0c4c0d06b189f26a425741b701374c4b/chrome/browser/ui/tabs/tab_strip_model_order_controller.cc
[modify] https://crrev.com/4dc8ed2d0c4c0d06b189f26a425741b701374c4b/chrome/browser/ui/tabs/tab_strip_model_order_controller.h

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1af64884f9eeb2575a823405185c85d38b725b0a

commit 1af64884f9eeb2575a823405185c85d38b725b0a
Author: Brett Wilson <brettw@chromium.org>
Date: Wed Nov 01 04:59:17 2017

Add minimally functional experimental tab controller.

Enables the --experimental-tab-controlelr flag to use the new code path.
Just enough is implemented to allow the tab strip to show and not crash.

Changed the NotifyTypes enum in the TabStripModelImpl to use the latest
style.

Bug:  778461 
Change-Id: I6e124044b0318c2d6b250ad86f796d570067e81a
Reviewed-on: https://chromium-review.googlesource.com/747628
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513076}
[modify] https://crrev.com/1af64884f9eeb2575a823405185c85d38b725b0a/chrome/browser/ui/tabs/tab_features.cc
[modify] https://crrev.com/1af64884f9eeb2575a823405185c85d38b725b0a/chrome/browser/ui/tabs/tab_strip_model_experimental.cc
[modify] https://crrev.com/1af64884f9eeb2575a823405185c85d38b725b0a/chrome/browser/ui/tabs/tab_strip_model_experimental.h
[modify] https://crrev.com/1af64884f9eeb2575a823405185c85d38b725b0a/chrome/browser/ui/tabs/tab_strip_model_impl.cc
[modify] https://crrev.com/1af64884f9eeb2575a823405185c85d38b725b0a/chrome/browser/ui/tabs/tab_strip_model_impl.h

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73b0bd44d8b08c147bf2c1710914695d8b05cfe1

commit 73b0bd44d8b08c147bf2c1710914695d8b05cfe1
Author: Brett Wilson <brettw@chromium.org>
Date: Sat Nov 04 00:47:38 2017

Virtualize the TabStrip object.

Replaces the current TabStrip with a virtual base class, and moves the
code to a new TabStripImpl. This is to allow replacing the tab strip
with an experimental version.

Bug:  778461 
Change-Id: I6ee19c8b15402da5221ad21de197c4f39ae2191e
Reviewed-on: https://chromium-review.googlesource.com/752580
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513994}
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/feature_engagement/new_tab/new_tab_tracker_browsertest.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/tabs/tab_features.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/tabs/tab_features.h
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/ash/tab_scrubber.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/ash/tab_scrubber.h
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/feature_promos/new_tab_promo_dialog_browsertest.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/frame/browser_view_browsertest.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/frame/browser_view_layout_unittest.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/alert_indicator_button_unittest.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/new_tab_button.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/new_tab_button.h
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/tab_drag_controller.h
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/tab_strip_controller.h
[add] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/tab_strip_impl.cc
[add] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/tab_strip_impl.h
[rename] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/browser/ui/views/tabs/tab_strip_impl_unittest.cc
[modify] https://crrev.com/73b0bd44d8b08c147bf2c1710914695d8b05cfe1/chrome/test/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76

commit ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76
Author: Brett Wilson <brettw@chromium.org>
Date: Fri Nov 10 02:54:18 2017

Implement basic experimental tab strip.

Creates a new view for rendering the experimental tab strip and tabs.
The experimental tabs use rendering code copied from the regular tab
strip.

Currently it's pretty broken but new tabs do show up and the title
updates. No mouse events are supported. This is really a skeleton for
future additions.

Minor C++11 improvements to TabStripImpl.

Also fixes a model dialog initialization crash with the experimental
tab strip.

Bug:  778461 , 780932
Change-Id: Icba2048e8f5abb3b10907456d7f093e4074a8cad
Reviewed-on: https://chromium-review.googlesource.com/755623
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515434}
[modify] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/tabs/tab_data_experimental.cc
[add] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/tabs/tab_data_experimental.h
[modify] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/tabs/tab_strip_model.h
[modify] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/tabs/tab_strip_model_experimental.cc
[modify] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/tabs/tab_strip_model_experimental.h
[add] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/tabs/tab_strip_model_experimental_observer.h
[modify] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/tabs/tab_strip_model_impl.cc
[modify] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/tabs/tab_strip_model_impl.h
[modify] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/views/tabs/tab.cc
[add] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/views/tabs/tab_experimental.cc
[add] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/views/tabs/tab_experimental.h
[add] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/views/tabs/tab_strip_experimental.cc
[add] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/views/tabs/tab_strip_experimental.h
[modify] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/views/tabs/tab_strip_impl.cc
[modify] https://crrev.com/ee5fc7dddbdc9c5a76857c7524a418cb6cb13f76/chrome/browser/ui/views/tabs/tab_strip_impl.h

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1778be8ecef2233113d0e5472ed741fb41ca0b5

commit b1778be8ecef2233113d0e5472ed741fb41ca0b5
Author: Brett Wilson <brettw@chromium.org>
Date: Thu Nov 16 02:09:02 2017

Enhance the experimental tab controller.

Make the grouping primitives more robust (although they are currently
still unused). Since external users of the tab strip model depend on
indices, this adds a concept of "view index" to the model for backward
compatibility. This maps to what users expect when pressing Control-#.

Update the tab strip to refer to the model by TabDataExperimental
pointers rather than model indices. This will allow us to be more
flexible about how the model is represented and how it maps onto the
tab strip.

Update tab_strip_impl.cc to use make_unique and add some comments.

Bug:  778461 
Change-Id: Idbdd19ed40119a43c670ed0b3fef272e130555b7
Reviewed-on: https://chromium-review.googlesource.com/765213
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516955}
[modify] https://crrev.com/b1778be8ecef2233113d0e5472ed741fb41ca0b5/chrome/browser/sessions/session_restore.cc
[modify] https://crrev.com/b1778be8ecef2233113d0e5472ed741fb41ca0b5/chrome/browser/ui/tabs/tab_data_experimental.cc
[modify] https://crrev.com/b1778be8ecef2233113d0e5472ed741fb41ca0b5/chrome/browser/ui/tabs/tab_data_experimental.h
[modify] https://crrev.com/b1778be8ecef2233113d0e5472ed741fb41ca0b5/chrome/browser/ui/tabs/tab_strip_model_experimental.cc
[modify] https://crrev.com/b1778be8ecef2233113d0e5472ed741fb41ca0b5/chrome/browser/ui/tabs/tab_strip_model_experimental.h
[modify] https://crrev.com/b1778be8ecef2233113d0e5472ed741fb41ca0b5/chrome/browser/ui/tabs/tab_strip_model_experimental_observer.h
[add] https://crrev.com/b1778be8ecef2233113d0e5472ed741fb41ca0b5/chrome/browser/ui/tabs/tab_strip_model_experimental_unittest.cc
[modify] https://crrev.com/b1778be8ecef2233113d0e5472ed741fb41ca0b5/chrome/browser/ui/tabs/tab_strip_model_impl.cc
[modify] https://crrev.com/b1778be8ecef2233113d0e5472ed741fb41ca0b5/chrome/browser/ui/views/tabs/tab_experimental.cc
[modify] https://crrev.com/b1778be8ecef2233113d0e5472ed741fb41ca0b5/chrome/browser/ui/views/tabs/tab_experimental.h
[modify] https://crrev.com/b1778be8ecef2233113d0e5472ed741fb41ca0b5/chrome/browser/ui/views/tabs/tab_strip_experimental.cc
[modify] https://crrev.com/b1778be8ecef2233113d0e5472ed741fb41ca0b5/chrome/browser/ui/views/tabs/tab_strip_experimental.h
[modify] https://crrev.com/b1778be8ecef2233113d0e5472ed741fb41ca0b5/chrome/browser/ui/views/tabs/tab_strip_impl.cc
[modify] https://crrev.com/b1778be8ecef2233113d0e5472ed741fb41ca0b5/chrome/test/BUILD.gn

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/105ce4652e0a6bff95fd22830a9cef03fb71f70e

commit 105ce4652e0a6bff95fd22830a9cef03fb71f70e
Author: Brett Wilson <brettw@chromium.org>
Date: Mon Nov 20 20:30:32 2017

Add basic grouing features.

Adds simple opener-based grouping to the experimental tab controller.

Clicks are not handled for activation. Tabs are rendered overlapped
properly.

Bug:  778461 
Change-Id: Ic93cb109875d815018a6197e35b10b358959ac02
Reviewed-on: https://chromium-review.googlesource.com/777735
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517913}
[modify] https://crrev.com/105ce4652e0a6bff95fd22830a9cef03fb71f70e/chrome/browser/ui/tabs/tab_data_experimental.cc
[modify] https://crrev.com/105ce4652e0a6bff95fd22830a9cef03fb71f70e/chrome/browser/ui/tabs/tab_data_experimental.h
[modify] https://crrev.com/105ce4652e0a6bff95fd22830a9cef03fb71f70e/chrome/browser/ui/tabs/tab_strip_model_experimental.cc
[modify] https://crrev.com/105ce4652e0a6bff95fd22830a9cef03fb71f70e/chrome/browser/ui/tabs/tab_strip_model_experimental.h
[modify] https://crrev.com/105ce4652e0a6bff95fd22830a9cef03fb71f70e/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/105ce4652e0a6bff95fd22830a9cef03fb71f70e/chrome/browser/ui/views/tabs/tab_experimental.cc
[modify] https://crrev.com/105ce4652e0a6bff95fd22830a9cef03fb71f70e/chrome/browser/ui/views/tabs/tab_experimental.h
[modify] https://crrev.com/105ce4652e0a6bff95fd22830a9cef03fb71f70e/chrome/browser/ui/views/tabs/tab_experimental_paint.cc
[modify] https://crrev.com/105ce4652e0a6bff95fd22830a9cef03fb71f70e/chrome/browser/ui/views/tabs/tab_experimental_paint.h
[modify] https://crrev.com/105ce4652e0a6bff95fd22830a9cef03fb71f70e/chrome/browser/ui/views/tabs/tab_strip_experimental.cc
[modify] https://crrev.com/105ce4652e0a6bff95fd22830a9cef03fb71f70e/chrome/browser/ui/views/tabs/tab_strip_experimental.h
[modify] https://crrev.com/105ce4652e0a6bff95fd22830a9cef03fb71f70e/chrome/browser/ui/views/tabs/tab_strip_impl.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/978598e8f12159e7842154575396895300a3bd06

commit 978598e8f12159e7842154575396895300a3bd06
Author: Brett Wilson <brettw@chromium.org>
Date: Tue Nov 28 02:11:37 2017

Convert TabChangeType to a toplevel enum class.

Previously this was an enum declared in the TabStripModelObserver class. This
was incorrect layering since it was used by calls into the TabStripModel, which
shouldn't depend on that class' own observer definition.

With the experimental tab strip, the need for this enum to be at a more
fundamental layer becomes more obvious. This change adds the change type to the
experimental tab strip observer and uses it.

Bug:  778461 
Change-Id: I12921deea21e264d7f7b883fd2c4c1557022eb61
Reviewed-on: https://chromium-review.googlesource.com/791990
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519524}
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/metrics/desktop_session_duration/audible_contents_tracker.cc
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/browser.cc
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/cocoa/tabs/tab_strip_controller.h
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm
[add] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/tabs/tab_change_type.h
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/tabs/tab_strip_model.h
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/tabs/tab_strip_model_experimental.cc
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/tabs/tab_strip_model_experimental.h
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/tabs/tab_strip_model_experimental_observer.h
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/tabs/tab_strip_model_impl.cc
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/tabs/tab_strip_model_impl.h
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/tabs/tab_strip_model_impl_unittest.cc
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/tabs/tab_strip_model_observer.h
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/views/tabs/tab_experimental.cc
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/views/tabs/tab_experimental.h
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/views/tabs/tab_strip_experimental.cc
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/ui/views/tabs/tab_strip_experimental.h
[modify] https://crrev.com/978598e8f12159e7842154575396895300a3bd06/chrome/browser/usb/usb_tab_helper.cc

Cc: jayhlee@chromium.org
 Issue 788863  has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be4fd99b6ca8143922a7949b961b7b736a0ff0b2

commit be4fd99b6ca8143922a7949b961b7b736a0ff0b2
Author: Brett Wilson <brettw@chromium.org>
Date: Fri Dec 01 21:46:21 2017

Hook up favicons and throbbers to experimental tabs.

This adds the new TabIcon view to the TabExperimental class and adds the
associated plumbing to hook up the basic favicon and throb functionality.

Rename experimental observer variables to help differentiate from the
regular observers.

Bug:  778461 
Change-Id: I56a67a6f14d4003ee49818568bb59298e15bf1b8
Reviewed-on: https://chromium-review.googlesource.com/804206
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521072}
[modify] https://crrev.com/be4fd99b6ca8143922a7949b961b7b736a0ff0b2/chrome/browser/ui/tabs/tab_data_experimental.cc
[modify] https://crrev.com/be4fd99b6ca8143922a7949b961b7b736a0ff0b2/chrome/browser/ui/tabs/tab_data_experimental.h
[modify] https://crrev.com/be4fd99b6ca8143922a7949b961b7b736a0ff0b2/chrome/browser/ui/tabs/tab_strip_model_experimental.cc
[modify] https://crrev.com/be4fd99b6ca8143922a7949b961b7b736a0ff0b2/chrome/browser/ui/views/tabs/tab_experimental.cc
[modify] https://crrev.com/be4fd99b6ca8143922a7949b961b7b736a0ff0b2/chrome/browser/ui/views/tabs/tab_experimental.h
[modify] https://crrev.com/be4fd99b6ca8143922a7949b961b7b736a0ff0b2/chrome/browser/ui/views/tabs/tab_strip_experimental.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3db85d7b9265b63698e17cb3b51ff60f7240c6e2

commit 3db85d7b9265b63698e17cb3b51ff60f7240c6e2
Author: Brett Wilson <brettw@chromium.org>
Date: Fri Dec 01 22:50:33 2017

Remove redundant SchedulePaint call.

The TabIcon will schedule its own painting when its state changes.

This call was left from a previous iteration where it did not do so.

Bug:  778461 
Change-Id: I351f2c2e6e11c9ab942c98ccb3e002fd8cbfb67f
Reviewed-on: https://chromium-review.googlesource.com/804239
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521098}
[modify] https://crrev.com/3db85d7b9265b63698e17cb3b51ff60f7240c6e2/chrome/browser/ui/views/tabs/tab.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb077df369fc4e353273aa78c4c91ab255880902

commit eb077df369fc4e353273aa78c4c91ab255880902
Author: Brett Wilson <brettw@chromium.org>
Date: Tue Jan 09 02:57:23 2018

Remove experimental tab strip.

This direction does not seem to be fruitful. The experimental code and flag is
removed.

The TabStrip classes will be de-virtualized in a followup.

Bug:  778461 
Change-Id: Ie31fc2d3fa373f09f279edef6559d71489affc87
Reviewed-on: https://chromium-review.googlesource.com/854556
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527879}
[modify] https://crrev.com/eb077df369fc4e353273aa78c4c91ab255880902/chrome/browser/about_flags.cc
[modify] https://crrev.com/eb077df369fc4e353273aa78c4c91ab255880902/chrome/browser/feature_engagement/new_tab/new_tab_tracker_browsertest.cc
[modify] https://crrev.com/eb077df369fc4e353273aa78c4c91ab255880902/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/eb077df369fc4e353273aa78c4c91ab255880902/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/eb077df369fc4e353273aa78c4c91ab255880902/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/eb077df369fc4e353273aa78c4c91ab255880902/chrome/browser/ui/ash/tab_scrubber_browsertest.cc
[modify] https://crrev.com/eb077df369fc4e353273aa78c4c91ab255880902/chrome/browser/ui/browser.cc
[delete] https://crrev.com/45255b6155dfcbe09256f6149d8ce9818340322c/chrome/browser/ui/tabs/tab_data_experimental.cc
[delete] https://crrev.com/45255b6155dfcbe09256f6149d8ce9818340322c/chrome/browser/ui/tabs/tab_data_experimental.h
[delete] https://crrev.com/45255b6155dfcbe09256f6149d8ce9818340322c/chrome/browser/ui/tabs/tab_features.cc
[delete] https://crrev.com/45255b6155dfcbe09256f6149d8ce9818340322c/chrome/browser/ui/tabs/tab_features.h
[delete] https://crrev.com/45255b6155dfcbe09256f6149d8ce9818340322c/chrome/browser/ui/tabs/tab_strip_model_experimental.cc
[delete] https://crrev.com/45255b6155dfcbe09256f6149d8ce9818340322c/chrome/browser/ui/tabs/tab_strip_model_experimental.h
[delete] https://crrev.com/45255b6155dfcbe09256f6149d8ce9818340322c/chrome/browser/ui/tabs/tab_strip_model_experimental_observer.h
[delete] https://crrev.com/45255b6155dfcbe09256f6149d8ce9818340322c/chrome/browser/ui/tabs/tab_strip_model_experimental_unittest.cc
[modify] https://crrev.com/eb077df369fc4e353273aa78c4c91ab255880902/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/eb077df369fc4e353273aa78c4c91ab255880902/chrome/browser/ui/views/frame/browser_view_browsertest.cc
[modify] https://crrev.com/eb077df369fc4e353273aa78c4c91ab255880902/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
[modify] https://crrev.com/eb077df369fc4e353273aa78c4c91ab255880902/chrome/browser/ui/views/tabs/new_tab_button.cc
[modify] https://crrev.com/eb077df369fc4e353273aa78c4c91ab255880902/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/eb077df369fc4e353273aa78c4c91ab255880902/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[delete] https://crrev.com/45255b6155dfcbe09256f6149d8ce9818340322c/chrome/browser/ui/views/tabs/tab_experimental.cc
[delete] https://crrev.com/45255b6155dfcbe09256f6149d8ce9818340322c/chrome/browser/ui/views/tabs/tab_experimental.h
[delete] https://crrev.com/45255b6155dfcbe09256f6149d8ce9818340322c/chrome/browser/ui/views/tabs/tab_experimental_paint.cc
[delete] https://crrev.com/45255b6155dfcbe09256f6149d8ce9818340322c/chrome/browser/ui/views/tabs/tab_experimental_paint.h
[delete] https://crrev.com/45255b6155dfcbe09256f6149d8ce9818340322c/chrome/browser/ui/views/tabs/tab_strip_experimental.cc
[delete] https://crrev.com/45255b6155dfcbe09256f6149d8ce9818340322c/chrome/browser/ui/views/tabs/tab_strip_experimental.h
[modify] https://crrev.com/eb077df369fc4e353273aa78c4c91ab255880902/chrome/test/BUILD.gn

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba86bcf77ab1798cec705ee36756e6ac230904a6

commit ba86bcf77ab1798cec705ee36756e6ac230904a6
Author: Brett Wilson <brettw@chromium.org>
Date: Tue Jan 09 04:14:46 2018

De-virtualize TabStrip.

The experimental tab strip has been removed so TabStrip and TabStripImpl can be
re-merged into one non-virtual class.

Bug:  778461 
Change-Id: Id5fd6dfba10bb326b96240d598f7fea919ec3a42
Reviewed-on: https://chromium-review.googlesource.com/854747
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527895}
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/feature_engagement/new_tab/new_tab_tracker_browsertest.cc
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/ash/tab_scrubber.cc
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/ash/tab_scrubber.h
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/ash/tab_scrubber_browsertest.cc
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/feature_promos/new_tab_promo_dialog_browsertest.cc
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/frame/browser_view_browsertest.cc
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/frame/browser_view_layout_unittest.cc
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/tabs/alert_indicator_button_unittest.cc
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/tabs/new_tab_button.cc
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/tabs/new_tab_button.h
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/tabs/tab_drag_controller.h
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/tabs/tab_strip_controller.h
[delete] https://crrev.com/f1bd9955c88818a0ef08854dcda1dff782d605d7/chrome/browser/ui/views/tabs/tab_strip_impl.cc
[delete] https://crrev.com/f1bd9955c88818a0ef08854dcda1dff782d605d7/chrome/browser/ui/views/tabs/tab_strip_impl.h
[modify] https://crrev.com/ba86bcf77ab1798cec705ee36756e6ac230904a6/chrome/browser/ui/views/tabs/tab_strip_impl_unittest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c559bd5b8a588efe4009bcb84597bb1b68735c31

commit c559bd5b8a588efe4009bcb84597bb1b68735c31
Author: Brett Wilson <brettw@chromium.org>
Date: Tue Jan 09 05:05:36 2018

De-virtualize TabStripModel.

The experimental tab strip has been removed so TabStrip and TabStripImpl can be
re-merged into one non-virtual class.

Bug:778461

Change-Id: I828052aa0e969d5e52f881a9c48d933da5c7373b
Reviewed-on: https://chromium-review.googlesource.com/854778
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527905}
[modify] https://crrev.com/c559bd5b8a588efe4009bcb84597bb1b68735c31/chrome/browser/resource_coordinator/tab_lifecycle_unit_source_unittest.cc
[modify] https://crrev.com/c559bd5b8a588efe4009bcb84597bb1b68735c31/chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
[modify] https://crrev.com/c559bd5b8a588efe4009bcb84597bb1b68735c31/chrome/browser/resource_coordinator/tab_manager_unittest.cc
[modify] https://crrev.com/c559bd5b8a588efe4009bcb84597bb1b68735c31/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/c559bd5b8a588efe4009bcb84597bb1b68735c31/chrome/browser/ui/browser.cc
[modify] https://crrev.com/c559bd5b8a588efe4009bcb84597bb1b68735c31/chrome/browser/ui/tabs/tab_strip_model.cc
[modify] https://crrev.com/c559bd5b8a588efe4009bcb84597bb1b68735c31/chrome/browser/ui/tabs/tab_strip_model.h
[delete] https://crrev.com/577dabea789a3e6b42c4072e4ad63fa411b2f3f2/chrome/browser/ui/tabs/tab_strip_model_impl.cc
[delete] https://crrev.com/577dabea789a3e6b42c4072e4ad63fa411b2f3f2/chrome/browser/ui/tabs/tab_strip_model_impl.h
[modify] https://crrev.com/c559bd5b8a588efe4009bcb84597bb1b68735c31/chrome/browser/ui/tabs/tab_strip_model_order_controller.cc
[modify] https://crrev.com/c559bd5b8a588efe4009bcb84597bb1b68735c31/chrome/browser/ui/tabs/tab_strip_model_order_controller.h
[modify] https://crrev.com/c559bd5b8a588efe4009bcb84597bb1b68735c31/chrome/browser/ui/tabs/tab_strip_model_stats_recorder_unittest.cc
[rename] https://crrev.com/c559bd5b8a588efe4009bcb84597bb1b68735c31/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
[modify] https://crrev.com/c559bd5b8a588efe4009bcb84597bb1b68735c31/chrome/browser/ui/tabs/web_contents_closer.cc
[modify] https://crrev.com/c559bd5b8a588efe4009bcb84597bb1b68735c31/chrome/test/BUILD.gn

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97b594fa29f0a66650ae5fb2c082b8fb2d152b4a

commit 97b594fa29f0a66650ae5fb2c082b8fb2d152b4a
Author: Robert Liao <robliao@chromium.org>
Date: Mon Jan 22 19:09:11 2018

Add a Flag to Force Stacked Tab Strip Layout

This allows for others to easily see the stacked tab behavior outside
of ChromeOS.

BUG= 778461 

Change-Id: I70c1c01293e7008f88adb972a7bcb136c33b69b4
Reviewed-on: https://chromium-review.googlesource.com/877333
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530935}
[modify] https://crrev.com/97b594fa29f0a66650ae5fb2c082b8fb2d152b4a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/97b594fa29f0a66650ae5fb2c082b8fb2d152b4a/chrome/common/chrome_switches.cc
[modify] https://crrev.com/97b594fa29f0a66650ae5fb2c082b8fb2d152b4a/chrome/common/chrome_switches.h

I am not religious, but I have to thank god (and whoever decided it) for having a flag again to put Stacked Tabs back to non-touch platforms, even it is only temporary.
I know I really shouldn't add noise here, but I can't help... Apologize and again, gratitude.

Now only hope it is not TOO temporary...
Status: Fixed (was: Started)
Experimentation over, this bug isn't tracking anything any more.

Sign in to add a comment