New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778460 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

afdo: wrong profile chosen for kernel

Project Member Reported by laszio@chromium.org, Oct 25 2017

Issue description

R63 branch picked R64 profiles.
 

Comment 1 by laszio@chromium.org, Oct 25 2017

Cc: vapier@chromium.org
Fix is here

(master)
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/738869

(cherry-picked to R63)
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/738674

Luckily, the profiles for R63 and R64 are the same for now.
Labels: Build-Toolchain

Comment 3 by gmx@chromium.org, Oct 26 2017

The automation is using the chrome branch in place of the ChromeOS milestone?
I know that they should track each other closely, but I've seen cases where they are not equal.
The branch number that I include in the profile names is the ChromeOS milestone.

The build system doesn't know the CrOS milestone it is building for?

Comment 4 by laszio@chromium.org, Oct 26 2017

Labels: Merge-Request-63
It looks to me that version_info.chrome_branch is the Chrome OS milestone:
https://cs.corp.google.com/chromeos_public/chromite/cbuildbot/stages/report_stages.py?type=cs&q=CHROME_BRANCH&l=438
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/aa0da89d125cedfb7933fb38840e13e43a0a0d9c

commit aa0da89d125cedfb7933fb38840e13e43a0a0d9c
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Thu Oct 26 04:59:02 2017

kernel_afdo: cast chrome_version to int

It was passed to afdo.FindLatestProfile in string. Because,
for example, '63' > 64 in python (str > int), FindLatestProfile
always returns the profile of latest Chrome branch.

BUG= chromium:778460 
TEST=cros tryjob master-chrome-pfq

Change-Id: Ie0bbb38604aa20a6d095002d30b728270ea17a5b
Reviewed-on: https://chromium-review.googlesource.com/738869
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/aa0da89d125cedfb7933fb38840e13e43a0a0d9c/cbuildbot/stages/afdo_stages.py

Comment 6 by vapier@chromium.org, Oct 26 2017

cbuildbot should have access to all the version fields as it exists in the tree:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/master/chromeos/config/chromeos_version.sh

look at the GetVersionInfo helper which returns a VersionInfo object which has both the Chrome and Chrome OS version components.

(which is what the code in question is doing already)

Comment 7 by gkihumba@google.com, Oct 26 2017

Labels: -Merge-Request-63 Merge-Approved-63
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 26 2017

Labels: merge-merged-release-R63-10032.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9bb6df2b7dd45b68c481f698bce312383e46d2ae

commit 9bb6df2b7dd45b68c481f698bce312383e46d2ae
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Thu Oct 26 17:33:32 2017

kernel_afdo: cast chrome_version to int

It was passed to afdo.FindLatestProfile in string. Because,
for example, '63' > 64 in python (str > int), FindLatestProfile
always returns the profile of latest Chrome branch.

BUG= chromium:778460 
TEST=cros tryjob master-chrome-pfq

Change-Id: Ie0bbb38604aa20a6d095002d30b728270ea17a5b
Reviewed-on: https://chromium-review.googlesource.com/738674
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/9bb6df2b7dd45b68c481f698bce312383e46d2ae/cbuildbot/stages/afdo_stages.py

Comment 9 by laszio@chromium.org, Oct 27 2017

Status: Fixed (was: Started)
Project Member

Comment 10 by sheriffbot@chromium.org, Oct 30 2017

Cc: gkihumba@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-63
Status: Verified (was: Fixed)

Sign in to add a comment