Eng tracking for issue 773749
Is there a design doc for this?
yes, go/cros-keyboard-window-movement
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47c04677d74752db53c79b73f49e0e04e9f82c9c commit 47c04677d74752db53c79b73f49e0e04e9f82c9c Author: Qiang Xu <warx@chromium.org> Date: Thu Nov 09 03:01:37 2017 cros: keyboard shortcuts to move active window between displays design doc: go/cros-keyboard-window-movement changes: - Add keyboard shortcuts (Search + Alt + Arrow Keys) for moving active window between displays. - Candidate displays should be completely off the bounds of original display in the moving direction or cycled direction. - It will try to find the displays in the direction provided, if not found, then the displays in the cycled direction. - First, try to find the least apart distance in the given direction or cycled direction. - Second, for those that have the same least apart distance in the above, the one that has less vertical offset wins. - added test coverage Follow-up work: - Dealing with window resizing issue - UMA, a11y Bug: 778438 Test: emulator tests and added test coverage Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I49be94635d5460e686f16b6e56fc2baf865ab794 Reviewed-on: https://chromium-review.googlesource.com/738826 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#515078} [modify] https://crrev.com/47c04677d74752db53c79b73f49e0e04e9f82c9c/ash/BUILD.gn [modify] https://crrev.com/47c04677d74752db53c79b73f49e0e04e9f82c9c/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/47c04677d74752db53c79b73f49e0e04e9f82c9c/ash/accelerators/accelerator_table.cc [modify] https://crrev.com/47c04677d74752db53c79b73f49e0e04e9f82c9c/ash/accelerators/accelerator_table.h [modify] https://crrev.com/47c04677d74752db53c79b73f49e0e04e9f82c9c/ash/accelerators/accelerator_table_unittest.cc [add] https://crrev.com/47c04677d74752db53c79b73f49e0e04e9f82c9c/ash/display/display_move_window_util.cc [add] https://crrev.com/47c04677d74752db53c79b73f49e0e04e9f82c9c/ash/display/display_move_window_util.h [add] https://crrev.com/47c04677d74752db53c79b73f49e0e04e9f82c9c/ash/display/display_move_window_util_unittest.cc [modify] https://crrev.com/47c04677d74752db53c79b73f49e0e04e9f82c9c/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/47c04677d74752db53c79b73f49e0e04e9f82c9c/chrome/browser/chromeos/events/event_rewriter_unittest.cc [modify] https://crrev.com/47c04677d74752db53c79b73f49e0e04e9f82c9c/chrome/browser/resources/chromeos/keyboard_overlay_data.js [modify] https://crrev.com/47c04677d74752db53c79b73f49e0e04e9f82c9c/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc [modify] https://crrev.com/47c04677d74752db53c79b73f49e0e04e9f82c9c/ui/chromeos/events/event_rewriter_chromeos.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46ea8e71877daed27fea7814b20a70655e830e6c commit 46ea8e71877daed27fea7814b20a70655e830e6c Author: Qiang Xu <warx@chromium.org> Date: Fri Nov 10 19:03:54 2017 cros: record user actions of accelerators moving window between displays changes: Record user actions when user presses accelerators to move active window between displays. Currently, - It will not record on unified desktop mode and mirror mode - It will record otherwise, even for the cases like single display, no active window. Bug: 778438 Test: tested on device and checked chrome://user-actions Change-Id: Idcaf2bd482e1b26db0d40657acb1c1a59b5c8f1f Reviewed-on: https://chromium-review.googlesource.com/760879 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#515623} [modify] https://crrev.com/46ea8e71877daed27fea7814b20a70655e830e6c/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/46ea8e71877daed27fea7814b20a70655e830e6c/tools/metrics/actions/actions.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76107e3c3cd111e2f9116a187ecbb5217eb273a9 commit 76107e3c3cd111e2f9116a187ecbb5217eb273a9 Author: Qiang Xu <warx@chromium.org> Date: Fri Dec 01 21:06:24 2017 cros: Using original-not-changed-by-user bounds when added to workspace changes: When window is added to a workspace from another workspace, its current window bounds possibly is not the original-not-changed-by-user bounds, for example a resized bounds truncated by available workarea. Using a member in ash::wm::WindowState to store the windows bounds. It is used in window added to workspace event from another workspace. It is set when window is removing from a workspace and it is nullptr (using pre_auto_manage_window_bounds() if it exists otherwise current window bounds). It gets reset when window bounds is changed by user. DisplayMoveWindowUtilTest.KeepWindowBoundsIfNotChangedByUser, also tested on emulator. Not-user-resized window bounds will not affect the original bounds when moving between displays. Bug: 785017 , 778438 Test: added the test coverage in Change-Id: I37d2c79238ea7200b32b5e3a9d5064addc575976 Reviewed-on: https://chromium-review.googlesource.com/770891 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#521063} [modify] https://crrev.com/76107e3c3cd111e2f9116a187ecbb5217eb273a9/ash/display/display_move_window_util_unittest.cc [modify] https://crrev.com/76107e3c3cd111e2f9116a187ecbb5217eb273a9/ash/wm/default_state.cc [modify] https://crrev.com/76107e3c3cd111e2f9116a187ecbb5217eb273a9/ash/wm/window_positioner.cc [modify] https://crrev.com/76107e3c3cd111e2f9116a187ecbb5217eb273a9/ash/wm/window_state.cc [modify] https://crrev.com/76107e3c3cd111e2f9116a187ecbb5217eb273a9/ash/wm/window_state.h [modify] https://crrev.com/76107e3c3cd111e2f9116a187ecbb5217eb273a9/ash/wm/workspace/workspace_layout_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8984cfa6f565570404c47d2cae23036166f1da0c commit 8984cfa6f565570404c47d2cae23036166f1da0c Author: Qiang Xu <warx@chromium.org> Date: Mon Dec 04 21:59:36 2017 m64 merge: cros: Using original-not-changed-by-user bounds when added to workspace changes: When window is added to a workspace from another workspace, its current window bounds possibly is not the original-not-changed-by-user bounds, for example a resized bounds truncated by available workarea. Using a member in ash::wm::WindowState to store the windows bounds. It is used in window added to workspace event from another workspace. It is set when window is removing from a workspace and it is nullptr (using pre_auto_manage_window_bounds() if it exists otherwise current window bounds). It gets reset when window bounds is changed by user. DisplayMoveWindowUtilTest.KeepWindowBoundsIfNotChangedByUser, also tested on emulator. Not-user-resized window bounds will not affect the original bounds when moving between displays. TBR=oshima@chromium.org (cherry picked from commit 76107e3c3cd111e2f9116a187ecbb5217eb273a9) Bug: 785017 , 778438 Test: added the test coverage in Change-Id: I37d2c79238ea7200b32b5e3a9d5064addc575976 Reviewed-on: https://chromium-review.googlesource.com/770891 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521063} Reviewed-on: https://chromium-review.googlesource.com/807206 Reviewed-by: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/branch-heads/3280@{#8} Cr-Branched-From: 12d6a1a2daf69e7fed839a65b0d1284021056b6a-refs/heads/master@{#519958} [modify] https://crrev.com/8984cfa6f565570404c47d2cae23036166f1da0c/ash/display/display_move_window_util_unittest.cc [modify] https://crrev.com/8984cfa6f565570404c47d2cae23036166f1da0c/ash/wm/default_state.cc [modify] https://crrev.com/8984cfa6f565570404c47d2cae23036166f1da0c/ash/wm/window_positioner.cc [modify] https://crrev.com/8984cfa6f565570404c47d2cae23036166f1da0c/ash/wm/window_state.cc [modify] https://crrev.com/8984cfa6f565570404c47d2cae23036166f1da0c/ash/wm/window_state.h [modify] https://crrev.com/8984cfa6f565570404c47d2cae23036166f1da0c/ash/wm/workspace/workspace_layout_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7e92107195ad7419aff15a12d2880c7ce644624 commit b7e92107195ad7419aff15a12d2880c7ce644624 Author: Qiang Xu <warx@chromium.org> Date: Thu Dec 07 21:02:11 2017 cros: add ash-enable-display-move-window-accels switch changes: Due to arc window movement targeted at M65, we decided to postpone this feature to M65. This CL is adding a flag and making it disabled by default. Bug: 773749, 778438 Test: tested on device and played with chrome://flags Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic82018812673a0d079ed8f4604ff9c914fc51865 Reviewed-on: https://chromium-review.googlesource.com/811947 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#522542} [modify] https://crrev.com/b7e92107195ad7419aff15a12d2880c7ce644624/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/b7e92107195ad7419aff15a12d2880c7ce644624/ash/public/cpp/ash_switches.cc [modify] https://crrev.com/b7e92107195ad7419aff15a12d2880c7ce644624/ash/public/cpp/ash_switches.h [modify] https://crrev.com/b7e92107195ad7419aff15a12d2880c7ce644624/chrome/browser/about_flags.cc [modify] https://crrev.com/b7e92107195ad7419aff15a12d2880c7ce644624/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/b7e92107195ad7419aff15a12d2880c7ce644624/chrome/browser/flag_descriptions.h [modify] https://crrev.com/b7e92107195ad7419aff15a12d2880c7ce644624/chrome/browser/resources/chromeos/keyboard_overlay.js [modify] https://crrev.com/b7e92107195ad7419aff15a12d2880c7ce644624/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc [modify] https://crrev.com/b7e92107195ad7419aff15a12d2880c7ce644624/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90912160706129efcfebb31d61a4b2f12cb43aa3 commit 90912160706129efcfebb31d61a4b2f12cb43aa3 Author: Qiang Xu <warx@chromium.org> Date: Fri Dec 08 05:09:45 2017 m64 merge: cros: add ash-enable-display-move-window-accels switch changes: Due to arc window movement targeted at M65, we decided to postpone this feature to M65. This CL is adding a flag and making it disabled by default. TBR=jamescook@chromium.org, stevenjb@chromium.org (cherry picked from commit b7e92107195ad7419aff15a12d2880c7ce644624) Bug: 773749, 778438 Test: tested on device and played with chrome://flags Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic82018812673a0d079ed8f4604ff9c914fc51865 Reviewed-on: https://chromium-review.googlesource.com/811947 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#522542} Reviewed-on: https://chromium-review.googlesource.com/816597 Reviewed-by: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#93} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/90912160706129efcfebb31d61a4b2f12cb43aa3/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/90912160706129efcfebb31d61a4b2f12cb43aa3/ash/public/cpp/ash_switches.cc [modify] https://crrev.com/90912160706129efcfebb31d61a4b2f12cb43aa3/ash/public/cpp/ash_switches.h [modify] https://crrev.com/90912160706129efcfebb31d61a4b2f12cb43aa3/chrome/browser/about_flags.cc [modify] https://crrev.com/90912160706129efcfebb31d61a4b2f12cb43aa3/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/90912160706129efcfebb31d61a4b2f12cb43aa3/chrome/browser/flag_descriptions.h [modify] https://crrev.com/90912160706129efcfebb31d61a4b2f12cb43aa3/chrome/browser/resources/chromeos/keyboard_overlay.js [modify] https://crrev.com/90912160706129efcfebb31d61a4b2f12cb43aa3/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc [modify] https://crrev.com/90912160706129efcfebb31d61a4b2f12cb43aa3/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81e2da8acdd54eeb8a4485133561c67f1aba5f65 commit 81e2da8acdd54eeb8a4485133561c67f1aba5f65 Author: Qiang Xu <warx@chromium.org> Date: Fri Dec 08 20:54:01 2017 cros: keep snapped window width ratio against display workarea width changes: - Keep snapped window width ratio against display workarea width. The ratio is updated on (1) snapped state entered (2) bounds event upon snapped state. The ratio is applied on adjusting snapped bounds. - WindowStateTest.UpdateSnapWidthRatioTest to test above change. - Add test coverage for crbug.com/688583 . - added test coverage for moving (maximized/fullscreen/snapped) window to another display. Bug: 783589 , 778438 , 688583 Test: emulator test and added test coverage Change-Id: Ibbc3afea87342e75c591c23ecd3a4fded5254cff Reviewed-on: https://chromium-review.googlesource.com/764114 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#522869} [modify] https://crrev.com/81e2da8acdd54eeb8a4485133561c67f1aba5f65/ash/display/display_move_window_util_unittest.cc [modify] https://crrev.com/81e2da8acdd54eeb8a4485133561c67f1aba5f65/ash/wm/default_state.cc [modify] https://crrev.com/81e2da8acdd54eeb8a4485133561c67f1aba5f65/ash/wm/window_state.cc [modify] https://crrev.com/81e2da8acdd54eeb8a4485133561c67f1aba5f65/ash/wm/window_state.h [modify] https://crrev.com/81e2da8acdd54eeb8a4485133561c67f1aba5f65/ash/wm/window_state_unittest.cc [modify] https://crrev.com/81e2da8acdd54eeb8a4485133561c67f1aba5f65/ash/wm/workspace/multi_window_resize_controller_unittest.cc [modify] https://crrev.com/81e2da8acdd54eeb8a4485133561c67f1aba5f65/ash/wm/workspace/workspace_layout_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26fabc6ec9decd780867ea7c1ce3ec03976a8e8a commit 26fabc6ec9decd780867ea7c1ce3ec03976a8e8a Author: Qiang Xu <warx@chromium.org> Date: Wed Jan 03 04:21:41 2018 cros: move transient children along with window changes: Implement WindowState::OnWindowAddedToRootWindow to handle MoveAllTransientChildrenToNewRoot. Bug: 789249, 778438 Test: emulator tests and added test coverage Change-Id: I9c4633902aaaca9da094c6398a4957f680a430df Reviewed-on: https://chromium-review.googlesource.com/804918 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#526618} [modify] https://crrev.com/26fabc6ec9decd780867ea7c1ce3ec03976a8e8a/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/26fabc6ec9decd780867ea7c1ce3ec03976a8e8a/ash/display/display_move_window_util.cc [modify] https://crrev.com/26fabc6ec9decd780867ea7c1ce3ec03976a8e8a/ash/display/display_move_window_util.h [modify] https://crrev.com/26fabc6ec9decd780867ea7c1ce3ec03976a8e8a/ash/display/display_move_window_util_unittest.cc [modify] https://crrev.com/26fabc6ec9decd780867ea7c1ce3ec03976a8e8a/ash/extended_desktop_unittest.cc [modify] https://crrev.com/26fabc6ec9decd780867ea7c1ce3ec03976a8e8a/ash/wm/window_positioning_utils.cc [modify] https://crrev.com/26fabc6ec9decd780867ea7c1ce3ec03976a8e8a/ash/wm/window_state.cc [modify] https://crrev.com/26fabc6ec9decd780867ea7c1ce3ec03976a8e8a/ash/wm/window_state.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/606fcb422c56e6678dc1ad44818d34911414fbd0 commit 606fcb422c56e6678dc1ad44818d34911414fbd0 Author: Qiang Xu <warx@chromium.org> Date: Sat Jan 06 03:58:26 2018 cros: move first-non-transient transient-parent if transient changes: Transient child window could get activated. In this case, shortcut to move active window between displays will move its first-non-transient transient-parent window. move browser window that has permission prompt shown and activated. Bug: 778438 Test: added test coverage. Also tested on device operating shortcuts to Change-Id: I5d24c2c8ecfc17c30b97fe16db025307c5b23810 Reviewed-on: https://chromium-review.googlesource.com/848696 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#527498} [modify] https://crrev.com/606fcb422c56e6678dc1ad44818d34911414fbd0/ash/display/display_move_window_util.cc [modify] https://crrev.com/606fcb422c56e6678dc1ad44818d34911414fbd0/ash/display/display_move_window_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8a2a53e560aec5b1316da12dc10065bdafc7aad commit e8a2a53e560aec5b1316da12dc10065bdafc7aad Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Jan 17 21:03:44 2018 Move client controlled window to other displays correctly. * Client controlled window will not change the bounds when the window is added to another root window, until it is instructe by a client. Explicitly send the bounds request. BUG= 778438 TEST=Covered by unit test. Manual. Change-Id: I5d0df9becb3168eaf5f372c8d83e4112d3dcb7f7 Reviewed-on: https://chromium-review.googlesource.com/869358 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#529889} [modify] https://crrev.com/e8a2a53e560aec5b1316da12dc10065bdafc7aad/ash/wm/client_controlled_state_unittest.cc [modify] https://crrev.com/e8a2a53e560aec5b1316da12dc10065bdafc7aad/ash/wm/window_util.cc
Eng work is pretty much done. We may do additional work in the future, something like 787572. But that will wait on user feedback.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58049b259e391c49d169db22580638331e2e6cc4 commit 58049b259e391c49d169db22580638331e2e6cc4 Author: Qiang Xu <warx@google.com> Date: Thu Mar 01 20:43:19 2018 cros: revise to use one shortcut for window movement changes: Base CL is: crrev.com/c/738826. UI review prefer one shortcut for this feature. So we are using "Search+Alt+m". Instead of allowing user specify moving direction, we just move window incrementally in sorted display id list and in a cycle manner. Bug: 778438 Test: tested on device and test coverage Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I35f946fd26885c0b435c437ef4dc766169989f8f Reviewed-on: https://chromium-review.googlesource.com/942001 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#540274} [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/ash/accelerators/accelerator_table.cc [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/ash/accelerators/accelerator_table.h [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/ash/accelerators/accelerator_table_unittest.cc [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/ash/components/shortcut_viewer/keyboard_shortcut_viewer_metadata.cc [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/ash/components/shortcut_viewer_strings.grdp [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/ash/display/display_move_window_util.cc [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/ash/display/display_move_window_util.h [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/ash/display/display_move_window_util_unittest.cc [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/ash/display/persistent_window_controller_unittest.cc [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/ash/public/interfaces/accessibility_controller.mojom [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/chrome/app/generated_resources.grd [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/chrome/browser/resources/chromeos/keyboard_overlay_data.js [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/chrome/browser/ui/ash/accessibility/accessibility_controller_client.cc [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/tools/metrics/actions/actions.xml [modify] https://crrev.com/58049b259e391c49d169db22580638331e2e6cc4/ui/chromeos/events/event_rewriter_chromeos.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df3b7bf759f6409b268249f6181ece4781535975 commit df3b7bf759f6409b268249f6181ece4781535975 Author: Qiang Xu <warx@google.com> Date: Thu Mar 08 21:09:11 2018 cros: enable keyboard shortcut to move active window between displays changes: Enable the feature by default. Also fix the bug that window cannot be moved. display::CreateDisplayIdList is sorting using the first 8 bits, pass that comparator to std::upper_bound too. TBR=stevenjb@chromium.org Bug: 778438 Test: tested on device. Change-Id: Ic8b9df780f99f0466805f8857e2cb0414a163999 Reviewed-on: https://chromium-review.googlesource.com/954361 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Qiang Xu <warx@google.com> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#541886} [modify] https://crrev.com/df3b7bf759f6409b268249f6181ece4781535975/ash/display/display_move_window_util.cc [modify] https://crrev.com/df3b7bf759f6409b268249f6181ece4781535975/ash/display/display_move_window_util_unittest.cc [modify] https://crrev.com/df3b7bf759f6409b268249f6181ece4781535975/ash/display/persistent_window_controller_unittest.cc [modify] https://crrev.com/df3b7bf759f6409b268249f6181ece4781535975/ash/public/cpp/ash_features.cc [modify] https://crrev.com/df3b7bf759f6409b268249f6181ece4781535975/ash/public/cpp/ash_features.h [modify] https://crrev.com/df3b7bf759f6409b268249f6181ece4781535975/ash/public/cpp/ash_switches.cc [modify] https://crrev.com/df3b7bf759f6409b268249f6181ece4781535975/ash/public/cpp/ash_switches.h [modify] https://crrev.com/df3b7bf759f6409b268249f6181ece4781535975/chrome/browser/about_flags.cc [modify] https://crrev.com/df3b7bf759f6409b268249f6181ece4781535975/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc [modify] https://crrev.com/df3b7bf759f6409b268249f6181ece4781535975/tools/metrics/histograms/enums.xml
merge request for m66 for #19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/001623585d1673fb030c32782653c9eb3cebb88c commit 001623585d1673fb030c32782653c9eb3cebb88c Author: Qiang Xu <warx@google.com> Date: Fri Mar 09 06:01:42 2018 m66 merge: cros: enable keyboard shortcut to move active window between displays changes: Enable the feature by default. Also fix the bug that window cannot be moved. display::CreateDisplayIdList is sorting using the first 8 bits, pass that comparator to std::upper_bound too. TBR=afakhry@chromium.org TBR=jamescook@chromium.org TBR=stevenjb@chromium.org (cherry picked from commit df3b7bf759f6409b268249f6181ece4781535975) Bug: 778438 Test: tested on device. Change-Id: Ic8b9df780f99f0466805f8857e2cb0414a163999 Reviewed-on: https://chromium-review.googlesource.com/954361 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Qiang Xu <warx@google.com> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#541886} Reviewed-on: https://chromium-review.googlesource.com/956931 Cr-Commit-Position: refs/branch-heads/3359@{#131} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/001623585d1673fb030c32782653c9eb3cebb88c/ash/display/display_move_window_util.cc [modify] https://crrev.com/001623585d1673fb030c32782653c9eb3cebb88c/ash/display/display_move_window_util_unittest.cc [modify] https://crrev.com/001623585d1673fb030c32782653c9eb3cebb88c/ash/display/persistent_window_controller_unittest.cc [modify] https://crrev.com/001623585d1673fb030c32782653c9eb3cebb88c/ash/public/cpp/ash_features.cc [modify] https://crrev.com/001623585d1673fb030c32782653c9eb3cebb88c/ash/public/cpp/ash_features.h [modify] https://crrev.com/001623585d1673fb030c32782653c9eb3cebb88c/ash/public/cpp/ash_switches.cc [modify] https://crrev.com/001623585d1673fb030c32782653c9eb3cebb88c/ash/public/cpp/ash_switches.h [modify] https://crrev.com/001623585d1673fb030c32782653c9eb3cebb88c/chrome/browser/about_flags.cc [modify] https://crrev.com/001623585d1673fb030c32782653c9eb3cebb88c/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc [modify] https://crrev.com/001623585d1673fb030c32782653c9eb3cebb88c/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/765bd7495102533c9d18516ed164f535182e9839 commit 765bd7495102533c9d18516ed164f535182e9839 Author: Qiang Xu <warx@google.com> Date: Tue Jun 26 01:29:08 2018 cros: remove ash-enable-display-move-window-accels flag Feature is landed in M66. Now we can remove the flag in M69. Bug: 778438 Test: manual Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Icd56cda2c4cd61677f4724c11ccf4b946eae24ae Reviewed-on: https://chromium-review.googlesource.com/1113077 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#570284} [modify] https://crrev.com/765bd7495102533c9d18516ed164f535182e9839/ash/display/display_move_window_util.cc [modify] https://crrev.com/765bd7495102533c9d18516ed164f535182e9839/ash/display/display_move_window_util_unittest.cc [modify] https://crrev.com/765bd7495102533c9d18516ed164f535182e9839/ash/display/persistent_window_controller_unittest.cc [modify] https://crrev.com/765bd7495102533c9d18516ed164f535182e9839/ash/public/cpp/ash_features.cc [modify] https://crrev.com/765bd7495102533c9d18516ed164f535182e9839/ash/public/cpp/ash_features.h [modify] https://crrev.com/765bd7495102533c9d18516ed164f535182e9839/ash/public/cpp/ash_switches.h [modify] https://crrev.com/765bd7495102533c9d18516ed164f535182e9839/chrome/browser/about_flags.cc [modify] https://crrev.com/765bd7495102533c9d18516ed164f535182e9839/chrome/browser/resources/chromeos/keyboard_overlay.js [modify] https://crrev.com/765bd7495102533c9d18516ed164f535182e9839/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
Comment 1 by warx@chromium.org
, Oct 25 2017