New issue
Advanced search Search tips

Issue 778433 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

clean up fixed-body-background-positioned.html

Project Member Reported by skobes@chromium.org, Oct 25 2017

Issue description

This test has the following code:

  var layerTree = internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_ROOT_LAYER);
  if (layerTree.indexOf('\n    {\n\n    }\n') != -1)
      layerTree = internals.layerTreeAsText(document, 1 | internals.LAYER_TREE_INCLUDES_ROOT_LAYER);

It doesn't make sense to call layerTreeAsText twice, and there are no comments to indicate the significance of the string '\n    {\n\n    }\n'.  We should decide what flags are appropriate, and pass them the first time.

(Further note: http://crrev.com/1151153003 seems to have been landed TBR without code review.  I think this is not an appropriate use of TBR per https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#TBR-To-Be-Reviewed.  Changes to layout tests should go through the same review process as normal code.)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3be9477acd8c219336190c84da187e7c94663553

commit 3be9477acd8c219336190c84da187e7c94663553
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Oct 26 00:57:15 2017

Remove debug code in compositing/fixed-body-background-positioned.html

The code was added to catch occasional failures on bots. It executed
only when the test failed in a particular way, to show debug
information in the output. It was supposed to be temporary and to
be reverted once a failure was caught. Sorry for leaving it until now.

The failure has never occurred since we enabled slimming paint.

Bug:  778433 
Change-Id: Ia2e1b3e936558f0236e7d83f6c4c752f9ae043cc
Reviewed-on: https://chromium-review.googlesource.com/738866
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511671}
[modify] https://crrev.com/3be9477acd8c219336190c84da187e7c94663553/third_party/WebKit/LayoutTests/compositing/fixed-body-background-positioned.html

Status: Fixed (was: Assigned)

Sign in to add a comment