New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778418 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make service_manager::TestConnector support services that use BinderRegistry.

Project Member Reported by jcivelli@chromium.org, Oct 25 2017

Issue description

service_manager::TestConnector does not work with services that use a BinderRegistry.
These services require their OnStart() method to be called, which require a ServiceContext.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e142549a40529b7c7544c0c70c466958c89a80a

commit 7e142549a40529b7c7544c0c70c466958c89a80a
Author: Jay Civelli <jcivelli@google.com>
Date: Fri Oct 27 23:30:08 2017

Adding support for services that use BinderRegistry to TestConnector.

Making service_manager::TestConnector support services that use a
BinderRegistry by ensuring the OnStart() method is called and that a
ServiceContext is available.

Bug:  778418 
Tbr: jamescook@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I50b28eba18fd4bd5095c066f180602ebf15e04f2
Reviewed-on: https://chromium-review.googlesource.com/738642
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512345}
[modify] https://crrev.com/7e142549a40529b7c7544c0c70c466958c89a80a/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service_unittest.cc
[modify] https://crrev.com/7e142549a40529b7c7544c0c70c466958c89a80a/chrome/browser/chromeos/note_taking_helper_unittest.cc
[modify] https://crrev.com/7e142549a40529b7c7544c0c70c466958c89a80a/services/service_manager/public/cpp/test/test_connector_factory.cc
[modify] https://crrev.com/7e142549a40529b7c7544c0c70c466958c89a80a/services/service_manager/public/cpp/test/test_connector_factory.h
[modify] https://crrev.com/7e142549a40529b7c7544c0c70c466958c89a80a/services/service_manager/tests/test_support_unittest.cc
[modify] https://crrev.com/7e142549a40529b7c7544c0c70c466958c89a80a/ui/gl/test/run_all_unittests.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment