New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778411 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Proj-XR
Proj-XR-VR


Show other hotlists

Hotlists containing this issue:
VR-Automated-Tests


Sign in to add a comment

Show URL bar info icon on http:// pages.

Project Member Reported by cjgrant@chromium.org, Oct 25 2017

Issue description

As per guidance from UX, we should return to showing the (i) icon for http:// pages.  The V1 VR browser spec will be updated to reflect this.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ffec3d48a5f12d4bb04145f2d475643b4defed1

commit 6ffec3d48a5f12d4bb04145f2d475643b4defed1
Author: Christopher Grant <cjgrant@chromium.org>
Date: Thu Nov 16 19:16:18 2017

VR: Show the info icon with URL if no other security state

Chrome security is trending away from showing the URL scheme, to an
icon-based representation. To support that, we should return to showing
the info icon if there is no other state (either secure or dangerous).

BUG= 778411 
R=bshe

Change-Id: Ic6ec0af9ff628bcacab55484a7e584339e59528f
Reviewed-on: https://chromium-review.googlesource.com/773119
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517146}
[modify] https://crrev.com/6ffec3d48a5f12d4bb04145f2d475643b4defed1/chrome/browser/vr/elements/url_bar_texture.cc

FYI, the VR Omnibox has been updated to show the (i) icon state for HTTP, as well as https/mixed. Additionally, there are redlines showing measurements for elements within Omnibox.
Gordon,

https/mixed should already work.  VR doesn't determine the icon, it's chosen by common (desktop) omnibox code that (I believe) clank also makes use of.  I simply removed the special case to not show an icon if the security state is 'None'.  So, now, we always show an icon.

Note that this is making us inconsistent with what clank does today.  I assume we're leading the way though, and you expect Clank will follow.

Dimensions updates should be tracked separately IMO.  I'll check out the new spec.
Status: Fixed (was: Assigned)
We're due for a lot of shuffling of the URL bar, to both split off the back button, and incorporate the future overflow menu and tab selector.  That seems lie the correct time to tweak (if necessary) the spacing of the existing fields.

Marking this fixed.
Verification:  To test this, potentially use badssl.com to view a plain HTTP site, and ensure that the (i) icon is visible.  Ie, there is no site on which it's possible to see no security icon.
wfm
Labels: Test-Manual
Labels: Test-Manual
Labels: M-64

Sign in to add a comment