New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 778409 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Display estimated effective connection type on chrome://interventions-internals

Project Member Reported by thanhdle@chromium.org, Oct 25 2017

Issue description

The chrome://interventions-internals page does not show any information about the current effective connection type (ECT). It is helpful to have the information displayed on the page, and update it whenever the ECT changes.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83b94df26890658229ed07a38b3e45f98fe32d98

commit 83b94df26890658229ed07a38b3e45f98fe32d98
Author: Thanh Le <thanhdle@chromium.org>
Date: Thu Oct 26 07:16:44 2017

Display estimated effective connection type of chrome://interventions-internals.

The page is notified when there's a change in effective connection type.

Bug:  778409 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ied4a037d2d94c52c3ef9d76b1984227fe9610d11
Reviewed-on: https://chromium-review.googlesource.com/738636
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511758}
[modify] https://crrev.com/83b94df26890658229ed07a38b3e45f98fe32d98/chrome/browser/resources/interventions_internals/index.html
[modify] https://crrev.com/83b94df26890658229ed07a38b3e45f98fe32d98/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/83b94df26890658229ed07a38b3e45f98fe32d98/chrome/browser/ui/webui/interventions_internals/interventions_internals.mojom
[modify] https://crrev.com/83b94df26890658229ed07a38b3e45f98fe32d98/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc
[modify] https://crrev.com/83b94df26890658229ed07a38b3e45f98fe32d98/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.h
[modify] https://crrev.com/83b94df26890658229ed07a38b3e45f98fe32d98/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/83b94df26890658229ed07a38b3e45f98fe32d98/chrome/browser/ui/webui/interventions_internals/interventions_internals_ui.cc
[modify] https://crrev.com/83b94df26890658229ed07a38b3e45f98fe32d98/chrome/browser/ui/webui/interventions_internals/interventions_internals_ui.h
[modify] https://crrev.com/83b94df26890658229ed07a38b3e45f98fe32d98/chrome/test/data/webui/interventions_internals_browsertest.js

Status: Fixed (was: Started)

Comment 3 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 4 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Sign in to add a comment